From: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
To: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Sibi Sankar" <sibi.sankar@oss.qualcomm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Maya Matuszczyk <maccraft123mc@gmail.com>
Subject: Re: [PATCH v4 2/5] platform: arm64: Add driver for EC found on Qualcomm reference devices
Date: Fri, 13 Mar 2026 19:43:54 +0530 [thread overview]
Message-ID: <b734c3bd-c54e-4463-a93f-0a9b89f2d7d6@oss.qualcomm.com> (raw)
In-Reply-To: <9241da21-6b02-434d-a746-6bccc25a335d@linaro.org>
On 3/13/2026 5:47 PM, Bryan O'Donoghue wrote:
> On 13/03/2026 10:29, Anvesh Jain P wrote:
>> + * Read Response:
>> + *
>> ----------------------------------------------------------------------
>> + * | Offset | Name | Description |
>> + *
>> ----------------------------------------------------------------------
>> + * | 0x00 | Byte count | Number of bytes in response |
>> + * | | | (exluding byte count) |
>
> Great to see this documented in the code.
>
> Please run checkpatch and take heed of what it says.
>
> 0002-platform-arm64-Add-driver-for-EC-found-on-Qualcomm-r.patch has no
> obvious style problems and is ready for submission.
> 0002-platform-arm64-Add-driver-for-EC-found-on-Qualcomm-r.patch:184:
> exluding ==> excluding, exuding
> 0002-platform-arm64-Add-driver-for-EC-found-on-Qualcomm-r.patch:224:
> exluding ==> excluding, exuding
> total: 0 errors, 0 warnings, 0 checks, 28 lines checked
Thanks for the review! Confirmed the typo — will fix both occurrences in
the next revision of the patch series.
>
> ---
> bod
Best regards,
Anvesh
next prev parent reply other threads:[~2026-03-13 14:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 10:29 [PATCH v4 0/5] " Anvesh Jain P
2026-03-13 10:29 ` [PATCH v4 1/5] dt-bindings: embedded-controller: Add EC bindings for " Anvesh Jain P
2026-03-13 19:01 ` Krzysztof Kozlowski
2026-03-16 9:37 ` Anvesh Jain P
2026-03-13 10:29 ` [PATCH v4 2/5] platform: arm64: Add driver for EC found on " Anvesh Jain P
2026-03-13 12:17 ` Bryan O'Donoghue
2026-03-13 14:13 ` Anvesh Jain P [this message]
2026-03-13 14:35 ` Dmitry Baryshkov
2026-03-13 17:24 ` Anvesh Jain P
2026-03-13 19:05 ` Krzysztof Kozlowski
2026-03-16 9:43 ` Anvesh Jain P
2026-03-16 10:27 ` Konrad Dybcio
2026-03-16 17:07 ` Anvesh Jain P
2026-03-16 10:29 ` Konrad Dybcio
2026-03-16 17:20 ` Anvesh Jain P
2026-03-16 13:23 ` kernel test robot
2026-03-16 17:28 ` kernel test robot
2026-03-13 10:29 ` [PATCH v4 3/5] arm64: dts: qcom: glymur-crd: Add Embedded controller node Anvesh Jain P
2026-03-13 15:49 ` Dmitry Baryshkov
2026-03-16 10:46 ` Konrad Dybcio
2026-03-13 10:29 ` [PATCH v4 4/5] arm64: dts: qcom: x1-crd: " Anvesh Jain P
2026-03-13 15:49 ` Dmitry Baryshkov
2026-03-16 10:45 ` Konrad Dybcio
2026-03-13 10:29 ` [PATCH v4 5/5] arm64: dts: qcom: hamoa-iot-evk: " Anvesh Jain P
2026-03-13 15:49 ` Dmitry Baryshkov
2026-03-16 10:45 ` Konrad Dybcio
2026-03-13 12:18 ` [PATCH v4 0/5] Add driver for EC found on Qualcomm reference devices Bryan O'Donoghue
2026-03-13 13:15 ` Anvesh Jain P
2026-03-13 16:26 ` Bryan O'Donoghue
2026-03-13 17:17 ` Dmitry Baryshkov
2026-03-14 4:09 ` Bryan O'Donoghue
2026-03-16 10:22 ` Anvesh Jain P
2026-03-16 13:31 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b734c3bd-c54e-4463-a93f-0a9b89f2d7d6@oss.qualcomm.com \
--to=anvesh.p@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maccraft123mc@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®