From: Andrew Lunn <andrew@lunn.ch>
To: Chaoyi Chen <kernel@airkyi.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Alexey Charkov <alchark@gmail.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Chaoyi Chen <chaoyi.chen@rock-chips.com>,
Andy Yan <andy.yan@rock-chips.com>,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
Detlev Casanova <detlev.casanova@collabora.com>,
Stephen Chen <stephen@radxa.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 evb1
Date: Wed, 21 Jan 2026 13:55:57 +0100 [thread overview]
Message-ID: <b87d0c82-b8b7-4e14-85c3-c4ba88aa4000@lunn.ch> (raw)
In-Reply-To: <20260121031548.402-2-kernel@airkyi.com>
> @@ -721,6 +719,7 @@ rgmii_phy0: ethernet-phy@1 {
> reset-assert-us = <20000>;
> reset-deassert-us = <100000>;
> reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
> + tx-internal-delay-ps = <1950>;
The PHY should add 2000ps, as required by the RGMII standard. The
difference is so small there is no need for tx-internal-delay.
In most cases, 'rmgii-id' should be sufficient, unless the PCB is
badly designed.
Andrew
next prev parent reply other threads:[~2026-01-21 12:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 3:15 [PATCH 0/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 board Chaoyi Chen
2026-01-21 3:15 ` [PATCH 1/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 evb1 Chaoyi Chen
2026-01-21 8:14 ` Diederik de Haas
2026-01-21 12:55 ` Andrew Lunn [this message]
2026-01-22 1:38 ` Chaoyi Chen
2026-01-22 2:40 ` Andrew Lunn
2026-01-22 3:16 ` Chaoyi Chen
2026-01-31 6:26 ` Chaoyi Chen
2026-01-21 3:15 ` [PATCH 2/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for roc-rk3576-pc Chaoyi Chen
2026-01-21 3:15 ` [PATCH 3/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for ROCK 4D Chaoyi Chen
2026-01-21 5:51 ` [PATCH 0/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 board Sebastian Reichel
2026-01-21 6:54 ` Chaoyi Chen
2026-01-21 13:02 ` Andrew Lunn
2026-01-21 12:57 ` Andrew Lunn
2026-01-22 1:44 ` Chaoyi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b87d0c82-b8b7-4e14-85c3-c4ba88aa4000@lunn.ch \
--to=andrew@lunn.ch \
--cc=alchark@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=chaoyi.chen@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=detlev.casanova@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@airkyi.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.lin@rock-chips.com \
--cc=stephen@radxa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®