* [PATCH] soc: xilinx: Remove redundant dev_err()
@ 2026-07-23 2:28 Pan Chuang
2026-07-23 6:50 ` Michal Simek
2026-07-24 6:58 ` Prasanna Kumar T S M
0 siblings, 2 replies; 3+ messages in thread
From: Pan Chuang @ 2026-07-23 2:28 UTC (permalink / raw)
To: Michal Simek, Prasanna Kumar T S M, Radhey Shyam Pandey,
Marco Crivellari, Jay Buddhabhatti, Pan Chuang,
moderated list:ARM/ZYNQ ARCHITECTURE, open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Acked-by: Michal Simek <michal.simek@amd.com>
---
drivers/soc/xilinx/zynqmp_power.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
index 370e61ac47d8..54c796afb89e 100644
--- a/drivers/soc/xilinx/zynqmp_power.c
+++ b/drivers/soc/xilinx/zynqmp_power.c
@@ -368,11 +368,8 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
IRQF_NO_SUSPEND | IRQF_ONESHOT,
dev_name(&pdev->dev),
&pdev->dev);
- if (ret) {
- dev_err(&pdev->dev, "devm_request_threaded_irq '%d' failed with %d\n",
- irq, ret);
+ if (ret)
return ret;
- }
} else {
dev_err(&pdev->dev, "Required property not found in DT node\n");
return -ENOENT;
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: xilinx: Remove redundant dev_err()
2026-07-23 2:28 [PATCH] soc: xilinx: Remove redundant dev_err() Pan Chuang
@ 2026-07-23 6:50 ` Michal Simek
2026-07-24 6:58 ` Prasanna Kumar T S M
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2026-07-23 6:50 UTC (permalink / raw)
To: Pan Chuang, Prasanna Kumar T S M, Radhey Shyam Pandey,
Marco Crivellari, Jay Buddhabhatti,
moderated list:ARM/ZYNQ ARCHITECTURE, open list
On 7/23/26 04:28, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> Acked-by: Michal Simek <michal.simek@amd.com>
> ---
> drivers/soc/xilinx/zynqmp_power.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
> index 370e61ac47d8..54c796afb89e 100644
> --- a/drivers/soc/xilinx/zynqmp_power.c
> +++ b/drivers/soc/xilinx/zynqmp_power.c
> @@ -368,11 +368,8 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
> IRQF_NO_SUSPEND | IRQF_ONESHOT,
> dev_name(&pdev->dev),
> &pdev->dev);
> - if (ret) {
> - dev_err(&pdev->dev, "devm_request_threaded_irq '%d' failed with %d\n",
> - irq, ret);
> + if (ret)
> return ret;
> - }
> } else {
> dev_err(&pdev->dev, "Required property not found in DT node\n");
> return -ENOENT;
Applied.
M
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: xilinx: Remove redundant dev_err()
2026-07-23 2:28 [PATCH] soc: xilinx: Remove redundant dev_err() Pan Chuang
2026-07-23 6:50 ` Michal Simek
@ 2026-07-24 6:58 ` Prasanna Kumar T S M
1 sibling, 0 replies; 3+ messages in thread
From: Prasanna Kumar T S M @ 2026-07-24 6:58 UTC (permalink / raw)
To: Pan Chuang, Michal Simek, Radhey Shyam Pandey, Marco Crivellari,
Jay Buddhabhatti, moderated list:ARM/ZYNQ ARCHITECTURE,
open list
On 23-07-2026 07:58, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> Acked-by: Michal Simek <michal.simek@amd.com>
> ---
> drivers/soc/xilinx/zynqmp_power.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
> index 370e61ac47d8..54c796afb89e 100644
> --- a/drivers/soc/xilinx/zynqmp_power.c
> +++ b/drivers/soc/xilinx/zynqmp_power.c
> @@ -368,11 +368,8 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
> IRQF_NO_SUSPEND | IRQF_ONESHOT,
> dev_name(&pdev->dev),
> &pdev->dev);
> - if (ret) {
> - dev_err(&pdev->dev, "devm_request_threaded_irq '%d' failed with %d\n",
> - irq, ret);
> + if (ret)
> return ret;
> - }
> } else {
> dev_err(&pdev->dev, "Required property not found in DT node\n");
> return -ENOENT;
Looks good to me.
Reviewed-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-24 6:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-23 2:28 [PATCH] soc: xilinx: Remove redundant dev_err() Pan Chuang
2026-07-23 6:50 ` Michal Simek
2026-07-24 6:58 ` Prasanna Kumar T S M
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®