mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
	"Wanpeng Li" <wanpeng.li@hotmail.com>
Subject: Re: [PATCH v2 2/3] KVM: VMX: Fix enable VPID even if INVVPID is not exposed in vmx capability
Date: Tue, 21 Mar 2017 17:19:40 +0100	[thread overview]
Message-ID: <baf887b9-7a36-16f4-b020-2acd0ecd53d9@redhat.com> (raw)
In-Reply-To: <1490069935-6232-2-git-send-email-wanpeng.li@hotmail.com>



On 21/03/2017 05:18, Wanpeng Li wrote:
> -	if (!cpu_has_vmx_vpid())
> +	if (!cpu_has_vmx_vpid() ||
> +		!(cpu_has_vmx_invvpid()))

Too many parentheses and a useless line break.

Paolo

>  		enable_vpid = 0;

  parent reply	other threads:[~2017-03-21 16:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  4:18 [PATCH v2 1/3] KVM: nVMX: Fix nested VPID vmx exec control Wanpeng Li
2017-03-21  4:18 ` [PATCH v2 2/3] KVM: VMX: Fix enable VPID even if INVVPID is not exposed in vmx capability Wanpeng Li
2017-03-21  8:50   ` David Hildenbrand
2017-03-21  8:58     ` Wanpeng Li
2017-03-21  9:01       ` David Hildenbrand
2017-03-21  9:05         ` Wanpeng Li
2017-03-21  9:15       ` David Hildenbrand
2017-03-21 16:19   ` Paolo Bonzini [this message]
2017-03-21  4:18 ` [PATCH v2 3/3] KVM: x86: correct async page present tracepoint Wanpeng Li
2017-03-21  8:57   ` David Hildenbrand
2017-03-21 16:19 ` [PATCH v2 1/3] KVM: nVMX: Fix nested VPID vmx exec control Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=baf887b9-7a36-16f4-b020-2acd0ecd53d9@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkrcmar@redhat.com \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®