mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	linux-pci <linux-pci@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] pci: endpoint: fix endpoint test build error
Date: Mon, 12 Jun 2017 13:59:08 +0530	[thread overview]
Message-ID: <bb2a288e-8f90-a204-c0fe-8e8a09afa087@ti.com> (raw)
In-Reply-To: <89a5b4f8-69bb-a5bc-5400-06c24050595d@infradead.org>



On Monday 12 June 2017 07:40 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> PCI endpoint test driver uses crc32_le() so it should select
> CRC32. Fixes this build error (when CRC32=m):
> 
>   drivers/built-in.o: In function `pci_epf_test_cmd_handler':
>   pci-epf-test.c:(.text+0x2d98d): undefined reference to `crc32_le'
> 
> Fixes 349e7a85b25f (PCI: endpoint: functions: Add an EP function to test PCI).
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>

Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  drivers/pci/endpoint/functions/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- lnx-412-rc4.orig/drivers/pci/endpoint/functions/Kconfig
> +++ lnx-412-rc4/drivers/pci/endpoint/functions/Kconfig
> @@ -5,6 +5,7 @@
>  config PCI_EPF_TEST
>  	tristate "PCI Endpoint Test driver"
>  	depends on PCI_ENDPOINT
> +	select CRC32
>  	help
>  	   Enable this configuration option to enable the test driver
>  	   for PCI Endpoint.
> 
> 

  reply	other threads:[~2017-06-12  8:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12  2:10 Randy Dunlap
2017-06-12  8:29 ` Kishon Vijay Abraham I [this message]
2017-06-12 20:48 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb2a288e-8f90-a204-c0fe-8e8a09afa087@ti.com \
    --to=kishon@ti.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®