* [PATCH] pci: endpoint: fix endpoint test build error
@ 2017-06-12 2:10 Randy Dunlap
2017-06-12 8:29 ` Kishon Vijay Abraham I
2017-06-12 20:48 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2017-06-12 2:10 UTC (permalink / raw)
To: linux-pci, LKML, Bjorn Helgaas; +Cc: Kishon Vijay Abraham I
From: Randy Dunlap <rdunlap@infradead.org>
PCI endpoint test driver uses crc32_le() so it should select
CRC32. Fixes this build error (when CRC32=m):
drivers/built-in.o: In function `pci_epf_test_cmd_handler':
pci-epf-test.c:(.text+0x2d98d): undefined reference to `crc32_le'
Fixes 349e7a85b25f (PCI: endpoint: functions: Add an EP function to test PCI).
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/endpoint/functions/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- lnx-412-rc4.orig/drivers/pci/endpoint/functions/Kconfig
+++ lnx-412-rc4/drivers/pci/endpoint/functions/Kconfig
@@ -5,6 +5,7 @@
config PCI_EPF_TEST
tristate "PCI Endpoint Test driver"
depends on PCI_ENDPOINT
+ select CRC32
help
Enable this configuration option to enable the test driver
for PCI Endpoint.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pci: endpoint: fix endpoint test build error
2017-06-12 2:10 [PATCH] pci: endpoint: fix endpoint test build error Randy Dunlap
@ 2017-06-12 8:29 ` Kishon Vijay Abraham I
2017-06-12 20:48 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Kishon Vijay Abraham I @ 2017-06-12 8:29 UTC (permalink / raw)
To: Randy Dunlap, linux-pci, LKML, Bjorn Helgaas
On Monday 12 June 2017 07:40 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> PCI endpoint test driver uses crc32_le() so it should select
> CRC32. Fixes this build error (when CRC32=m):
>
> drivers/built-in.o: In function `pci_epf_test_cmd_handler':
> pci-epf-test.c:(.text+0x2d98d): undefined reference to `crc32_le'
>
> Fixes 349e7a85b25f (PCI: endpoint: functions: Add an EP function to test PCI).
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/pci/endpoint/functions/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-412-rc4.orig/drivers/pci/endpoint/functions/Kconfig
> +++ lnx-412-rc4/drivers/pci/endpoint/functions/Kconfig
> @@ -5,6 +5,7 @@
> config PCI_EPF_TEST
> tristate "PCI Endpoint Test driver"
> depends on PCI_ENDPOINT
> + select CRC32
> help
> Enable this configuration option to enable the test driver
> for PCI Endpoint.
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pci: endpoint: fix endpoint test build error
2017-06-12 2:10 [PATCH] pci: endpoint: fix endpoint test build error Randy Dunlap
2017-06-12 8:29 ` Kishon Vijay Abraham I
@ 2017-06-12 20:48 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2017-06-12 20:48 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-pci, LKML, Bjorn Helgaas, Kishon Vijay Abraham I
On Sun, Jun 11, 2017 at 07:10:38PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> PCI endpoint test driver uses crc32_le() so it should select
> CRC32. Fixes this build error (when CRC32=m):
>
> drivers/built-in.o: In function `pci_epf_test_cmd_handler':
> pci-epf-test.c:(.text+0x2d98d): undefined reference to `crc32_le'
>
> Fixes 349e7a85b25f (PCI: endpoint: functions: Add an EP function to test PCI).
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied with Kishon's ack to for-linus for v4.12 (since 349e7a85b25f first
appeared in v4.12-rc1), thanks!
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/pci/endpoint/functions/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-412-rc4.orig/drivers/pci/endpoint/functions/Kconfig
> +++ lnx-412-rc4/drivers/pci/endpoint/functions/Kconfig
> @@ -5,6 +5,7 @@
> config PCI_EPF_TEST
> tristate "PCI Endpoint Test driver"
> depends on PCI_ENDPOINT
> + select CRC32
> help
> Enable this configuration option to enable the test driver
> for PCI Endpoint.
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-12 20:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-12 2:10 [PATCH] pci: endpoint: fix endpoint test build error Randy Dunlap
2017-06-12 8:29 ` Kishon Vijay Abraham I
2017-06-12 20:48 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®