From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Claudiu <claudiu.beznea@tuxon.dev>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH net-next v2 1/5] net: ravb: Get rid of the temporary variable irq
Date: Fri, 9 Feb 2024 23:04:11 +0300 [thread overview]
Message-ID: <bbe3b99e-99e5-8ffb-3361-91796969fd11@omp.ru> (raw)
In-Reply-To: <20240209170459.4143861-2-claudiu.beznea.uj@bp.renesas.com>
On 2/9/24 8:04 PM, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> The 4th argument of ravb_setup_irq() is used to save the IRQ number that
> will be further used by the driver code. Not all ravb_setup_irqs() calls
> need to save the IRQ number. The previous code used to pass a dummy
> variable as the 4th argument in case the IRQ is not needed for further
> usage. That is not necessary as the code from ravb_setup_irq() can detect
> by itself if the IRQ needs to be saved. Thus, get rid of the code that is
> not needed.
>
> Reported-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
next prev parent reply other threads:[~2024-02-09 20:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 17:04 [PATCH net-next v2 0/5] net: ravb: Add runtime PM support (part 2) Claudiu
2024-02-09 17:04 ` [PATCH net-next v2 1/5] net: ravb: Get rid of the temporary variable irq Claudiu
2024-02-09 20:04 ` Sergey Shtylyov [this message]
2024-02-09 17:04 ` [PATCH net-next v2 2/5] net: ravb: Keep the reverse order of operations in ravb_close() Claudiu
2024-02-09 17:04 ` [PATCH net-next v2 3/5] net: ravb: Return cached statistics if the interface is down Claudiu
2024-02-09 17:04 ` [PATCH net-next v2 4/5] net: ravb: Do not apply RX checksum settings to hardware " Claudiu
2024-02-09 17:11 ` Biju Das
2024-02-09 20:27 ` Sergey Shtylyov
2024-02-09 20:41 ` Biju Das
2024-02-10 20:37 ` Sergey Shtylyov
2024-02-09 17:04 ` [PATCH net-next v2 5/5] net: ravb: Add runtime PM support Claudiu
2024-02-09 21:00 ` Sergey Shtylyov
2024-02-12 7:56 ` claudiu beznea
2024-02-12 20:19 ` Sergey Shtylyov
2024-02-13 6:59 ` claudiu beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbe3b99e-99e5-8ffb-3361-91796969fd11@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®