From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Claudiu <claudiu.beznea@tuxon.dev>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH net-next v2 4/5] net: ravb: Do not apply RX checksum settings to hardware if the interface is down
Date: Fri, 9 Feb 2024 23:27:15 +0300 [thread overview]
Message-ID: <6f907f89-7588-fd99-1a63-8291f9e29c81@omp.ru> (raw)
In-Reply-To: <20240209170459.4143861-5-claudiu.beznea.uj@bp.renesas.com>
On 2/9/24 8:04 PM, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Do not apply the RX checksum settings to hardware if the interface is down.
> In case runtime PM is enabled, and while the interface is down, the IP will
> be in reset mode (as for some platforms disabling the clocks will switch
> the IP to reset mode, which will lead to losing register contents) and
> applying settings in reset mode is not an option. Instead, cache the RX
> checksum settings and apply them in ravb_open() through ravb_emac_init().
> This has been solved by introducing pm_runtime_active() check. The device
> runtime PM usage counter has been incremented to avoid disabling the device
> clocks while the check is in progress (if any).
>
> Commit prepares for the addition of runtime PM.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
next prev parent reply other threads:[~2024-02-09 20:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 17:04 [PATCH net-next v2 0/5] net: ravb: Add runtime PM support (part 2) Claudiu
2024-02-09 17:04 ` [PATCH net-next v2 1/5] net: ravb: Get rid of the temporary variable irq Claudiu
2024-02-09 20:04 ` Sergey Shtylyov
2024-02-09 17:04 ` [PATCH net-next v2 2/5] net: ravb: Keep the reverse order of operations in ravb_close() Claudiu
2024-02-09 17:04 ` [PATCH net-next v2 3/5] net: ravb: Return cached statistics if the interface is down Claudiu
2024-02-09 17:04 ` [PATCH net-next v2 4/5] net: ravb: Do not apply RX checksum settings to hardware " Claudiu
2024-02-09 17:11 ` Biju Das
2024-02-09 20:27 ` Sergey Shtylyov [this message]
2024-02-09 20:41 ` Biju Das
2024-02-10 20:37 ` Sergey Shtylyov
2024-02-09 17:04 ` [PATCH net-next v2 5/5] net: ravb: Add runtime PM support Claudiu
2024-02-09 21:00 ` Sergey Shtylyov
2024-02-12 7:56 ` claudiu beznea
2024-02-12 20:19 ` Sergey Shtylyov
2024-02-13 6:59 ` claudiu beznea
2024-02-11 8:56 [PATCH net-next v2 4/5] net: ravb: Do not apply RX checksum settings to hardware if the interface is down Biju Das
2024-02-11 9:40 ` Sergei Shtylyov
2024-02-11 12:13 ` Biju Das
2024-02-11 12:29 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f907f89-7588-fd99-1a63-8291f9e29c81@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®