mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/3] irqchip: qcom: Add sane defaults and drop defconfig
@ 2026-07-27 11:44 Krzysztof Kozlowski
  2026-07-27 11:44 ` [PATCH 1/3] irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-27 11:44 UTC (permalink / raw)
  To: Thomas Gleixner, Radu Rendec, Bjorn Andersson, Konrad Dybcio
  Cc: linux-kernel, linux-arm-msm, Krzysztof Kozlowski

Merging
=======
1. First irqchip patches via irqchip.
2. defconfig next cycle via Qualcomm SoC tree.

We should not be really asking whether to enable internal SoC drivers.
This is an obvious choice.

And if it does not seem obvious, then consider [1].

[1] https://lore.kernel.org/all/CAHk-%3Dwhigg3hvOy7c1j1MXFy6o6CHp0g4Tc3Y-MAk%2BXDssHU0A@mail.gmail.com/

Best regards,
Krzysztof

---
Krzysztof Kozlowski (3):
      irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM
      irqchip/qcom: Add defaults for desired arm64 drivers
      arm64: defconfig: Drop redundant Qualcomm irqchip entries

 arch/arm64/configs/defconfig | 2 --
 drivers/irqchip/Kconfig      | 6 ++++--
 2 files changed, 4 insertions(+), 4 deletions(-)
---
base-commit: 9eebf259d5352b87080d67758f483583d9e763d7
change-id: 20260727-irqchip-qcom-defaults-e4ad255d0553

Best regards,
--  
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/3] irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM
  2026-07-27 11:44 [PATCH 0/3] irqchip: qcom: Add sane defaults and drop defconfig Krzysztof Kozlowski
@ 2026-07-27 11:44 ` Krzysztof Kozlowski
  2026-07-27 12:00   ` Konrad Dybcio
  2026-07-27 12:31   ` Mukesh Ojha
  2026-07-27 11:44 ` [PATCH 2/3] irqchip/qcom: Add defaults for desired arm64 drivers Krzysztof Kozlowski
  2026-07-27 11:44 ` [PATCH 3/3] arm64: defconfig: Drop redundant Qualcomm irqchip entries Krzysztof Kozlowski
  2 siblings, 2 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-27 11:44 UTC (permalink / raw)
  To: Thomas Gleixner, Radu Rendec, Bjorn Andersson, Konrad Dybcio
  Cc: linux-kernel, linux-arm-msm, Krzysztof Kozlowski

QCOM_PDC and QCOM_MPM do not reference any architecture code, thus
should be compile-testable.  QCOM_MPM is used only on ARM64 SoCs, thus
there is no point in proposing this option for 32-bit Qualcomm platforms
making kernel configurators life easier.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/irqchip/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 20b77fbc51ee..954137395bff 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -522,7 +522,7 @@ config GOLDFISH_PIC
 
 config QCOM_PDC
 	tristate "Qualcomm PDC"
-	depends on ARCH_QCOM
+	depends on ARCH_QCOM || COMPILE_TEST
 	select IRQ_DOMAIN_HIERARCHY
 	help
 	  Power Domain Controller driver to manage and configure wakeup
@@ -530,7 +530,7 @@ config QCOM_PDC
 
 config QCOM_MPM
 	tristate "Qualcomm MPM"
-	depends on ARCH_QCOM
+	depends on (ARCH_QCOM && ARM64) || COMPILE_TEST
 	depends on MAILBOX
 	select IRQ_DOMAIN_HIERARCHY
 	help

-- 
2.53.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 2/3] irqchip/qcom: Add defaults for desired arm64 drivers
  2026-07-27 11:44 [PATCH 0/3] irqchip: qcom: Add sane defaults and drop defconfig Krzysztof Kozlowski
  2026-07-27 11:44 ` [PATCH 1/3] irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM Krzysztof Kozlowski
@ 2026-07-27 11:44 ` Krzysztof Kozlowski
  2026-07-27 11:44 ` [PATCH 3/3] arm64: defconfig: Drop redundant Qualcomm irqchip entries Krzysztof Kozlowski
  2 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-27 11:44 UTC (permalink / raw)
  To: Thomas Gleixner, Radu Rendec, Bjorn Andersson, Konrad Dybcio
  Cc: linux-kernel, linux-arm-msm, Krzysztof Kozlowski

QCOM_PDC and QCOM_MPM are essential for booting up SoCs and are not
really optional for a given platform.  Kernel should not ask users
choice of drivers when that choice is obvious and known to the
developers that answer should be 'yes' or 'module'.

Enable these by default whenever a kernel for Qualcomm SoC is built.
The change has no impact on arm64 defconfig, but will enable QCOM_PDC
for 32-bit ARM multi_v7_defconfig and qcom_defconfig, which is desired
because SDX55 uses it.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/irqchip/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 954137395bff..5427257c0230 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -524,6 +524,7 @@ config QCOM_PDC
 	tristate "Qualcomm PDC"
 	depends on ARCH_QCOM || COMPILE_TEST
 	select IRQ_DOMAIN_HIERARCHY
+	default ARCH_QCOM
 	help
 	  Power Domain Controller driver to manage and configure wakeup
 	  IRQs for Qualcomm Technologies Inc (QTI) mobile chips.
@@ -533,6 +534,7 @@ config QCOM_MPM
 	depends on (ARCH_QCOM && ARM64) || COMPILE_TEST
 	depends on MAILBOX
 	select IRQ_DOMAIN_HIERARCHY
+	default ARCH_QCOM
 	help
 	  MSM Power Manager driver to manage and configure wakeup
 	  IRQs for Qualcomm Technologies Inc (QTI) mobile chips.

-- 
2.53.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 3/3] arm64: defconfig: Drop redundant Qualcomm irqchip entries
  2026-07-27 11:44 [PATCH 0/3] irqchip: qcom: Add sane defaults and drop defconfig Krzysztof Kozlowski
  2026-07-27 11:44 ` [PATCH 1/3] irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM Krzysztof Kozlowski
  2026-07-27 11:44 ` [PATCH 2/3] irqchip/qcom: Add defaults for desired arm64 drivers Krzysztof Kozlowski
@ 2026-07-27 11:44 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-27 11:44 UTC (permalink / raw)
  To: Thomas Gleixner, Radu Rendec, Bjorn Andersson, Konrad Dybcio
  Cc: linux-kernel, linux-arm-msm, Krzysztof Kozlowski

QCOM_PDC and QCOM_MPM are enabled by default.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Depends on previous patch - this can wait a cycle and go via Qualcomm
SoC tree later.
---
 arch/arm64/configs/defconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 6ec8d3a69c98..978e00891dca 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1743,8 +1743,6 @@ CONFIG_PWM_VISCONTI=m
 CONFIG_PWM_XILINX=m
 CONFIG_SL28CPLD_INTC=y
 CONFIG_XILINX_INTC=y
-CONFIG_QCOM_PDC=y
-CONFIG_QCOM_MPM=y
 CONFIG_TI_SCI_INTR_IRQCHIP=y
 CONFIG_TI_SCI_INTA_IRQCHIP=y
 CONFIG_RESET_GPIO=m

-- 
2.53.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM
  2026-07-27 11:44 ` [PATCH 1/3] irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM Krzysztof Kozlowski
@ 2026-07-27 12:00   ` Konrad Dybcio
  2026-07-27 12:08     ` Krzysztof Kozlowski
  2026-07-27 12:31   ` Mukesh Ojha
  1 sibling, 1 reply; 8+ messages in thread
From: Konrad Dybcio @ 2026-07-27 12:00 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Thomas Gleixner, Radu Rendec,
	Bjorn Andersson, Konrad Dybcio
  Cc: linux-kernel, linux-arm-msm

On 7/27/26 1:44 PM, Krzysztof Kozlowski wrote:
> QCOM_PDC and QCOM_MPM do not reference any architecture code, thus
> should be compile-testable.  QCOM_MPM is used only on ARM64 SoCs, thus
> there is no point in proposing this option for 32-bit Qualcomm platforms
> making kernel configurators life easier.

This is only because no one wired it up, almost/all 32-bit SoCs
have one too

Konrad

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM
  2026-07-27 12:00   ` Konrad Dybcio
@ 2026-07-27 12:08     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-27 12:08 UTC (permalink / raw)
  To: Konrad Dybcio, Thomas Gleixner, Radu Rendec, Bjorn Andersson,
	Konrad Dybcio
  Cc: linux-kernel, linux-arm-msm

On 27/07/2026 14:00, Konrad Dybcio wrote:
> On 7/27/26 1:44 PM, Krzysztof Kozlowski wrote:
>> QCOM_PDC and QCOM_MPM do not reference any architecture code, thus
>> should be compile-testable.  QCOM_MPM is used only on ARM64 SoCs, thus
>> there is no point in proposing this option for 32-bit Qualcomm platforms
>> making kernel configurators life easier.
> 
> This is only because no one wired it up, almost/all 32-bit SoCs
> have one too

Ah, then I will not restrict it per arm64.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM
  2026-07-27 11:44 ` [PATCH 1/3] irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM Krzysztof Kozlowski
  2026-07-27 12:00   ` Konrad Dybcio
@ 2026-07-27 12:31   ` Mukesh Ojha
  2026-07-27 12:41     ` Krzysztof Kozlowski
  1 sibling, 1 reply; 8+ messages in thread
From: Mukesh Ojha @ 2026-07-27 12:31 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Thomas Gleixner, Radu Rendec, Bjorn Andersson, Konrad Dybcio,
	linux-kernel, linux-arm-msm

On Mon, Jul 27, 2026 at 01:44:43PM +0200, Krzysztof Kozlowski wrote:
> QCOM_PDC and QCOM_MPM do not reference any architecture code, thus
> should be compile-testable.  QCOM_MPM is used only on ARM64 SoCs, thus
> there is no point in proposing this option for 32-bit Qualcomm platforms
> making kernel configurators life easier.

QCOM_MPM is used on ARM32 bit targets, SoC like mdm9607

-- 
-Mukesh Ojha

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM
  2026-07-27 12:31   ` Mukesh Ojha
@ 2026-07-27 12:41     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-27 12:41 UTC (permalink / raw)
  To: Mukesh Ojha
  Cc: Thomas Gleixner, Radu Rendec, Bjorn Andersson, Konrad Dybcio,
	linux-kernel, linux-arm-msm

On 27/07/2026 14:31, Mukesh Ojha wrote:
> On Mon, Jul 27, 2026 at 01:44:43PM +0200, Krzysztof Kozlowski wrote:
>> QCOM_PDC and QCOM_MPM do not reference any architecture code, thus
>> should be compile-testable.  QCOM_MPM is used only on ARM64 SoCs, thus
>> there is no point in proposing this option for 32-bit Qualcomm platforms
>> making kernel configurators life easier.
> 
> QCOM_MPM is used on ARM32 bit targets, SoC like mdm9607

Ack

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-07-27 12:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-27 11:44 [PATCH 0/3] irqchip: qcom: Add sane defaults and drop defconfig Krzysztof Kozlowski
2026-07-27 11:44 ` [PATCH 1/3] irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM Krzysztof Kozlowski
2026-07-27 12:00   ` Konrad Dybcio
2026-07-27 12:08     ` Krzysztof Kozlowski
2026-07-27 12:31   ` Mukesh Ojha
2026-07-27 12:41     ` Krzysztof Kozlowski
2026-07-27 11:44 ` [PATCH 2/3] irqchip/qcom: Add defaults for desired arm64 drivers Krzysztof Kozlowski
2026-07-27 11:44 ` [PATCH 3/3] arm64: defconfig: Drop redundant Qualcomm irqchip entries Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®