From: Mario Limonciello <superm1@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/radeon: Only define radeon_acpi_vfct_match when actually used
Date: Thu, 16 Jul 2026 08:21:56 -0500 [thread overview]
Message-ID: <bd453dfb-c69f-44e5-80bb-f26f87135d9c@kernel.org> (raw)
In-Reply-To: <20260716123646.1933293-2-u.kleine-koenig@baylibre.com>
On 7/16/26 07:36, Uwe Kleine-König wrote:
> This fixes the build failure
>
> drivers/gpu/drm/radeon/radeon_bios.c:614:12: error: ‘radeon_acpi_vfct_match’ defined but not used [-Werror=unused-function]
> 614 | static int radeon_acpi_vfct_match(struct radeon_device *rdev,
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> for builds with CONFIG_ACPI unset.
>
> Fixes: 33a18ecd2fbf ("drm/radeon: Fix VFCT bus number matching with soft filter")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
> Hello,
>
> 33a18ecd2fbf is currently in next via
>
> https://gitlab.freedesktop.org/agd5f/linux.git drm-next
>
> .
>
> Best regards
> Uwe
>
> drivers/gpu/drm/radeon/radeon_bios.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
> index cc10880af096..cd7a5d458157 100644
> --- a/drivers/gpu/drm/radeon/radeon_bios.c
> +++ b/drivers/gpu/drm/radeon/radeon_bios.c
> @@ -596,6 +596,7 @@ static bool radeon_read_disabled_bios(struct radeon_device *rdev)
> return legacy_read_disabled_bios(rdev);
> }
>
> +#ifdef CONFIG_ACPI
> /**
> * radeon_acpi_vfct_match() - Check if a VFCT entry matches the device
> * @rdev: Radeon device
> @@ -635,7 +636,6 @@ static int radeon_acpi_vfct_match(struct radeon_device *rdev,
> return 0;
> }
>
> -#ifdef CONFIG_ACPI
> static bool radeon_acpi_vfct_bios(struct radeon_device *rdev)
> {
> struct acpi_table_header *hdr;
>
> base-commit: 33a18ecd2fbf6bcbf803836e94eb31c26f4c7f41
next prev parent reply other threads:[~2026-07-16 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 12:36 Uwe Kleine-König
2026-07-16 13:21 ` Mario Limonciello [this message]
2026-07-16 13:31 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd453dfb-c69f-44e5-80bb-f26f87135d9c@kernel.org \
--to=superm1@kernel.org \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®