* [PATCH] drm/radeon: Only define radeon_acpi_vfct_match when actually used
@ 2026-07-16 12:36 Uwe Kleine-König
2026-07-16 13:21 ` Mario Limonciello
2026-07-16 13:31 ` Alex Deucher
0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2026-07-16 12:36 UTC (permalink / raw)
To: Alex Deucher, Christian König
Cc: David Airlie, Simona Vetter, Mario Limonciello, amd-gfx,
dri-devel, linux-kernel
This fixes the build failure
drivers/gpu/drm/radeon/radeon_bios.c:614:12: error: ‘radeon_acpi_vfct_match’ defined but not used [-Werror=unused-function]
614 | static int radeon_acpi_vfct_match(struct radeon_device *rdev,
| ^~~~~~~~~~~~~~~~~~~~~~
for builds with CONFIG_ACPI unset.
Fixes: 33a18ecd2fbf ("drm/radeon: Fix VFCT bus number matching with soft filter")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
Hello,
33a18ecd2fbf is currently in next via
https://gitlab.freedesktop.org/agd5f/linux.git drm-next
.
Best regards
Uwe
drivers/gpu/drm/radeon/radeon_bios.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
index cc10880af096..cd7a5d458157 100644
--- a/drivers/gpu/drm/radeon/radeon_bios.c
+++ b/drivers/gpu/drm/radeon/radeon_bios.c
@@ -596,6 +596,7 @@ static bool radeon_read_disabled_bios(struct radeon_device *rdev)
return legacy_read_disabled_bios(rdev);
}
+#ifdef CONFIG_ACPI
/**
* radeon_acpi_vfct_match() - Check if a VFCT entry matches the device
* @rdev: Radeon device
@@ -635,7 +636,6 @@ static int radeon_acpi_vfct_match(struct radeon_device *rdev,
return 0;
}
-#ifdef CONFIG_ACPI
static bool radeon_acpi_vfct_bios(struct radeon_device *rdev)
{
struct acpi_table_header *hdr;
base-commit: 33a18ecd2fbf6bcbf803836e94eb31c26f4c7f41
--
2.55.0.11.g153666a7d9bb
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/radeon: Only define radeon_acpi_vfct_match when actually used
2026-07-16 12:36 [PATCH] drm/radeon: Only define radeon_acpi_vfct_match when actually used Uwe Kleine-König
@ 2026-07-16 13:21 ` Mario Limonciello
2026-07-16 13:31 ` Alex Deucher
1 sibling, 0 replies; 3+ messages in thread
From: Mario Limonciello @ 2026-07-16 13:21 UTC (permalink / raw)
To: Uwe Kleine-König, Alex Deucher, Christian König
Cc: David Airlie, Simona Vetter, amd-gfx, dri-devel, linux-kernel
On 7/16/26 07:36, Uwe Kleine-König wrote:
> This fixes the build failure
>
> drivers/gpu/drm/radeon/radeon_bios.c:614:12: error: ‘radeon_acpi_vfct_match’ defined but not used [-Werror=unused-function]
> 614 | static int radeon_acpi_vfct_match(struct radeon_device *rdev,
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> for builds with CONFIG_ACPI unset.
>
> Fixes: 33a18ecd2fbf ("drm/radeon: Fix VFCT bus number matching with soft filter")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
> Hello,
>
> 33a18ecd2fbf is currently in next via
>
> https://gitlab.freedesktop.org/agd5f/linux.git drm-next
>
> .
>
> Best regards
> Uwe
>
> drivers/gpu/drm/radeon/radeon_bios.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
> index cc10880af096..cd7a5d458157 100644
> --- a/drivers/gpu/drm/radeon/radeon_bios.c
> +++ b/drivers/gpu/drm/radeon/radeon_bios.c
> @@ -596,6 +596,7 @@ static bool radeon_read_disabled_bios(struct radeon_device *rdev)
> return legacy_read_disabled_bios(rdev);
> }
>
> +#ifdef CONFIG_ACPI
> /**
> * radeon_acpi_vfct_match() - Check if a VFCT entry matches the device
> * @rdev: Radeon device
> @@ -635,7 +636,6 @@ static int radeon_acpi_vfct_match(struct radeon_device *rdev,
> return 0;
> }
>
> -#ifdef CONFIG_ACPI
> static bool radeon_acpi_vfct_bios(struct radeon_device *rdev)
> {
> struct acpi_table_header *hdr;
>
> base-commit: 33a18ecd2fbf6bcbf803836e94eb31c26f4c7f41
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/radeon: Only define radeon_acpi_vfct_match when actually used
2026-07-16 12:36 [PATCH] drm/radeon: Only define radeon_acpi_vfct_match when actually used Uwe Kleine-König
2026-07-16 13:21 ` Mario Limonciello
@ 2026-07-16 13:31 ` Alex Deucher
1 sibling, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2026-07-16 13:31 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Alex Deucher, Christian König, David Airlie, Simona Vetter,
Mario Limonciello, amd-gfx, dri-devel, linux-kernel
Applied. Thanks!
On Thu, Jul 16, 2026 at 9:04 AM Uwe Kleine-König
<u.kleine-koenig@baylibre.com> wrote:
>
> This fixes the build failure
>
> drivers/gpu/drm/radeon/radeon_bios.c:614:12: error: ‘radeon_acpi_vfct_match’ defined but not used [-Werror=unused-function]
> 614 | static int radeon_acpi_vfct_match(struct radeon_device *rdev,
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> for builds with CONFIG_ACPI unset.
>
> Fixes: 33a18ecd2fbf ("drm/radeon: Fix VFCT bus number matching with soft filter")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Hello,
>
> 33a18ecd2fbf is currently in next via
>
> https://gitlab.freedesktop.org/agd5f/linux.git drm-next
>
> .
>
> Best regards
> Uwe
>
> drivers/gpu/drm/radeon/radeon_bios.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
> index cc10880af096..cd7a5d458157 100644
> --- a/drivers/gpu/drm/radeon/radeon_bios.c
> +++ b/drivers/gpu/drm/radeon/radeon_bios.c
> @@ -596,6 +596,7 @@ static bool radeon_read_disabled_bios(struct radeon_device *rdev)
> return legacy_read_disabled_bios(rdev);
> }
>
> +#ifdef CONFIG_ACPI
> /**
> * radeon_acpi_vfct_match() - Check if a VFCT entry matches the device
> * @rdev: Radeon device
> @@ -635,7 +636,6 @@ static int radeon_acpi_vfct_match(struct radeon_device *rdev,
> return 0;
> }
>
> -#ifdef CONFIG_ACPI
> static bool radeon_acpi_vfct_bios(struct radeon_device *rdev)
> {
> struct acpi_table_header *hdr;
>
> base-commit: 33a18ecd2fbf6bcbf803836e94eb31c26f4c7f41
> --
> 2.55.0.11.g153666a7d9bb
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-16 13:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-16 12:36 [PATCH] drm/radeon: Only define radeon_acpi_vfct_match when actually used Uwe Kleine-König
2026-07-16 13:21 ` Mario Limonciello
2026-07-16 13:31 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®