[PATCH 1/1] firmware: stratix10-svc: add missing comment for fcs client

[PATCH 1/1] firmware: stratix10-svc: add missing comment for fcs client

[Khairul Anuar Romli]

Add the missing comment describing the fcs client as "fpga crypto services"
in the SVC client list. This keeps the documentation consistent with other
clients (fpga, rsu, hwmon) and improves readibility and mantainability.

Signed-off-by: Khairul Anuar Romli <karom.9560@gmail.com>
---
 include/linux/firmware/intel/stratix10-svc-client.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h
index d290060f4c73..74adf34d6142 100644
--- a/include/linux/firmware/intel/stratix10-svc-client.h
+++ b/include/linux/firmware/intel/stratix10-svc-client.h
@@ -12,6 +12,7 @@
  *
  * fpga: for FPGA configuration
  * rsu: for remote status update
+ * fcs: for fpga crypto services
  * hwmon: for hardware monitoring (voltage and temperature)
  */
 #define SVC_CLIENT_FPGA			"fpga"
-- 
2.43.0

Re: [PATCH 1/1] firmware: stratix10-svc: add missing comment for fcs client

[Dinh Nguyen]

Hi Khairul,

On 3/14/26 22:18, Khairul Anuar Romli wrote:
> Add the missing comment describing the fcs client as "fpga crypto services"
> in the SVC client list. This keeps the documentation consistent with other
> clients (fpga, rsu, hwmon) and improves readibility and mantainability.
> 
> Signed-off-by: Khairul Anuar Romli <karom.9560@gmail.com>
> ---
>   include/linux/firmware/intel/stratix10-svc-client.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h
> index d290060f4c73..74adf34d6142 100644
> --- a/include/linux/firmware/intel/stratix10-svc-client.h
> +++ b/include/linux/firmware/intel/stratix10-svc-client.h
> @@ -12,6 +12,7 @@
>    *
>    * fpga: for FPGA configuration
>    * rsu: for remote status update
> + * fcs: for fpga crypto services


Thanks for your patch, but for now there is no fcs in the driver yet. In 
order to minimize churn, we'll add this when there is an fcs driver.

Dinh

Re: [PATCH 1/1] firmware: stratix10-svc: add missing comment for fcs client

[Khairul Anuar Romli]

On 16/3/2026 8:13 pm, Dinh Nguyen wrote:
> Hi Khairul,
> 
> On 3/14/26 22:18, Khairul Anuar Romli wrote:
>> Add the missing comment describing the fcs client as "fpga crypto 
>> services"
>> in the SVC client list. This keeps the documentation consistent with 
>> other
>> clients (fpga, rsu, hwmon) and improves readibility and mantainability.
>>
>> Signed-off-by: Khairul Anuar Romli <karom.9560@gmail.com>
>> ---
>>   include/linux/firmware/intel/stratix10-svc-client.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/ 
>> include/linux/firmware/intel/stratix10-svc-client.h
>> index d290060f4c73..74adf34d6142 100644
>> --- a/include/linux/firmware/intel/stratix10-svc-client.h
>> +++ b/include/linux/firmware/intel/stratix10-svc-client.h
>> @@ -12,6 +12,7 @@
>>    *
>>    * fpga: for FPGA configuration
>>    * rsu: for remote status update
>> + * fcs: for fpga crypto services
> 
> 
> Thanks for your patch, but for now there is no fcs in the driver yet. In 
> order to minimize churn, we'll add this when there is an fcs driver.
> 
> Dinh
> 

Noted. Thanks for letting me know.

Best Regards,
Khairul