* [PATCH v2] scsi: sd: retry command SYNC CACHE if format in progress
@ 2024-08-10 1:59 Yihang Li
2024-08-12 21:24 ` Bart Van Assche
0 siblings, 1 reply; 3+ messages in thread
From: Yihang Li @ 2024-08-10 1:59 UTC (permalink / raw)
To: James.Bottomley, martin.petersen
Cc: linux-scsi, linux-kernel, liyihang9, linuxarm, prime.zeng
If formatting a suspended disk (such as formatting with different DIF
type), the disk will be resuming first, and then the format command will
submit to the disk through SG_IO ioctl.
When the disk is processing the format command, the system does not submit
other commands to the disk. Therefore, the system attempts to suspend the
disk again and sends the SYNC CACHE command. However, the SYNC CACHE
command will fail because the disk is in the formatting process, which
will cause the runtime_status of the disk to error and it is difficult
for user to recover it. Error info like:
[ 669.925325] sd 6:0:6:0: [sdg] Synchronizing SCSI cache
[ 670.202371] sd 6:0:6:0: [sdg] Synchronize Cache(10) failed: Result: hostbyte=0x00 driverbyte=DRIVER_OK
[ 670.216300] sd 6:0:6:0: [sdg] Sense Key : 0x2 [current]
[ 670.221860] sd 6:0:6:0: [sdg] ASC=0x4 ASCQ=0x4
To solve the issue, retry the command until format command is finished.
Signed-off-by: Yihang Li <liyihang9@huawei.com>
---
Changes since v1:
- Updated and added error information to the patch description.
---
drivers/scsi/sd.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index adeaa8ab9951..5cd88a8eea73 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1823,6 +1823,11 @@ static int sd_sync_cache(struct scsi_disk *sdkp)
(sshdr.asc == 0x74 && sshdr.ascq == 0x71)) /* drive is password locked */
/* this is no error here */
return 0;
+
+ /* retry if format in progress */
+ if (sshdr.asc == 0x4 && sshdr.ascq == 0x4)
+ return -EBUSY;
+
/*
* This drive doesn't support sync and there's not much
* we can do because this is called during shutdown
--
2.33.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] scsi: sd: retry command SYNC CACHE if format in progress
2024-08-10 1:59 [PATCH v2] scsi: sd: retry command SYNC CACHE if format in progress Yihang Li
@ 2024-08-12 21:24 ` Bart Van Assche
2024-08-13 1:14 ` Yihang Li
0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2024-08-12 21:24 UTC (permalink / raw)
To: Yihang Li, James.Bottomley, martin.petersen
Cc: linux-scsi, linux-kernel, linuxarm, prime.zeng
On 8/9/24 6:59 PM, Yihang Li wrote:
> If formatting a suspended disk (such as formatting with different DIF
> type), the disk will be resuming first, and then the format command will
> submit to the disk through SG_IO ioctl.
>
> When the disk is processing the format command, the system does not submit
> other commands to the disk. Therefore, the system attempts to suspend the
> disk again and sends the SYNC CACHE command. However, the SYNC CACHE
> command will fail because the disk is in the formatting process, which
> will cause the runtime_status of the disk to error and it is difficult
> for user to recover it. Error info like:
>
> [ 669.925325] sd 6:0:6:0: [sdg] Synchronizing SCSI cache
> [ 670.202371] sd 6:0:6:0: [sdg] Synchronize Cache(10) failed: Result: hostbyte=0x00 driverbyte=DRIVER_OK
> [ 670.216300] sd 6:0:6:0: [sdg] Sense Key : 0x2 [current]
> [ 670.221860] sd 6:0:6:0: [sdg] ASC=0x4 ASCQ=0x4
>
> To solve the issue, retry the command until format command is finished.
>
> Signed-off-by: Yihang Li <liyihang9@huawei.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
If you want this patch to land in older kernels a "Cc: stable" tag will
have to be added.
Bart.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] scsi: sd: retry command SYNC CACHE if format in progress
2024-08-12 21:24 ` Bart Van Assche
@ 2024-08-13 1:14 ` Yihang Li
0 siblings, 0 replies; 3+ messages in thread
From: Yihang Li @ 2024-08-13 1:14 UTC (permalink / raw)
To: Bart Van Assche, James.Bottomley, martin.petersen
Cc: linux-scsi, linux-kernel, linuxarm, prime.zeng, liyihang9
On 2024/8/13 5:24, Bart Van Assche wrote:
> On 8/9/24 6:59 PM, Yihang Li wrote:
>> If formatting a suspended disk (such as formatting with different DIF
>> type), the disk will be resuming first, and then the format command will
>> submit to the disk through SG_IO ioctl.
>>
>> When the disk is processing the format command, the system does not submit
>> other commands to the disk. Therefore, the system attempts to suspend the
>> disk again and sends the SYNC CACHE command. However, the SYNC CACHE
>> command will fail because the disk is in the formatting process, which
>> will cause the runtime_status of the disk to error and it is difficult
>> for user to recover it. Error info like:
>>
>> [ 669.925325] sd 6:0:6:0: [sdg] Synchronizing SCSI cache
>> [ 670.202371] sd 6:0:6:0: [sdg] Synchronize Cache(10) failed: Result: hostbyte=0x00 driverbyte=DRIVER_OK
>> [ 670.216300] sd 6:0:6:0: [sdg] Sense Key : 0x2 [current]
>> [ 670.221860] sd 6:0:6:0: [sdg] ASC=0x4 ASCQ=0x4
>>
>> To solve the issue, retry the command until format command is finished.
>>
>> Signed-off-by: Yihang Li <liyihang9@huawei.com>
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
>
> If you want this patch to land in older kernels a "Cc: stable" tag will
> have to be added.
>
ok, I will add this tag in patch v3.
Thanks,
Yihang.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-13 1:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-10 1:59 [PATCH v2] scsi: sd: retry command SYNC CACHE if format in progress Yihang Li
2024-08-12 21:24 ` Bart Van Assche
2024-08-13 1:14 ` Yihang Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®