mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lizhi Hou <lizhi.hou@amd.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
	Brian Xu <brian.xu@amd.com>,
	Raj Kumar Rampelli <raj.kumar.rampelli@amd.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	Michal Simek <michal.simek@amd.com>,
	Sonal Santan <sonal.santan@amd.com>, Max Zhen <max.zhen@amd.com>
Cc: <dmaengine@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] dmaengine: xilinx: xdma: Fix regmap's max_register
Date: Wed, 24 Sep 2025 09:47:45 -0700	[thread overview]
Message-ID: <bee82ccd-9cd6-295f-839d-b17228212bc4@amd.com> (raw)
In-Reply-To: <20250924125941.742020-1-alexander.stein@ew.tq-group.com>

There is a patch for this.

https://lore.kernel.org/dmaengine/20250903-xdma-max-reg-v4-1-894721175025@amarulasolutions.com/


Thanks,
Lizhi
On 9/24/25 05:59, Alexander Stein wrote:
> max_register specifies the last valid register address. As the BAR is only
> 64kiB in size, 65536 aka 0x10000 is too big. Restrict the XDMA register
> space to be actually 64kiB.
>
> Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>   drivers/dma/xilinx/xdma-regs.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xdma-regs.h b/drivers/dma/xilinx/xdma-regs.h
> index 6ad08878e9386..c6ef198ef7627 100644
> --- a/drivers/dma/xilinx/xdma-regs.h
> +++ b/drivers/dma/xilinx/xdma-regs.h
> @@ -8,7 +8,7 @@
>   #define __DMA_XDMA_REGS_H
>   
>   /* The length of register space exposed to host */
> -#define XDMA_REG_SPACE_LEN	65536
> +#define XDMA_REG_SPACE_LEN	0xffff
>   
>   /*
>    * maximum number of DMA channels for each direction:

      reply	other threads:[~2025-09-24 16:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24 12:59 Alexander Stein
2025-09-24 16:47 ` Lizhi Hou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bee82ccd-9cd6-295f-839d-b17228212bc4@amd.com \
    --to=lizhi.hou@amd.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=brian.xu@amd.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max.zhen@amd.com \
    --cc=michal.simek@amd.com \
    --cc=raj.kumar.rampelli@amd.com \
    --cc=sonal.santan@amd.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®