* [PATCH 1/1] dmaengine: xilinx: xdma: Fix regmap's max_register
@ 2025-09-24 12:59 Alexander Stein
2025-09-24 16:47 ` Lizhi Hou
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Stein @ 2025-09-24 12:59 UTC (permalink / raw)
To: Lizhi Hou, Brian Xu, Raj Kumar Rampelli, Vinod Koul,
Michal Simek, Sonal Santan, Max Zhen
Cc: Alexander Stein, dmaengine, linux-arm-kernel, linux-kernel
max_register specifies the last valid register address. As the BAR is only
64kiB in size, 65536 aka 0x10000 is too big. Restrict the XDMA register
space to be actually 64kiB.
Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/dma/xilinx/xdma-regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/xilinx/xdma-regs.h b/drivers/dma/xilinx/xdma-regs.h
index 6ad08878e9386..c6ef198ef7627 100644
--- a/drivers/dma/xilinx/xdma-regs.h
+++ b/drivers/dma/xilinx/xdma-regs.h
@@ -8,7 +8,7 @@
#define __DMA_XDMA_REGS_H
/* The length of register space exposed to host */
-#define XDMA_REG_SPACE_LEN 65536
+#define XDMA_REG_SPACE_LEN 0xffff
/*
* maximum number of DMA channels for each direction:
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] dmaengine: xilinx: xdma: Fix regmap's max_register
2025-09-24 12:59 [PATCH 1/1] dmaengine: xilinx: xdma: Fix regmap's max_register Alexander Stein
@ 2025-09-24 16:47 ` Lizhi Hou
0 siblings, 0 replies; 2+ messages in thread
From: Lizhi Hou @ 2025-09-24 16:47 UTC (permalink / raw)
To: Alexander Stein, Brian Xu, Raj Kumar Rampelli, Vinod Koul,
Michal Simek, Sonal Santan, Max Zhen
Cc: dmaengine, linux-arm-kernel, linux-kernel
There is a patch for this.
https://lore.kernel.org/dmaengine/20250903-xdma-max-reg-v4-1-894721175025@amarulasolutions.com/
Thanks,
Lizhi
On 9/24/25 05:59, Alexander Stein wrote:
> max_register specifies the last valid register address. As the BAR is only
> 64kiB in size, 65536 aka 0x10000 is too big. Restrict the XDMA register
> space to be actually 64kiB.
>
> Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/dma/xilinx/xdma-regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xdma-regs.h b/drivers/dma/xilinx/xdma-regs.h
> index 6ad08878e9386..c6ef198ef7627 100644
> --- a/drivers/dma/xilinx/xdma-regs.h
> +++ b/drivers/dma/xilinx/xdma-regs.h
> @@ -8,7 +8,7 @@
> #define __DMA_XDMA_REGS_H
>
> /* The length of register space exposed to host */
> -#define XDMA_REG_SPACE_LEN 65536
> +#define XDMA_REG_SPACE_LEN 0xffff
>
> /*
> * maximum number of DMA channels for each direction:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-24 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-24 12:59 [PATCH 1/1] dmaengine: xilinx: xdma: Fix regmap's max_register Alexander Stein
2025-09-24 16:47 ` Lizhi Hou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®