[PATCH wireless-next v2 0/3] Use functionality of

[PATCH wireless-next v2 0/3] Use functionality of

[Vasileios Amoiridis]

Changes in v2:
	- Split the patches into subsystems
	- Use DEFINE_* helper to define the resource

---
v1: https://lore.kernel.org/netdev/20240902225534.130383-1-vassilisamir@gmail.com/

Vasileios Amoiridis (3):
  wifi: brcmfmac: of: Make use of irq_get_trigger_type()
  wifi: wlcore: sdio: Make use of irq_get_trigger_type()
  wifi: wlcore: sdio: Use helper to define resources

 .../net/wireless/broadcom/brcm80211/brcmfmac/of.c   |  2 +-
 drivers/net/wireless/ti/wlcore/sdio.c               | 13 ++++---------
 2 files changed, 5 insertions(+), 10 deletions(-)


base-commit: 97b766f989bcd06e5a7651b1080001d7327012f5
-- 
2.25.1

[PATCH wireless-next v2 1/3] wifi: brcmfmac: of: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type().

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
index fe4f65756105..e2611f164fa8 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
@@ -138,7 +138,7 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
 		brcmf_err("interrupt could not be mapped\n");
 		return;
 	}
-	irqf = irqd_get_trigger_type(irq_get_irq_data(irq));
+	irqf = irq_get_trigger_type(irq);
 
 	sdio->oob_irq_supported = true;
 	sdio->oob_irq_nr = irq;
-- 
2.25.1

Re: [PATCH wireless-next v2 1/3] wifi: brcmfmac: of: Make use of irq_get_trigger_type()

[Kalle Valo]

Vasileios Amoiridis <vassilisamir@gmail.com> wrote:

> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type().
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>

3 patches applied to wireless-next.git, thanks.

50282c028316 wifi: brcmfmac: of: Make use of irq_get_trigger_type()
18ae128c1ddc wifi: wlcore: sdio: Make use of irq_get_trigger_type()
a3ede2b0e65a wifi: wlcore: sdio: Use helper to define resources

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240904154919.118513-2-vassilisamir@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

[PATCH wireless-next v2 2/3] wifi: wlcore: sdio: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/net/wireless/ti/wlcore/sdio.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
index 92fb5b8dcdae..9e1b644beba9 100644
--- a/drivers/net/wireless/ti/wlcore/sdio.c
+++ b/drivers/net/wireless/ti/wlcore/sdio.c
@@ -324,15 +324,13 @@ static int wl1271_probe(struct sdio_func *func,
 	memset(res, 0x00, sizeof(res));
 
 	res[0].start = irq;
-	res[0].flags = IORESOURCE_IRQ |
-		       irqd_get_trigger_type(irq_get_irq_data(irq));
+	res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
 	res[0].name = "irq";
 
 
 	if (wakeirq > 0) {
 		res[1].start = wakeirq;
-		res[1].flags = IORESOURCE_IRQ |
-			       irqd_get_trigger_type(irq_get_irq_data(wakeirq));
+		res[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(wakeirq);
 		res[1].name = "wakeirq";
 		num_irqs = 2;
 	} else {
-- 
2.25.1

Re: [PATCH wireless-next v2 2/3] wifi: wlcore: sdio: Make use of irq_get_trigger_type()

[Khan, Sabeeh]

Hi Vasileios,

On 9/4/2024 7:49 PM, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
>  drivers/net/wireless/ti/wlcore/sdio.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
> index 92fb5b8dcdae..9e1b644beba9 100644
> --- a/drivers/net/wireless/ti/wlcore/sdio.c
> +++ b/drivers/net/wireless/ti/wlcore/sdio.c
> @@ -324,15 +324,13 @@ static int wl1271_probe(struct sdio_func *func,
>  	memset(res, 0x00, sizeof(res));
>  
>  	res[0].start = irq;
> -	res[0].flags = IORESOURCE_IRQ |
> -		       irqd_get_trigger_type(irq_get_irq_data(irq));
> +	res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
>  	res[0].name = "irq";
>  
>  
>  	if (wakeirq > 0) {
>  		res[1].start = wakeirq;
> -		res[1].flags = IORESOURCE_IRQ |
> -			       irqd_get_trigger_type(irq_get_irq_data(wakeirq));
> +		res[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(wakeirq);
>  		res[1].name = "wakeirq";
>  		num_irqs = 2;
>  	} else {
Reviewed-by: Sabeeh Khan <sabeeh-khan@ti.com>
Tested-by: Sabeeh Khan <sabeeh-khan@ti.com>

[PATCH wireless-next v2 3/3] wifi: wlcore: sdio: Use helper to define resources

[Vasileios Amoiridis]

Resources definition can become simpler and more organised by
using the dedicated helpers.

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/net/wireless/ti/wlcore/sdio.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
index 9e1b644beba9..a73207bbe5d7 100644
--- a/drivers/net/wireless/ti/wlcore/sdio.c
+++ b/drivers/net/wireless/ti/wlcore/sdio.c
@@ -323,15 +323,12 @@ static int wl1271_probe(struct sdio_func *func,
 
 	memset(res, 0x00, sizeof(res));
 
-	res[0].start = irq;
-	res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
-	res[0].name = "irq";
-
+	res[0] = DEFINE_RES_IRQ_NAMED(irq, "irq");
+	res[0].flags |= irq_get_trigger_type(irq);
 
 	if (wakeirq > 0) {
-		res[1].start = wakeirq;
-		res[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(wakeirq);
-		res[1].name = "wakeirq";
+		res[1] = DEFINE_RES_IRQ_NAMED(wakeirq, "wakeirq");
+		res[1].flags |= irq_get_trigger_type(wakeirq);
 		num_irqs = 2;
 	} else {
 		num_irqs = 1;
-- 
2.25.1

Re: [PATCH wireless-next v2 3/3] wifi: wlcore: sdio: Use helper to define resources

[Khan, Sabeeh]

Hi Vasileios,

On 9/4/2024 7:49 PM, Vasileios Amoiridis wrote:
> Resources definition can become simpler and more organised by
> using the dedicated helpers.
>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
>  drivers/net/wireless/ti/wlcore/sdio.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
> index 9e1b644beba9..a73207bbe5d7 100644
> --- a/drivers/net/wireless/ti/wlcore/sdio.c
> +++ b/drivers/net/wireless/ti/wlcore/sdio.c
> @@ -323,15 +323,12 @@ static int wl1271_probe(struct sdio_func *func,
>  
>  	memset(res, 0x00, sizeof(res));
>  
> -	res[0].start = irq;
> -	res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
> -	res[0].name = "irq";
> -
> +	res[0] = DEFINE_RES_IRQ_NAMED(irq, "irq");
> +	res[0].flags |= irq_get_trigger_type(irq);
>  
>  	if (wakeirq > 0) {
> -		res[1].start = wakeirq;
> -		res[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(wakeirq);
> -		res[1].name = "wakeirq";
> +		res[1] = DEFINE_RES_IRQ_NAMED(wakeirq, "wakeirq");
> +		res[1].flags |= irq_get_trigger_type(wakeirq);
>  		num_irqs = 2;
>  	} else {
>  		num_irqs = 1;

Tested-by: Sabeeh Khan <sabeeh-khan@ti.com>
Reviewed-by: Sabeeh Khan <sabeeh-khan@ti.com>

Re: [PATCH wireless-next v2 3/3] wifi: wlcore: sdio: Use helper to define resources

[Vasileios Amoiridis]

On Mon, Sep 09, 2024 at 01:38:58PM +0400, Khan, Sabeeh wrote:
> Hi Vasileios,
> 
> On 9/4/2024 7:49 PM, Vasileios Amoiridis wrote:
> > Resources definition can become simpler and more organised by
> > using the dedicated helpers.
> >
> > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> > ---
> >  drivers/net/wireless/ti/wlcore/sdio.c | 11 ++++-------
> >  1 file changed, 4 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
> > index 9e1b644beba9..a73207bbe5d7 100644
> > --- a/drivers/net/wireless/ti/wlcore/sdio.c
> > +++ b/drivers/net/wireless/ti/wlcore/sdio.c
> > @@ -323,15 +323,12 @@ static int wl1271_probe(struct sdio_func *func,
> >  
> >  	memset(res, 0x00, sizeof(res));
> >  
> > -	res[0].start = irq;
> > -	res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
> > -	res[0].name = "irq";
> > -
> > +	res[0] = DEFINE_RES_IRQ_NAMED(irq, "irq");
> > +	res[0].flags |= irq_get_trigger_type(irq);
> >  
> >  	if (wakeirq > 0) {
> > -		res[1].start = wakeirq;
> > -		res[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(wakeirq);
> > -		res[1].name = "wakeirq";
> > +		res[1] = DEFINE_RES_IRQ_NAMED(wakeirq, "wakeirq");
> > +		res[1].flags |= irq_get_trigger_type(wakeirq);
> >  		num_irqs = 2;
> >  	} else {
> >  		num_irqs = 1;
> 
> Tested-by: Sabeeh Khan <sabeeh-khan@ti.com>
> Reviewed-by: Sabeeh Khan <sabeeh-khan@ti.com>
> 

Hi Sabeeh,

Thank you very much!

Cheers,
Vasilis