* [PATCH] nvme: select tls config when tcp tls is enabled
@ 2025-04-29 22:40 Alistair Francis
2025-04-30 0:44 ` Chaitanya Kulkarni
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alistair Francis @ 2025-04-29 22:40 UTC (permalink / raw)
To: hch, sagi, kch, linux-nvme
Cc: linux-kernel, hare, alistair23, Alistair Francis
Ensure that TLS support is enabled in the kernel when
NVME_TCP_TLSS is enabled. This allows TLS secure channels to be
used out of the box.
Fixes: be8e82caa68 ("nvme-tcp: enable TLS handshake upcall")
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
drivers/nvme/host/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index d47dfa80fb95..4d64b6935bb9 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -102,6 +102,7 @@ config NVME_TCP_TLS
depends on NVME_TCP
select NET_HANDSHAKE
select KEYS
+ select TLS
help
Enables TLS encryption for NVMe TCP using the netlink handshake API.
--
2.49.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: select tls config when tcp tls is enabled
2025-04-29 22:40 [PATCH] nvme: select tls config when tcp tls is enabled Alistair Francis
@ 2025-04-30 0:44 ` Chaitanya Kulkarni
2025-04-30 0:45 ` Chaitanya Kulkarni
2025-04-30 6:12 ` Hannes Reinecke
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2025-04-30 0:44 UTC (permalink / raw)
To: Alistair Francis, hch, sagi, Chaitanya Kulkarni, linux-nvme
Cc: linux-kernel, hare, Alistair Francis
On 4/29/25 15:40, Alistair Francis wrote:
> Ensure that TLS support is enabled in the kernel when
> NVME_TCP_TLSS is enabled. This allows TLS secure channels to be
> used out of the box.
>
> Fixes: be8e82caa68 ("nvme-tcp: enable TLS handshake upcall")
> Signed-off-by: Alistair Francis<alistair.francis@wdc.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: select tls config when tcp tls is enabled
2025-04-29 22:40 [PATCH] nvme: select tls config when tcp tls is enabled Alistair Francis
2025-04-30 0:44 ` Chaitanya Kulkarni
@ 2025-04-30 0:45 ` Chaitanya Kulkarni
2025-04-30 6:12 ` Hannes Reinecke
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2025-04-30 0:45 UTC (permalink / raw)
To: Alistair Francis, hch, sagi, Chaitanya Kulkarni, linux-nvme
Cc: linux-kernel, hare, Alistair Francis
On 4/29/25 15:40, Alistair Francis wrote:
> Ensure that TLS support is enabled in the kernel when
> NVME_TCP_TLSS is enabled. This allows TLS secure channels to be
> used out of the box.
>
> Fixes: be8e82caa68 ("nvme-tcp: enable TLS handshake upcall")
> Signed-off-by: Alistair Francis<alistair.francis@wdc.com>
to keep it easy on the git log better we should merge this next to
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: select tls config when tcp tls is enabled
2025-04-29 22:40 [PATCH] nvme: select tls config when tcp tls is enabled Alistair Francis
2025-04-30 0:44 ` Chaitanya Kulkarni
2025-04-30 0:45 ` Chaitanya Kulkarni
@ 2025-04-30 6:12 ` Hannes Reinecke
2 siblings, 0 replies; 4+ messages in thread
From: Hannes Reinecke @ 2025-04-30 6:12 UTC (permalink / raw)
To: Alistair Francis, hch, sagi, kch, linux-nvme
Cc: linux-kernel, Alistair Francis
On 4/30/25 00:40, Alistair Francis wrote:
> Ensure that TLS support is enabled in the kernel when
> NVME_TCP_TLSS is enabled. This allows TLS secure channels to be
> used out of the box.
>
> Fixes: be8e82caa68 ("nvme-tcp: enable TLS handshake upcall")
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> drivers/nvme/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
> index d47dfa80fb95..4d64b6935bb9 100644
> --- a/drivers/nvme/host/Kconfig
> +++ b/drivers/nvme/host/Kconfig
> @@ -102,6 +102,7 @@ config NVME_TCP_TLS
> depends on NVME_TCP
> select NET_HANDSHAKE
> select KEYS
> + select TLS
> help
> Enables TLS encryption for NVMe TCP using the netlink handshake API.
>
I would have folded it into the previous patch.
Otherwise:
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-30 6:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-29 22:40 [PATCH] nvme: select tls config when tcp tls is enabled Alistair Francis
2025-04-30 0:44 ` Chaitanya Kulkarni
2025-04-30 0:45 ` Chaitanya Kulkarni
2025-04-30 6:12 ` Hannes Reinecke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®