mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xiongfeng Wang <wangxiongfeng2@huawei.com>
To: John Garry <john.garry@huawei.com>, Marc Zyngier <maz@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	David Decotigny <ddecotig@google.com>
Subject: Re: [PATCH v3 0/3] genirq: Managed affinity fixes
Date: Fri, 8 Apr 2022 09:02:17 +0800	[thread overview]
Message-ID: <c3f3a519-b81b-abe1-b6ea-599561478abf@huawei.com> (raw)
In-Reply-To: <b14b61cc-ab47-e90d-7f81-f05197645dc6@huawei.com>

Hi,

On 2022/4/8 1:29, John Garry wrote:
> On 05/04/2022 19:50, Marc Zyngier wrote:
>> John (and later on David) reported[1] a while ago that booting with
>> maxcpus=1, managed affinity devices would fail to get the interrupts
>> that were associated with offlined CPUs.
>>
>> Similarly, Xiongfeng reported[2] that the GICv3 ITS would sometime use
>> non-housekeeping CPUs instead of the affinity that was passed down as
>> a parameter.
>>
>> [1] can be fixed by not trying to activate these interrupts if no CPU
>> that can satisfy the affinity is present (a patch addressing this was
>> already posted[3])
>>
>> [2] is a consequence of affinities containing non-online CPUs being
>> passed down to the interrupt controller driver and the ITS driver
>> trying to paper over that by ignoring the affinity parameter and doing
>> its own (stupid) thing. It would be better to (a) get the core code to
>> remove the offline CPUs from the affinity mask at all times, and (b)
>> fix the drivers so that they can trust the core code not to trip them.
>>
>> This small series, based on 5.18-rc1, addresses the above.
> 
> Hi Marc,
> 
> Please let me know if you require anything more from me on this one. I was
> hoping that Xiongfeng would verify that his "housekeeping" issues were fixed.

I have tested the V2 version. It works well and fixed both issues, the
'maxcpus=1' issue and 'housekeeping' issue. Let me know if you need me test this
V3 version. I am not seeing much change, only context change.

Thanks,
Xiongfeng

> 
> Cheers
> 
>>
>> Thanks,
>>
>>     M.
>>
>>> From v2 [4]:
>>    - Rebased on 5.18-rc1
>>
>> [1] https://lore.kernel.org/r/78615d08-1764-c895-f3b7-bfddfbcbdfb9@huawei.com
>> [2] https://lore.kernel.org/r/20220124073440.88598-1-wangxiongfeng2@huawei.com
>> [3] https://lore.kernel.org/r/20220307190625.254426-1-maz@kernel.org
>> [4] https://lore.kernel.org/r/20220321193608.975495-1-maz@kernel.org
>>
>> Marc Zyngier (3):
>>    genirq/msi: Shutdown managed interrupts with unsatifiable affinities
>>    genirq: Always limit the affinity to online CPUs
>>    irqchip/gic-v3: Always trust the managed affinity provided by the core
>>      code
>>
>>   drivers/irqchip/irq-gic-v3-its.c |  2 +-
>>   kernel/irq/manage.c              | 25 +++++++++++++++++--------
>>   kernel/irq/msi.c                 | 15 +++++++++++++++
>>   3 files changed, 33 insertions(+), 9 deletions(-)
>>
> 
> .

      reply	other threads:[~2022-04-08  1:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05 18:50 Marc Zyngier
2022-04-05 18:50 ` [PATCH v3 1/3] genirq/msi: Shutdown managed interrupts with unsatifiable affinities Marc Zyngier
2022-04-10 19:13   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2022-04-05 18:50 ` [PATCH v3 2/3] genirq: Always limit the affinity to online CPUs Marc Zyngier
2022-04-10 19:12   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
     [not found]   ` <CGME20220413145922eucas1p2dc46908354f4d2b48db79978d086a838@eucas1p2.samsung.com>
2022-04-13 14:59     ` [PATCH v3 2/3] " Marek Szyprowski
2022-04-13 17:26       ` Marc Zyngier
2022-04-14  9:09         ` Marek Szyprowski
2022-04-14 10:35           ` Marc Zyngier
2022-04-14 11:08             ` Marek Szyprowski
2022-04-20  9:13               ` Krzysztof Kozlowski
2022-04-20  9:40                 ` Marc Zyngier
2022-04-20  9:42                   ` Krzysztof Kozlowski
2022-04-20  9:47                 ` Marek Szyprowski
2022-04-20  9:50                   ` Krzysztof Kozlowski
2022-04-14 10:49         ` Thomas Gleixner
2022-04-14 14:14       ` [tip: irq/core] genirq: Take the proposed affinity at face value if force==true tip-bot2 for Marc Zyngier
2022-04-05 18:50 ` [PATCH v3 3/3] irqchip/gic-v3: Always trust the managed affinity provided by the core code Marc Zyngier
2022-04-10 19:12   ` [tip: irq/core] " tip-bot2 for Marc Zyngier
2022-04-07 17:29 ` [PATCH v3 0/3] genirq: Managed affinity fixes John Garry
2022-04-08  1:02   ` Xiongfeng Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3f3a519-b81b-abe1-b6ea-599561478abf@huawei.com \
    --to=wangxiongfeng2@huawei.com \
    --cc=ddecotig@google.com \
    --cc=john.garry@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®