mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/7] Staging: rtl8192e: Rename bool variables
@ 2023-11-13 19:59 Tree Davies
  2023-11-13 19:59 ` [PATCH 1/7] Staging: rtl8192e: Rename variable bSendDELBA Tree Davies
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Tree Davies @ 2023-11-13 19:59 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

This series renames bool variables to fix checkpatch warnings
Thank you in advance to reviewers
regards,
~Tree

Tree Davies (7):
  Staging: rtl8192e: Rename variable bSendDELBA
  Staging: rtl8192e: Rename variable bCurrentAMPDUEnable
  Staging: rtl8192e: Rename variable bAddBaReqInProgress
  Staging: rtl8192e: Rename variable bAddBaReqDelayed
  Staging: rtl8192e: Rename variable bUsingBa
  Staging: rtl8192e: Rename variable bOverwritePending
  Staging: rtl8192e: Rename variable bDisable_AddBa

 drivers/staging/rtl8192e/rtl819x_BAProc.c | 40 +++++++++++------------
 drivers/staging/rtl8192e/rtl819x_HT.h     |  2 +-
 drivers/staging/rtl8192e/rtl819x_HTProc.c |  6 ++--
 drivers/staging/rtl8192e/rtl819x_TS.h     |  8 ++---
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 14 ++++----
 drivers/staging/rtl8192e/rtllib.h         |  2 +-
 drivers/staging/rtl8192e/rtllib_tx.c      |  8 ++---
 7 files changed, 40 insertions(+), 40 deletions(-)

-- 
2.39.2


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/7] Staging: rtl8192e: Rename variable bSendDELBA
  2023-11-13 19:59 [PATCH 0/7] Staging: rtl8192e: Rename bool variables Tree Davies
@ 2023-11-13 19:59 ` Tree Davies
  2023-11-13 19:59 ` [PATCH 2/7] Staging: rtl8192e: Rename variable bCurrentAMPDUEnable Tree Davies
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Tree Davies @ 2023-11-13 19:59 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable bSendDELBA to send_del_ba to fix checkpatch warning
Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 4af8055d2489..c0058d2be6d1 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -27,31 +27,31 @@ static u8 tx_ts_delete_ba(struct rtllib_device *ieee, struct tx_ts_record *pTxTs
 {
 	struct ba_record *admitted_ba = &pTxTs->TxAdmittedBARecord;
 	struct ba_record *pending_ba = &pTxTs->TxPendingBARecord;
-	u8 bSendDELBA = false;
+	u8 send_del_ba = false;
 
 	if (pending_ba->b_valid) {
 		deactivate_ba_entry(ieee, pending_ba);
-		bSendDELBA = true;
+		send_del_ba = true;
 	}
 
 	if (admitted_ba->b_valid) {
 		deactivate_ba_entry(ieee, admitted_ba);
-		bSendDELBA = true;
+		send_del_ba = true;
 	}
-	return bSendDELBA;
+	return send_del_ba;
 }
 
 static u8 rx_ts_delete_ba(struct rtllib_device *ieee, struct rx_ts_record *ts)
 {
 	struct ba_record *ba = &ts->rx_admitted_ba_record;
-	u8			bSendDELBA = false;
+	u8			send_del_ba = false;
 
 	if (ba->b_valid) {
 		deactivate_ba_entry(ieee, ba);
-		bSendDELBA = true;
+		send_del_ba = true;
 	}
 
-	return bSendDELBA;
+	return send_del_ba;
 }
 
 void rtllib_reset_ba_entry(struct ba_record *ba)
-- 
2.39.2


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 2/7] Staging: rtl8192e: Rename variable bCurrentAMPDUEnable
  2023-11-13 19:59 [PATCH 0/7] Staging: rtl8192e: Rename bool variables Tree Davies
  2023-11-13 19:59 ` [PATCH 1/7] Staging: rtl8192e: Rename variable bSendDELBA Tree Davies
@ 2023-11-13 19:59 ` Tree Davies
  2023-11-13 19:59 ` [PATCH 3/7] Staging: rtl8192e: Rename variable bAddBaReqInProgress Tree Davies
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Tree Davies @ 2023-11-13 19:59 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable bCurrentAMPDUEnable to current_ampdu_enable to fix
checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++--
 drivers/staging/rtl8192e/rtl819x_HT.h     | 2 +-
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++---
 drivers/staging/rtl8192e/rtllib_tx.c      | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index c0058d2be6d1..404f873455fc 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -327,12 +327,12 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
 
 	if (!ieee->current_network.qos_data.active ||
 	    !ieee->ht_info->current_ht_support ||
-	    !ieee->ht_info->bCurrentAMPDUEnable) {
+	    !ieee->ht_info->current_ampdu_enable) {
 		netdev_warn(ieee->dev,
 			    "reject to ADDBA_RSP as some capability is not ready(%d, %d, %d)\n",
 			    ieee->current_network.qos_data.active,
 			    ieee->ht_info->current_ht_support,
-			    ieee->ht_info->bCurrentAMPDUEnable);
+			    ieee->ht_info->current_ampdu_enable);
 		reason_code = DELBA_REASON_UNKNOWN_BA;
 		goto OnADDBARsp_Reject;
 	}
diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
index f8eb4d553fe0..a4fe72943b36 100644
--- a/drivers/staging/rtl8192e/rtl819x_HT.h
+++ b/drivers/staging/rtl8192e/rtl819x_HT.h
@@ -112,7 +112,7 @@ struct rt_hi_throughput {
 	u8 bCurrent_AMSDU_Support;
 	u16 nCurrent_AMSDU_MaxSize;
 	u8 bAMPDUEnable;
-	u8 bCurrentAMPDUEnable;
+	u8 current_ampdu_enable;
 	u8 AMPDU_Factor;
 	u8 CurrentAMPDUFactor;
 	u8 MPDU_Density;
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index e607bccc079a..d5520cc82d22 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -514,12 +514,12 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
 	else
 		ht_info->nCurrent_AMSDU_MaxSize = ht_info->nAMSDU_MaxSize;
 
-	ht_info->bCurrentAMPDUEnable = ht_info->bAMPDUEnable;
+	ht_info->current_ampdu_enable = ht_info->bAMPDUEnable;
 	if (ieee->rtllib_ap_sec_type &&
 	    (ieee->rtllib_ap_sec_type(ieee) & (SEC_ALG_WEP | SEC_ALG_TKIP))) {
 		if ((ht_info->IOTPeer == HT_IOT_PEER_ATHEROS) ||
 		    (ht_info->IOTPeer == HT_IOT_PEER_UNKNOWN))
-			ht_info->bCurrentAMPDUEnable = false;
+			ht_info->current_ampdu_enable = false;
 	}
 
 	if (!ht_info->reg_rt2rt_aggregation) {
@@ -544,7 +544,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
 	ht_info->current_mpdu_density = max_t(u8, ht_info->MPDU_Density,
 					      pPeerHTCap->MPDUDensity);
 	if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K) {
-		ht_info->bCurrentAMPDUEnable = false;
+		ht_info->current_ampdu_enable = false;
 		ht_info->ForcedAMSDUMode = HT_AGG_FORCE_ENABLE;
 	}
 	ht_info->cur_rx_reorder_enable = ht_info->reg_rx_reorder_enable;
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index 9bf679438ad1..a99c3b3f867c 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -288,7 +288,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_device *ieee,
 
 	if (!ieee->GetNmodeSupportBySecCfg(ieee->dev))
 		return;
-	if (ht_info->bCurrentAMPDUEnable) {
+	if (ht_info->current_ampdu_enable) {
 		if (!rtllib_get_ts(ieee, (struct ts_common_info **)(&pTxTs), hdr->addr1,
 			   skb->priority, TX_DIR, true)) {
 			netdev_info(ieee->dev, "%s: can't get TS\n", __func__);
-- 
2.39.2


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 3/7] Staging: rtl8192e: Rename variable bAddBaReqInProgress
  2023-11-13 19:59 [PATCH 0/7] Staging: rtl8192e: Rename bool variables Tree Davies
  2023-11-13 19:59 ` [PATCH 1/7] Staging: rtl8192e: Rename variable bSendDELBA Tree Davies
  2023-11-13 19:59 ` [PATCH 2/7] Staging: rtl8192e: Rename variable bCurrentAMPDUEnable Tree Davies
@ 2023-11-13 19:59 ` Tree Davies
  2023-11-13 19:59 ` [PATCH 4/7] Staging: rtl8192e: Rename variable bAddBaReqDelayed Tree Davies
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Tree Davies @ 2023-11-13 19:59 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable bAddBaReqInProgress to add_ba_req_in_progress to fix
checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++---
 drivers/staging/rtl8192e/rtl819x_TS.h     | 2 +-
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 +++---
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 404f873455fc..4d51c745e7f2 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -344,7 +344,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
 		goto OnADDBARsp_Reject;
 	}
 
-	ts->bAddBaReqInProgress = false;
+	ts->add_ba_req_in_progress = false;
 	pending_ba = &ts->TxPendingBARecord;
 	pAdmittedBA = &ts->TxAdmittedBARecord;
 
@@ -453,7 +453,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
 		}
 
 		pTxTs->bUsingBa = false;
-		pTxTs->bAddBaReqInProgress = false;
+		pTxTs->add_ba_req_in_progress = false;
 		pTxTs->bAddBaReqDelayed = false;
 		del_timer_sync(&pTxTs->TsAddBaTimer);
 		tx_ts_delete_ba(ieee, pTxTs);
@@ -513,7 +513,7 @@ void rtllib_ba_setup_timeout(struct timer_list *t)
 	struct tx_ts_record *pTxTs = from_timer(pTxTs, t,
 					      TxPendingBARecord.timer);
 
-	pTxTs->bAddBaReqInProgress = false;
+	pTxTs->add_ba_req_in_progress = false;
 	pTxTs->bAddBaReqDelayed = true;
 	pTxTs->TxPendingBARecord.b_valid = false;
 }
diff --git a/drivers/staging/rtl8192e/rtl819x_TS.h b/drivers/staging/rtl8192e/rtl819x_TS.h
index fff36315f174..276a50f98781 100644
--- a/drivers/staging/rtl8192e/rtl819x_TS.h
+++ b/drivers/staging/rtl8192e/rtl819x_TS.h
@@ -27,7 +27,7 @@ struct tx_ts_record {
 	u16				TxCurSeq;
 	struct ba_record TxPendingBARecord;
 	struct ba_record TxAdmittedBARecord;
-	u8				bAddBaReqInProgress;
+	u8				add_ba_req_in_progress;
 	u8				bAddBaReqDelayed;
 	u8				bUsingBa;
 	u8				bDisable_AddBa;
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 3206fdb3e65a..62414e7b8879 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -101,7 +101,7 @@ static void ResetTxTsEntry(struct tx_ts_record *ts)
 {
 	ResetTsCommonInfo(&ts->TsCommonInfo);
 	ts->TxCurSeq = 0;
-	ts->bAddBaReqInProgress = false;
+	ts->add_ba_req_in_progress = false;
 	ts->bAddBaReqDelayed = false;
 	ts->bUsingBa = false;
 	ts->bDisable_AddBa = false;
@@ -433,8 +433,8 @@ void RemoveAllTS(struct rtllib_device *ieee)
 
 void TsStartAddBaProcess(struct rtllib_device *ieee, struct tx_ts_record *pTxTS)
 {
-	if (pTxTS->bAddBaReqInProgress == false) {
-		pTxTS->bAddBaReqInProgress = true;
+	if (pTxTS->add_ba_req_in_progress == false) {
+		pTxTS->add_ba_req_in_progress = true;
 
 		if (pTxTS->bAddBaReqDelayed) {
 			netdev_dbg(ieee->dev, "Start ADDBA after 60 sec!!\n");
-- 
2.39.2


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 4/7] Staging: rtl8192e: Rename variable bAddBaReqDelayed
  2023-11-13 19:59 [PATCH 0/7] Staging: rtl8192e: Rename bool variables Tree Davies
                   ` (2 preceding siblings ...)
  2023-11-13 19:59 ` [PATCH 3/7] Staging: rtl8192e: Rename variable bAddBaReqInProgress Tree Davies
@ 2023-11-13 19:59 ` Tree Davies
  2023-11-13 19:59 ` [PATCH 5/7] Staging: rtl8192e: Rename variable bUsingBa Tree Davies
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Tree Davies @ 2023-11-13 19:59 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable bAddBaReqDelayed to add_ba_req_delayed to fix
checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++----
 drivers/staging/rtl8192e/rtl819x_TS.h     | 2 +-
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 4d51c745e7f2..631c857c508f 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -368,7 +368,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
 
 	if (*status_code == ADDBA_STATUS_SUCCESS) {
 		if (pBaParamSet->field.ba_policy == BA_POLICY_DELAYED) {
-			ts->bAddBaReqDelayed = true;
+			ts->add_ba_req_delayed = true;
 			deactivate_ba_entry(ieee, pAdmittedBA);
 			reason_code = DELBA_REASON_END_BA;
 			goto OnADDBARsp_Reject;
@@ -381,7 +381,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
 		deactivate_ba_entry(ieee, pAdmittedBA);
 		activate_ba_entry(pAdmittedBA, *pBaTimeoutVal);
 	} else {
-		ts->bAddBaReqDelayed = true;
+		ts->add_ba_req_delayed = true;
 		ts->bDisable_AddBa = true;
 		reason_code = DELBA_REASON_END_BA;
 		goto OnADDBARsp_Reject;
@@ -454,7 +454,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
 
 		pTxTs->bUsingBa = false;
 		pTxTs->add_ba_req_in_progress = false;
-		pTxTs->bAddBaReqDelayed = false;
+		pTxTs->add_ba_req_delayed = false;
 		del_timer_sync(&pTxTs->TsAddBaTimer);
 		tx_ts_delete_ba(ieee, pTxTs);
 	}
@@ -514,7 +514,7 @@ void rtllib_ba_setup_timeout(struct timer_list *t)
 					      TxPendingBARecord.timer);
 
 	pTxTs->add_ba_req_in_progress = false;
-	pTxTs->bAddBaReqDelayed = true;
+	pTxTs->add_ba_req_delayed = true;
 	pTxTs->TxPendingBARecord.b_valid = false;
 }
 
diff --git a/drivers/staging/rtl8192e/rtl819x_TS.h b/drivers/staging/rtl8192e/rtl819x_TS.h
index 276a50f98781..0bf73b625708 100644
--- a/drivers/staging/rtl8192e/rtl819x_TS.h
+++ b/drivers/staging/rtl8192e/rtl819x_TS.h
@@ -28,7 +28,7 @@ struct tx_ts_record {
 	struct ba_record TxPendingBARecord;
 	struct ba_record TxAdmittedBARecord;
 	u8				add_ba_req_in_progress;
-	u8				bAddBaReqDelayed;
+	u8				add_ba_req_delayed;
 	u8				bUsingBa;
 	u8				bDisable_AddBa;
 	struct timer_list		TsAddBaTimer;
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 62414e7b8879..3a1bb512ca69 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -102,7 +102,7 @@ static void ResetTxTsEntry(struct tx_ts_record *ts)
 	ResetTsCommonInfo(&ts->TsCommonInfo);
 	ts->TxCurSeq = 0;
 	ts->add_ba_req_in_progress = false;
-	ts->bAddBaReqDelayed = false;
+	ts->add_ba_req_delayed = false;
 	ts->bUsingBa = false;
 	ts->bDisable_AddBa = false;
 	rtllib_reset_ba_entry(&ts->TxAdmittedBARecord);
@@ -436,7 +436,7 @@ void TsStartAddBaProcess(struct rtllib_device *ieee, struct tx_ts_record *pTxTS)
 	if (pTxTS->add_ba_req_in_progress == false) {
 		pTxTS->add_ba_req_in_progress = true;
 
-		if (pTxTS->bAddBaReqDelayed) {
+		if (pTxTS->add_ba_req_delayed) {
 			netdev_dbg(ieee->dev, "Start ADDBA after 60 sec!!\n");
 			mod_timer(&pTxTS->TsAddBaTimer, jiffies +
 				  msecs_to_jiffies(TS_ADDBA_DELAY));
-- 
2.39.2


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 5/7] Staging: rtl8192e: Rename variable bUsingBa
  2023-11-13 19:59 [PATCH 0/7] Staging: rtl8192e: Rename bool variables Tree Davies
                   ` (3 preceding siblings ...)
  2023-11-13 19:59 ` [PATCH 4/7] Staging: rtl8192e: Rename variable bAddBaReqDelayed Tree Davies
@ 2023-11-13 19:59 ` Tree Davies
  2023-11-13 19:59 ` [PATCH 6/7] Staging: rtl8192e: Rename variable bOverwritePending Tree Davies
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Tree Davies @ 2023-11-13 19:59 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable bUsingBa to using_ba to fix
checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
 drivers/staging/rtl8192e/rtl819x_TS.h     | 2 +-
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
 drivers/staging/rtl8192e/rtllib_tx.c      | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 631c857c508f..cbf74cac0599 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -452,7 +452,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
 			return -1;
 		}
 
-		pTxTs->bUsingBa = false;
+		pTxTs->using_ba = false;
 		pTxTs->add_ba_req_in_progress = false;
 		pTxTs->add_ba_req_delayed = false;
 		del_timer_sync(&pTxTs->TsAddBaTimer);
diff --git a/drivers/staging/rtl8192e/rtl819x_TS.h b/drivers/staging/rtl8192e/rtl819x_TS.h
index 0bf73b625708..289314de1193 100644
--- a/drivers/staging/rtl8192e/rtl819x_TS.h
+++ b/drivers/staging/rtl8192e/rtl819x_TS.h
@@ -29,7 +29,7 @@ struct tx_ts_record {
 	struct ba_record TxAdmittedBARecord;
 	u8				add_ba_req_in_progress;
 	u8				add_ba_req_delayed;
-	u8				bUsingBa;
+	u8				using_ba;
 	u8				bDisable_AddBa;
 	struct timer_list		TsAddBaTimer;
 	u8				num;
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 3a1bb512ca69..867889dc4fb6 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -103,7 +103,7 @@ static void ResetTxTsEntry(struct tx_ts_record *ts)
 	ts->TxCurSeq = 0;
 	ts->add_ba_req_in_progress = false;
 	ts->add_ba_req_delayed = false;
-	ts->bUsingBa = false;
+	ts->using_ba = false;
 	ts->bDisable_AddBa = false;
 	rtllib_reset_ba_entry(&ts->TxAdmittedBARecord);
 	rtllib_reset_ba_entry(&ts->TxPendingBARecord);
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index a99c3b3f867c..cee3b8855c0e 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -304,10 +304,10 @@ static void rtllib_tx_query_agg_cap(struct rtllib_device *ieee,
 				TsStartAddBaProcess(ieee, pTxTs);
 			}
 			goto FORCED_AGG_SETTING;
-		} else if (!pTxTs->bUsingBa) {
+		} else if (!pTxTs->using_ba) {
 			if (SN_LESS(pTxTs->TxAdmittedBARecord.ba_start_seq_ctrl.field.seq_num,
 				    (pTxTs->TxCurSeq + 1) % 4096))
-				pTxTs->bUsingBa = true;
+				pTxTs->using_ba = true;
 			else
 				goto FORCED_AGG_SETTING;
 		}
-- 
2.39.2


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 6/7] Staging: rtl8192e: Rename variable bOverwritePending
  2023-11-13 19:59 [PATCH 0/7] Staging: rtl8192e: Rename bool variables Tree Davies
                   ` (4 preceding siblings ...)
  2023-11-13 19:59 ` [PATCH 5/7] Staging: rtl8192e: Rename variable bUsingBa Tree Davies
@ 2023-11-13 19:59 ` Tree Davies
  2023-11-13 19:59 ` [PATCH 7/7] Staging: rtl8192e: Rename variable bDisable_AddBa Tree Davies
  2023-11-14 20:09 ` [PATCH 0/7] Staging: rtl8192e: Rename bool variables Philipp Hortmann
  7 siblings, 0 replies; 9+ messages in thread
From: Tree Davies @ 2023-11-13 19:59 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable bOverwritePending to overwrite_pending to fix
checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++--
 drivers/staging/rtl8192e/rtllib.h         | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index cbf74cac0599..3502f27342e3 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -462,11 +462,11 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
 }
 
 void rtllib_ts_init_add_ba(struct rtllib_device *ieee, struct tx_ts_record *ts,
-			   u8 policy, u8	bOverwritePending)
+			   u8 policy, u8	overwrite_pending)
 {
 	struct ba_record *ba = &ts->TxPendingBARecord;
 
-	if (ba->b_valid && !bOverwritePending)
+	if (ba->b_valid && !overwrite_pending)
 		return;
 
 	deactivate_ba_entry(ieee, ba);
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index d2cf3cfaaaba..adaab56a9fb1 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1788,7 +1788,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb);
 int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb);
 int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb);
 void rtllib_ts_init_add_ba(struct rtllib_device *ieee, struct tx_ts_record *ts,
-			   u8 policy, u8 bOverwritePending);
+			   u8 policy, u8 overwrite_pending);
 void rtllib_ts_init_del_ba(struct rtllib_device *ieee,
 			   struct ts_common_info *pTsCommonInfo,
 			   enum tr_select TxRxSelect);
-- 
2.39.2


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 7/7] Staging: rtl8192e: Rename variable bDisable_AddBa
  2023-11-13 19:59 [PATCH 0/7] Staging: rtl8192e: Rename bool variables Tree Davies
                   ` (5 preceding siblings ...)
  2023-11-13 19:59 ` [PATCH 6/7] Staging: rtl8192e: Rename variable bOverwritePending Tree Davies
@ 2023-11-13 19:59 ` Tree Davies
  2023-11-14 20:09 ` [PATCH 0/7] Staging: rtl8192e: Rename bool variables Philipp Hortmann
  7 siblings, 0 replies; 9+ messages in thread
From: Tree Davies @ 2023-11-13 19:59 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable bDisable_AddBa to disable_add_ba to fix
checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
 drivers/staging/rtl8192e/rtl819x_TS.h     | 2 +-
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
 drivers/staging/rtl8192e/rtllib_tx.c      | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 3502f27342e3..b52b42ac0fc4 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -382,7 +382,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
 		activate_ba_entry(pAdmittedBA, *pBaTimeoutVal);
 	} else {
 		ts->add_ba_req_delayed = true;
-		ts->bDisable_AddBa = true;
+		ts->disable_add_ba = true;
 		reason_code = DELBA_REASON_END_BA;
 		goto OnADDBARsp_Reject;
 	}
diff --git a/drivers/staging/rtl8192e/rtl819x_TS.h b/drivers/staging/rtl8192e/rtl819x_TS.h
index 289314de1193..742f575ea637 100644
--- a/drivers/staging/rtl8192e/rtl819x_TS.h
+++ b/drivers/staging/rtl8192e/rtl819x_TS.h
@@ -30,7 +30,7 @@ struct tx_ts_record {
 	u8				add_ba_req_in_progress;
 	u8				add_ba_req_delayed;
 	u8				using_ba;
-	u8				bDisable_AddBa;
+	u8				disable_add_ba;
 	struct timer_list		TsAddBaTimer;
 	u8				num;
 };
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 867889dc4fb6..41c1e768348a 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -104,7 +104,7 @@ static void ResetTxTsEntry(struct tx_ts_record *ts)
 	ts->add_ba_req_in_progress = false;
 	ts->add_ba_req_delayed = false;
 	ts->using_ba = false;
-	ts->bDisable_AddBa = false;
+	ts->disable_add_ba = false;
 	rtllib_reset_ba_entry(&ts->TxAdmittedBARecord);
 	rtllib_reset_ba_entry(&ts->TxPendingBARecord);
 }
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index cee3b8855c0e..1da098f5b84c 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -300,7 +300,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_device *ieee,
 				;
 			} else if (tcb_desc->bdhcp == 1) {
 				;
-			} else if (!pTxTs->bDisable_AddBa) {
+			} else if (!pTxTs->disable_add_ba) {
 				TsStartAddBaProcess(ieee, pTxTs);
 			}
 			goto FORCED_AGG_SETTING;
-- 
2.39.2


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 0/7] Staging: rtl8192e: Rename bool variables
  2023-11-13 19:59 [PATCH 0/7] Staging: rtl8192e: Rename bool variables Tree Davies
                   ` (6 preceding siblings ...)
  2023-11-13 19:59 ` [PATCH 7/7] Staging: rtl8192e: Rename variable bDisable_AddBa Tree Davies
@ 2023-11-14 20:09 ` Philipp Hortmann
  7 siblings, 0 replies; 9+ messages in thread
From: Philipp Hortmann @ 2023-11-14 20:09 UTC (permalink / raw)
  To: Tree Davies, gregkh, anjan; +Cc: linux-staging, linux-kernel

On 11/13/23 20:59, Tree Davies wrote:
> This series renames bool variables to fix checkpatch warnings
> Thank you in advance to reviewers
> regards,
> ~Tree
> 
> Tree Davies (7):
>    Staging: rtl8192e: Rename variable bSendDELBA
>    Staging: rtl8192e: Rename variable bCurrentAMPDUEnable
>    Staging: rtl8192e: Rename variable bAddBaReqInProgress
>    Staging: rtl8192e: Rename variable bAddBaReqDelayed
>    Staging: rtl8192e: Rename variable bUsingBa
>    Staging: rtl8192e: Rename variable bOverwritePending
>    Staging: rtl8192e: Rename variable bDisable_AddBa
> 
>   drivers/staging/rtl8192e/rtl819x_BAProc.c | 40 +++++++++++------------
>   drivers/staging/rtl8192e/rtl819x_HT.h     |  2 +-
>   drivers/staging/rtl8192e/rtl819x_HTProc.c |  6 ++--
>   drivers/staging/rtl8192e/rtl819x_TS.h     |  8 ++---
>   drivers/staging/rtl8192e/rtl819x_TSProc.c | 14 ++++----
>   drivers/staging/rtl8192e/rtllib.h         |  2 +-
>   drivers/staging/rtl8192e/rtllib_tx.c      |  8 ++---
>   7 files changed, 40 insertions(+), 40 deletions(-)
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-11-14 20:10 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-13 19:59 [PATCH 0/7] Staging: rtl8192e: Rename bool variables Tree Davies
2023-11-13 19:59 ` [PATCH 1/7] Staging: rtl8192e: Rename variable bSendDELBA Tree Davies
2023-11-13 19:59 ` [PATCH 2/7] Staging: rtl8192e: Rename variable bCurrentAMPDUEnable Tree Davies
2023-11-13 19:59 ` [PATCH 3/7] Staging: rtl8192e: Rename variable bAddBaReqInProgress Tree Davies
2023-11-13 19:59 ` [PATCH 4/7] Staging: rtl8192e: Rename variable bAddBaReqDelayed Tree Davies
2023-11-13 19:59 ` [PATCH 5/7] Staging: rtl8192e: Rename variable bUsingBa Tree Davies
2023-11-13 19:59 ` [PATCH 6/7] Staging: rtl8192e: Rename variable bOverwritePending Tree Davies
2023-11-13 19:59 ` [PATCH 7/7] Staging: rtl8192e: Rename variable bDisable_AddBa Tree Davies
2023-11-14 20:09 ` [PATCH 0/7] Staging: rtl8192e: Rename bool variables Philipp Hortmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®