From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pratyush Yadav <p.yadav@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Herve Codina <herve.codina@bootlin.com>
Subject: Re: [PATCH v2 2/2] spi: fsl-spi: Implement trailing bits
Date: Mon, 22 Aug 2022 18:38:22 +0000 [thread overview]
Message-ID: <c4950a61-ba9a-5897-1f04-bb2c56979d7d@csgroup.eu> (raw)
In-Reply-To: <YwO5l/KpXoKJVawq@sirena.org.uk>
Le 22/08/2022 à 19:15, Mark Brown a écrit :
> On Thu, Aug 18, 2022 at 06:35:39PM +0000, Christophe Leroy wrote:
>
>> Yes indeed. Therefore in v3 I took a different approach : a flag .cs_off
>> tells to spi_transfer_one_message() that a given transfer has to be
>> performed with chipselect OFF, therefore the consumer has full control
>> of how and when to add those additional fake clock cycles during a
>> transfer, and can eventually add one at anyplace during the transfer.
>
>> Here an exemple of what will do the consumer.
>
> Hrm, we should already be able to synthesize that with cs_change though
> there's usability challenges there and AFAICT it doesn't work for the
> first transfer which your proposal would so there's a functional benefit
> even if you don't need it for your device right now. It would be good
> if you could have a look at using cs_change for your use case. Sorry, I
> don't think I'd fully realised what you were looking to accomplish here
> until I saw your proposal.
I think we already addressed this possibility back in 2016, see
https://lore.kernel.org/linux-spi/20160824111206.GD22076@sirena.org.uk/
The conclusion was that it was not possible to accomplish it with cs_change.
Or did we miss something at that time ?
My understanding is that if you set cs_change for any transfer of a
message except the last, then CS goes OFF then ON again between the said
transfer and the following one. If you set cs_change for the last
transfer of a message, then CS stays ON until next message instead of
going OFF as usual.
My need is to transfer a fake byte with CS off at the end of a message.
I still can't see how cs_change can achieve that.
Thanks
Christophe
next prev parent reply other threads:[~2022-08-22 18:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 15:15 [PATCH v2 0/2] Add support for components requiring trailing clock after transfer Christophe Leroy
2022-02-28 15:15 ` [PATCH v2 1/2] spi: Add optional number of additional clock cycles to be generated Christophe Leroy
2022-03-08 0:52 ` Rob Herring
2022-02-28 15:15 ` [PATCH v2 2/2] spi: fsl-spi: Implement trailing bits Christophe Leroy
2022-02-28 15:29 ` Mark Brown
2022-02-28 16:02 ` Christophe Leroy
2022-02-28 16:14 ` Mark Brown
2022-03-01 12:53 ` Christophe Leroy
2022-03-01 13:25 ` Mark Brown
2022-08-18 18:35 ` Christophe Leroy
2022-08-22 17:15 ` Mark Brown
2022-08-22 18:38 ` Christophe Leroy [this message]
2022-08-22 19:29 ` Mark Brown
2022-02-28 18:28 ` kernel test robot
2022-02-28 18:38 ` kernel test robot
2022-02-28 18:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4950a61-ba9a-5897-1f04-bb2c56979d7d@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®