* [PATCH v1] drm/bridge: inno-hdmi: reset DDC segment pointer per I2C transfer
@ 2026-05-28 18:41 Dominique Belhachemi
2026-07-10 18:40 ` Dominique Belhachemi
[not found] ` <CGME20260927085152eucas1p274e0c4d85641cbbc5e727b4b559d21cf@eucas1p2.samsung.com>
0 siblings, 2 replies; 5+ messages in thread
From: Dominique Belhachemi @ 2026-05-28 18:41 UTC (permalink / raw)
To: Andy Yan, dri-devel
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, linux-kernel
The segment_addr and ddc_addr fields need to be reset per I2C transfer
to avoid stale values. The reset wasn't required on simple displays with
only one segment, but modern displays with two or more segments end up
with corrupt EDIDs.
This was found on a StarFive VisionFive 2 SBC.
Signed-off-by: Dominique Belhachemi <domibel@debian.org>
---
drivers/gpu/drm/bridge/inno-hdmi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/bridge/inno-hdmi.c b/drivers/gpu/drm/bridge/inno-hdmi.c
index 5fa533a4eb342..297be02bbd58d 100644
--- a/drivers/gpu/drm/bridge/inno-hdmi.c
+++ b/drivers/gpu/drm/bridge/inno-hdmi.c
@@ -989,6 +989,10 @@ static int inno_hdmi_i2c_xfer(struct i2c_adapter *adap,
mutex_lock(&i2c->lock);
+ /* Reset segment_addr and ddc_addr at the start of every I2C transfer */
+ i2c->ddc_addr = 0;
+ i2c->segment_addr = 0;
+
/* Clear the EDID interrupt flag and unmute the interrupt */
hdmi_writeb(hdmi, HDMI_INTERRUPT_MASK1, m_INT_EDID_READY);
hdmi_writeb(hdmi, HDMI_INTERRUPT_STATUS1, m_INT_EDID_READY);
--
2.53.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] drm/bridge: inno-hdmi: reset DDC segment pointer per I2C transfer
2026-05-28 18:41 [PATCH v1] drm/bridge: inno-hdmi: reset DDC segment pointer per I2C transfer Dominique Belhachemi
@ 2026-07-10 18:40 ` Dominique Belhachemi
[not found] ` <CGME20260927085152eucas1p274e0c4d85641cbbc5e727b4b559d21cf@eucas1p2.samsung.com>
1 sibling, 0 replies; 5+ messages in thread
From: Dominique Belhachemi @ 2026-07-10 18:40 UTC (permalink / raw)
To: Andy Yan
Cc: dri-devel, Andrzej Hajda, Neil Armstrong, Robert Foss, linux-kernel
On Thu, May 28, 2026 at 2:41 PM Dominique Belhachemi <domibel@debian.org> wrote:
>
> The segment_addr and ddc_addr fields need to be reset per I2C transfer
> to avoid stale values. The reset wasn't required on simple displays with
> only one segment, but modern displays with two or more segments end up
> with corrupt EDIDs.
>
> This was found on a StarFive VisionFive 2 SBC.
>
> Signed-off-by: Dominique Belhachemi <domibel@debian.org>
> ---
> drivers/gpu/drm/bridge/inno-hdmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/inno-hdmi.c b/drivers/gpu/drm/bridge/inno-hdmi.c
> index 5fa533a4eb342..297be02bbd58d 100644
> --- a/drivers/gpu/drm/bridge/inno-hdmi.c
> +++ b/drivers/gpu/drm/bridge/inno-hdmi.c
> @@ -989,6 +989,10 @@ static int inno_hdmi_i2c_xfer(struct i2c_adapter *adap,
>
> mutex_lock(&i2c->lock);
>
> + /* Reset segment_addr and ddc_addr at the start of every I2C transfer */
> + i2c->ddc_addr = 0;
> + i2c->segment_addr = 0;
> +
> /* Clear the EDID interrupt flag and unmute the interrupt */
> hdmi_writeb(hdmi, HDMI_INTERRUPT_MASK1, m_INT_EDID_READY);
> hdmi_writeb(hdmi, HDMI_INTERRUPT_STATUS1, m_INT_EDID_READY);
> --
Hi, Is there anything else I can provide to get this merged?
Thanks
-Dominique
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] drm/bridge: inno-hdmi: reset DDC segment pointer per I2C transfer
[not found] ` <CGME20260927085152eucas1p274e0c4d85641cbbc5e727b4b559d21cf@eucas1p2.samsung.com>
@ 2026-09-27 8:51 ` Michal Wilczynski
[not found] ` <CGME20260928111522eucas1p1e9b3945eacb52abe425272ebca524d8f@eucas1p1.samsung.com>
0 siblings, 1 reply; 5+ messages in thread
From: Michal Wilczynski @ 2026-09-27 8:51 UTC (permalink / raw)
To: Dominique Belhachemi, Andy Yan, dri-devel
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, linux-kernel
On 5/28/26 20:41, Dominique Belhachemi wrote:
> The segment_addr and ddc_addr fields need to be reset per I2C transfer
> to avoid stale values. The reset wasn't required on simple displays with
> only one segment, but modern displays with two or more segments end up
> with corrupt EDIDs.
>
> This was found on a StarFive VisionFive 2 SBC.
>
> Signed-off-by: Dominique Belhachemi <domibel@debian.org>
> ---
> drivers/gpu/drm/bridge/inno-hdmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/inno-hdmi.c b/drivers/gpu/drm/bridge/inno-hdmi.c
> index 5fa533a4eb342..297be02bbd58d 100644
> --- a/drivers/gpu/drm/bridge/inno-hdmi.c
> +++ b/drivers/gpu/drm/bridge/inno-hdmi.c
> @@ -989,6 +989,10 @@ static int inno_hdmi_i2c_xfer(struct i2c_adapter *adap,
>
> mutex_lock(&i2c->lock);
>
> + /* Reset segment_addr and ddc_addr at the start of every I2C transfer */
> + i2c->ddc_addr = 0;
> + i2c->segment_addr = 0;
> +
> /* Clear the EDID interrupt flag and unmute the interrupt */
> hdmi_writeb(hdmi, HDMI_INTERRUPT_MASK1, m_INT_EDID_READY);
> hdmi_writeb(hdmi, HDMI_INTERRUPT_STATUS1, m_INT_EDID_READY);
Reviewed-by: Michal Wilczynski <m.wilczynski@samsung.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] drm/bridge: inno-hdmi: reset DDC segment pointer per I2C transfer
[not found] ` <CGME20260928111522eucas1p1e9b3945eacb52abe425272ebca524d8f@eucas1p1.samsung.com>
@ 2026-09-28 11:15 ` Michal Wilczynski
2026-09-28 22:01 ` Dominique Belhachemi
0 siblings, 1 reply; 5+ messages in thread
From: Michal Wilczynski @ 2026-09-28 11:15 UTC (permalink / raw)
To: Dominique Belhachemi, Andy Yan, dri-devel
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, linux-kernel
On 9/27/26 10:51, Michal Wilczynski wrote:
>
>
> On 5/28/26 20:41, Dominique Belhachemi wrote:
>> The segment_addr and ddc_addr fields need to be reset per I2C transfer
>> to avoid stale values. The reset wasn't required on simple displays with
>> only one segment, but modern displays with two or more segments end up
>> with corrupt EDIDs.
>>
>> This was found on a StarFive VisionFive 2 SBC.
>>
>> Signed-off-by: Dominique Belhachemi <domibel@debian.org>
>> ---
>> drivers/gpu/drm/bridge/inno-hdmi.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/bridge/inno-hdmi.c b/drivers/gpu/drm/bridge/inno-hdmi.c
>> index 5fa533a4eb342..297be02bbd58d 100644
>> --- a/drivers/gpu/drm/bridge/inno-hdmi.c
>> +++ b/drivers/gpu/drm/bridge/inno-hdmi.c
>> @@ -989,6 +989,10 @@ static int inno_hdmi_i2c_xfer(struct i2c_adapter *adap,
>>
>> mutex_lock(&i2c->lock);
>>
>> + /* Reset segment_addr and ddc_addr at the start of every I2C transfer */
>> + i2c->ddc_addr = 0;
>> + i2c->segment_addr = 0;
>> +
>> /* Clear the EDID interrupt flag and unmute the interrupt */
>> hdmi_writeb(hdmi, HDMI_INTERRUPT_MASK1, m_INT_EDID_READY);
>> hdmi_writeb(hdmi, HDMI_INTERRUPT_STATUS1, m_INT_EDID_READY);
>
> Reviewed-by: Michal Wilczynski <m.wilczynski@samsung.com>
I was also told that there were some changes in the MAINTAINERS file
regarding this patch and some core people may be missing e.g Luca and
Maxime.
It would be best to resend with updated list of maintainers.
Best regards,
--
Michal Wilczynski <m.wilczynski@samsung.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] drm/bridge: inno-hdmi: reset DDC segment pointer per I2C transfer
2026-09-28 11:15 ` Michal Wilczynski
@ 2026-09-28 22:01 ` Dominique Belhachemi
0 siblings, 0 replies; 5+ messages in thread
From: Dominique Belhachemi @ 2026-09-28 22:01 UTC (permalink / raw)
To: Michal Wilczynski
Cc: Andy Yan, dri-devel, Andrzej Hajda, Neil Armstrong, Robert Foss,
linux-kernel, Luca Ceresoli, Maxime Ripard, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst,
Thomas Zimmermann
On Mon, Sep 28, 2026 at 7:15 AM Michal Wilczynski
<m.wilczynski@samsung.com> wrote:
>
>
>
> On 9/27/26 10:51, Michal Wilczynski wrote:
> >
> >
> > On 5/28/26 20:41, Dominique Belhachemi wrote:
> >> The segment_addr and ddc_addr fields need to be reset per I2C transfer
> >> to avoid stale values. The reset wasn't required on simple displays with
> >> only one segment, but modern displays with two or more segments end up
> >> with corrupt EDIDs.
> >>
> >> This was found on a StarFive VisionFive 2 SBC.
> >>
> >> Signed-off-by: Dominique Belhachemi <domibel@debian.org>
> >> ---
> >> drivers/gpu/drm/bridge/inno-hdmi.c | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/bridge/inno-hdmi.c b/drivers/gpu/drm/bridge/inno-hdmi.c
> >> index 5fa533a4eb342..297be02bbd58d 100644
> >> --- a/drivers/gpu/drm/bridge/inno-hdmi.c
> >> +++ b/drivers/gpu/drm/bridge/inno-hdmi.c
> >> @@ -989,6 +989,10 @@ static int inno_hdmi_i2c_xfer(struct i2c_adapter *adap,
> >>
> >> mutex_lock(&i2c->lock);
> >>
> >> + /* Reset segment_addr and ddc_addr at the start of every I2C transfer */
> >> + i2c->ddc_addr = 0;
> >> + i2c->segment_addr = 0;
> >> +
> >> /* Clear the EDID interrupt flag and unmute the interrupt */
> >> hdmi_writeb(hdmi, HDMI_INTERRUPT_MASK1, m_INT_EDID_READY);
> >> hdmi_writeb(hdmi, HDMI_INTERRUPT_STATUS1, m_INT_EDID_READY);
> >
> > Reviewed-by: Michal Wilczynski <m.wilczynski@samsung.com>
>
> I was also told that there were some changes in the MAINTAINERS file
> regarding this patch and some core people may be missing e.g Luca and
> Maxime.
>
> It would be best to resend with updated list of maintainers.
>
Thanks Michal, I am adding them to Cc.
Best
-Dominique
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-09-28 22:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-28 18:41 [PATCH v1] drm/bridge: inno-hdmi: reset DDC segment pointer per I2C transfer Dominique Belhachemi
2026-07-10 18:40 ` Dominique Belhachemi
[not found] ` <CGME20260927085152eucas1p274e0c4d85641cbbc5e727b4b559d21cf@eucas1p2.samsung.com>
2026-09-27 8:51 ` Michal Wilczynski
[not found] ` <CGME20260928111522eucas1p1e9b3945eacb52abe425272ebca524d8f@eucas1p1.samsung.com>
2026-09-28 11:15 ` Michal Wilczynski
2026-09-28 22:01 ` Dominique Belhachemi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®