From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Lucas Tanure <lucas.tanure@collabora.com>,
David Rhodes <david.rhodes@cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
"Takashi Iwai --cc=alsa-devel @ alsa-project . org"
<tiwai@suse.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk
Date: Thu, 9 Mar 2023 14:04:28 +0000 [thread overview]
Message-ID: <c5b6077c-1e6e-43fe-8f83-ca7019d4a43d@sirena.org.uk> (raw)
In-Reply-To: <2881f527-1673-3496-85a2-84a13f074248@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
On Thu, Mar 09, 2023 at 11:42:42AM +0100, Krzysztof Kozlowski wrote:
> On 09/03/2023 11:41, Lucas Tanure wrote:
> > - ret = device_property_read_u32(dev, "cirrus,boost-type", &val);
> > - if (ret >= 0)
> > - hw_cfg->bst_type = val;
> > + if (device_property_read_bool(dev, "cirrus,shared-boost-active")) {
> You are now changing ABI and adding undocumented properties.
Note also that this doesn't change the existing property, it continues
to work identically.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-03-09 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 10:41 Lucas Tanure
2023-03-09 10:42 ` Krzysztof Kozlowski
2023-03-09 11:04 ` Mark Brown
2023-03-09 11:17 ` Krzysztof Kozlowski
2023-03-09 11:19 ` Mark Brown
2023-03-09 11:25 ` Krzysztof Kozlowski
2023-03-09 14:04 ` Mark Brown [this message]
2023-03-09 16:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5b6077c-1e6e-43fe-8f83-ca7019d4a43d@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.tanure@collabora.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®