From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Lucas Tanure <lucas.tanure@collabora.com>,
David Rhodes <david.rhodes@cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
"Takashi Iwai --cc=alsa-devel @ alsa-project . org"
<tiwai@suse.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk
Date: Thu, 9 Mar 2023 12:25:18 +0100 [thread overview]
Message-ID: <fea6e236-94da-68da-36b9-e8e21c037cfb@linaro.org> (raw)
In-Reply-To: <d20cd40f-659c-4260-b47e-a0c5eee5437a@sirena.org.uk>
On 09/03/2023 12:19, Mark Brown wrote:
> On Thu, Mar 09, 2023 at 12:17:35PM +0100, Krzysztof Kozlowski wrote:
>> On 09/03/2023 12:04, Mark Brown wrote:
>>> On Thu, Mar 09, 2023 at 11:42:42AM +0100, Krzysztof Kozlowski wrote:
>
>>>> You are now changing ABI and adding undocumented properties.
>
>>> This is newly added code, changes are fine.
>
>> OK, for the ABI code, but not for the undocumented properties. Commit
>> does not explain that.
>
> It does, it says that it's adding support for the properties used in the
> firmware on existing Steam Decks. Those aren't even DT systems.
For some reason DT is cced...
The code unfortunately will allow to put them into DT and next time
people will use it as an argument to document in the binding ("because
driver already has them"). I heard this argument already many times.
Document then that these are not DT properties.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-09 11:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 10:41 Lucas Tanure
2023-03-09 10:42 ` Krzysztof Kozlowski
2023-03-09 11:04 ` Mark Brown
2023-03-09 11:17 ` Krzysztof Kozlowski
2023-03-09 11:19 ` Mark Brown
2023-03-09 11:25 ` Krzysztof Kozlowski [this message]
2023-03-09 14:04 ` Mark Brown
2023-03-09 16:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fea6e236-94da-68da-36b9-e8e21c037cfb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.tanure@collabora.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®