mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Lucas Tanure <lucas.tanure@collabora.com>,
	David Rhodes <david.rhodes@cirrus.com>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>,
	"Takashi Iwai --cc=alsa-devel @ alsa-project . org"
	<tiwai@suse.com>,
	patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
	kernel@collabora.com
Subject: Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk
Date: Thu, 9 Mar 2023 11:19:36 +0000	[thread overview]
Message-ID: <d20cd40f-659c-4260-b47e-a0c5eee5437a@sirena.org.uk> (raw)
In-Reply-To: <23cb7d3c-4cf8-8d9d-dbdb-4391384a5726@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

On Thu, Mar 09, 2023 at 12:17:35PM +0100, Krzysztof Kozlowski wrote:
> On 09/03/2023 12:04, Mark Brown wrote:
> > On Thu, Mar 09, 2023 at 11:42:42AM +0100, Krzysztof Kozlowski wrote:

> >> You are now changing ABI and adding undocumented properties.

> > This is newly added code, changes are fine.

> OK, for the ABI code, but not for the undocumented properties. Commit
> does not explain that.

It does, it says that it's adding support for the properties used in the
firmware on existing Steam Decks.  Those aren't even DT systems.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-03-09 11:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09 10:41 Lucas Tanure
2023-03-09 10:42 ` Krzysztof Kozlowski
2023-03-09 11:04   ` Mark Brown
2023-03-09 11:17     ` Krzysztof Kozlowski
2023-03-09 11:19       ` Mark Brown [this message]
2023-03-09 11:25         ` Krzysztof Kozlowski
2023-03-09 14:04   ` Mark Brown
2023-03-09 16:20 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d20cd40f-659c-4260-b47e-a0c5eee5437a@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=david.rhodes@cirrus.com \
    --cc=kernel@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.tanure@collabora.com \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®