From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tpa6130a2: unmerge power enable error path from power disable path
Date: Mon, 26 Sep 2016 19:14:50 +0300 [thread overview]
Message-ID: <c6fc5e9d-994f-fb62-1965-406c910135cd@cogentembedded.com> (raw)
In-Reply-To: <20160926160831.e5gd4t4fqhkxgzii@sirena.org.uk>
>> I doubt that copying 7 lines into error path is better than having a tiny
>> logic with return values, but still here it is.
>
> Consider what happens if someone wants to change the code...
I believe that "undo poweron" and "poweroff" sequences still will have
to remain the same. This having two copies of code is more error-prone
than having one.
Nikita
next prev parent reply other threads:[~2016-09-26 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 10:10 [PATCH] ASoC: tpa6130a2: fix volume setting when no stream is running Nikita Yushchenko
2016-09-24 18:31 ` Mark Brown
2016-09-26 10:35 ` [PATCH] ASoC: tpa6130a2: unmerge power enable error path from power disable path Nikita Yushchenko
2016-09-26 16:08 ` Mark Brown
2016-09-26 16:14 ` Nikita Yushchenko [this message]
2016-09-26 16:15 ` Applied "ASoC: tpa6130a2: unmerge power enable error path from power disable path" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6fc5e9d-994f-fb62-1965-406c910135cd@cogentembedded.com \
--to=nikita.yoush@cogentembedded.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®