mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: "Chang S. Bae" <chang.seok.bae@intel.com>, linux-kernel@vger.kernel.org
Cc: x86@kernel.org, tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, hpa@zytor.com
Subject: Re: [PATCH] x86/microcode/intel: Panic on partial microcode update
Date: Tue, 30 Jun 2026 14:47:46 -0700	[thread overview]
Message-ID: <c939bfd7-2cde-4777-8eb2-d47c9e2ba480@intel.com> (raw)
In-Reply-To: <4f2a4841-0a73-4f44-aec8-890734660a9c@intel.com>

Thinking about this a bit more: I don't think we should panic. It's
perfectly fine to spew a nice scary warning. But we really should
continue unless we really *know* that something has gone so horribly
wrong that it's dangerous to continue.

Think about things like folks who are ssh'd in. Say they have a bad,
partial ucode update. With this approach, they get a dead ssh session.

If you WARN() and keep going, they at least have a chance of seeing the
spew and getting it off the system.

I mean, the ucode update guys themselves could definitely have reset the
system if it needed to. They also know when it is dangerous to keep the
CPU running. They obviously don't think that this partial update thing
is *THAT* dangerous or they wouldn't have even let the CPU keep
churning. Right?

  reply	other threads:[~2026-06-30 21:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 19:13 Chang S. Bae
2026-06-30 21:38 ` Dave Hansen
2026-06-30 21:47   ` Dave Hansen [this message]
2026-06-30 23:21     ` Borislav Petkov
2026-07-01 19:02     ` Chang S. Bae
2026-07-08 21:18 ` [PATCH v2] x86/microcode/intel: Taint kernel on partial update Chang S. Bae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c939bfd7-2cde-4777-8eb2-d47c9e2ba480@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@alien8.de \
    --cc=chang.seok.bae@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome