Re: [PATCH v2 6/6] firmware: raspberrypi: Store child devices in struct rpi_firmware

[Stefan Wahren <wahrenst@gmx.net>]

Hi,

Am 09.11.26 um 06:55 schrieb Sander Speetjens:
> Hi Stefan,
>
> On 11/8/26 22:06, Stefan Wahren wrote:
>> Hi Sander,
>>
>> Am 07.11.26 um 19:21 schrieb Sander Speetjens:
>>> The hwmon and clock platform devices were kept in global variables.
>>> Move them into struct rpi_firmware so each instance owns its own
>>> children and their lifetimes are correctly paired with the parent.
>>>
>>> Also check the return value of platform_device_register_data() so that
>>> an error pointer is never stored.  The child devices are optional; do
>>> not propagate registration failures so the main firmware interface
>>> remains available.
>>>
>>> Signed-off-by: Sander Speetjens <sander.speetjens@gmail.com>
>>
>> the first version of this patch contained fixes tags, but they were 
>> dropped without mention it in the cover letter. 
>
> I was not 100% sure if the commit needed them. If you say that it is 
> needed, I will add it again.

imo the problem with the commit message is that it's not clear this 
change is a bugfix or a improvement. Please try to focus on the why and 
not what is changed.

In case this change fixes a real bug than it needs fixes tag.

Best regards

>
> Kind regards
> Sander Speetjens