From: Marek Vasut <marex@denx.de>
To: Olivier Moysan <olivier.moysan@foss.st.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: kernel@dh-electronics.com, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/8] ARM: dts: stm32: adopt generic iio bindings for adc channels on dhcor-drc
Date: Wed, 24 May 2023 15:54:24 +0200 [thread overview]
Message-ID: <cc7a0a1a-31bb-92f4-6365-5e0c4a4bc85c@denx.de> (raw)
In-Reply-To: <20230524133918.1439516-8-olivier.moysan@foss.st.com>
On 5/24/23 15:39, Olivier Moysan wrote:
> Use STM32 ADC generic bindings instead of legacy bindings on
> DHCOR DRC Compact board.
>
> The STM32 ADC specific binding to declare channels has been deprecated,
> hence adopt the generic IIO channels bindings, instead.
> The STM32MP151 device tree now exposes internal channels using the
> generic binding. This makes the change mandatory here to avoid a mixed
> use of legacy and generic binding, which is not supported by the driver.
>
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---
> .../dts/stm32mp15xx-dhcor-drc-compact.dtsi | 28 ++++++++++++++++---
> 1 file changed, 24 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi
> index 39af79dc654c..92d906bfd5d7 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi
> @@ -57,15 +57,35 @@ &adc { /* X11 ADC inputs */
> status = "okay";
>
> adc1: adc@0 {
I sent similar patch recently too:
[PATCH] ARM: dts: stm32: Update to generic ADC channel binding on DHSOM
systems
But I needed to add #address-cells/#size-cells here and to adc@100,
otherwise DTB checker was complaining . Did you run DTB check and was it
OK on your side ?
> - st,adc-channels = <0 1 6>;
> - st,min-sample-time-nsecs = <5000>;
> status = "okay";
> + channel@0 {
> + reg = <0>;
> + st,min-sample-time-ns = <5000>;
> + };
> + channel@1 {
> + reg = <1>;
> + st,min-sample-time-ns = <5000>;
> + };
> + channel@6 {
> + reg = <6>;
> + st,min-sample-time-ns = <5000>;
> + };
> };
[...]
next prev parent reply other threads:[~2023-05-24 13:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 13:39 [PATCH 0/8] ARM: dts: stm32: add adc internal channels on stm32mp15 Olivier Moysan
2023-05-24 13:39 ` [PATCH 1/8] ARM: dts: stm32: add adc internal channels to stm32mp15 Olivier Moysan
2023-05-24 13:39 ` [PATCH 2/8] ARM: dts: stm32: add vrefint calibration on stm32mp15 Olivier Moysan
2023-05-24 13:39 ` [PATCH 3/8] ARM: dts: stm32: add vrefint support to adc2 " Olivier Moysan
2023-05-24 13:39 ` [PATCH 4/8] ARM: dts: stm32: enable adc on stm32mp15xx-dkx boards Olivier Moysan
2023-05-24 13:39 ` [PATCH 5/8] ARM: dts: stm32: adopt generic iio bindings for adc channels on stm32mp157c-ed1 Olivier Moysan
2023-05-24 13:39 ` [PATCH 6/8] ARM: dts: stm32: adopt generic iio bindings for adc channels on emstamp-argon Olivier Moysan
2023-05-24 13:39 ` [PATCH 7/8] ARM: dts: stm32: adopt generic iio bindings for adc channels on dhcor-drc Olivier Moysan
2023-05-24 13:54 ` Marek Vasut [this message]
2023-05-24 15:39 ` Olivier MOYSAN
2023-05-30 7:59 ` Alexandre TORGUE
2023-05-30 11:42 ` Marek Vasut
2023-05-24 13:39 ` [PATCH 8/8] ARM: dts: stm32: adopt generic iio bindings for adc channels on dhcor-testbench Olivier Moysan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc7a0a1a-31bb-92f4-6365-5e0c4a4bc85c@denx.de \
--to=marex@denx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@dh-electronics.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@foss.st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®