* [PATCH v1] coresight-tpdm: Correct the property name of MSR number
@ 2023-10-24 6:19 Tao Zhang
2023-10-25 10:27 ` Suzuki K Poulose
2023-11-01 13:26 ` Suzuki K Poulose
0 siblings, 2 replies; 3+ messages in thread
From: Tao Zhang @ 2023-10-24 6:19 UTC (permalink / raw)
To: Mathieu Poirier, Suzuki K Poulose, Alexander Shishkin,
Konrad Dybcio, Mike Leach, Rob Herring, Krzysztof Kozlowski
Cc: Tao Zhang, Jinlong Mao, Leo Yan, Greg Kroah-Hartman, coresight,
linux-arm-kernel, linux-kernel, devicetree, Tingwei Zhang,
Yuanfang Zhang, Trilok Soni, Song Chai, linux-arm-msm, andersson
Correct the property name of the DSB MSR number that needs to be
read in TPDM driver. The right property name is
"qcom,dsb-msrs-num".
Fixes： 90a7371cb08d ("coresight-tpdm: Add nodes for dsb msr support")
Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
---
drivers/hwtracing/coresight/coresight-tpdm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c
index b25284e..97654aa 100644
--- a/drivers/hwtracing/coresight/coresight-tpdm.c
+++ b/drivers/hwtracing/coresight/coresight-tpdm.c
@@ -892,7 +892,7 @@ static int tpdm_probe(struct amba_device *adev, const struct amba_id *id)
if (drvdata && tpdm_has_dsb_dataset(drvdata))
of_property_read_u32(drvdata->dev->of_node,
- "qcom,dsb_msr_num", &drvdata->dsb_msr_num);
+ "qcom,dsb-msrs-num", &drvdata->dsb_msr_num);
/* Set up coresight component description */
desc.name = coresight_alloc_device_name(&tpdm_devs, dev);
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] coresight-tpdm: Correct the property name of MSR number
2023-10-24 6:19 [PATCH v1] coresight-tpdm: Correct the property name of MSR number Tao Zhang
@ 2023-10-25 10:27 ` Suzuki K Poulose
2023-11-01 13:26 ` Suzuki K Poulose
1 sibling, 0 replies; 3+ messages in thread
From: Suzuki K Poulose @ 2023-10-25 10:27 UTC (permalink / raw)
To: Tao Zhang, Mathieu Poirier, Alexander Shishkin, Konrad Dybcio,
Mike Leach, Rob Herring, Krzysztof Kozlowski
Cc: Jinlong Mao, Leo Yan, Greg Kroah-Hartman, coresight,
linux-arm-kernel, linux-kernel, devicetree, Tingwei Zhang,
Yuanfang Zhang, Trilok Soni, Song Chai, linux-arm-msm, andersson
Hi
Please always run a checkpatch on your patch before submission.
(And of course test your patch properly for all the functionality
that it introduces. We don't have the hardware for testing all of
this. So, there is only so much we could do with the eyes)
On 24/10/2023 07:19, Tao Zhang wrote:
> Correct the property name of the DSB MSR number that needs to be
> read in TPDM driver. The right property name is
> "qcom,dsb-msrs-num".
>
> Fixes： 90a7371cb08d ("coresight-tpdm: Add nodes for dsb msr support")
> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
> ---
> drivers/hwtracing/coresight/coresight-tpdm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c
> index b25284e..97654aa 100644
> --- a/drivers/hwtracing/coresight/coresight-tpdm.c
> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c
> @@ -892,7 +892,7 @@ static int tpdm_probe(struct amba_device *adev, const struct amba_id *id)
>
> if (drvdata && tpdm_has_dsb_dataset(drvdata))
> of_property_read_u32(drvdata->dev->of_node,
> - "qcom,dsb_msr_num", &drvdata->dsb_msr_num);
> + "qcom,dsb-msrs-num", &drvdata->dsb_msr_num);
>
> /* Set up coresight component description */
> desc.name = coresight_alloc_device_name(&tpdm_devs, dev);
checkpatch complains:
ERROR: Please use git commit description style 'commit <12+ chars of
sha1> ("<title line>")' - ie: 'commit 90a7371cb08d ("coresight-tpdm: Add
nodes for dsb msr support")'
#13:
Fixes： 90a7371cb08d ("coresight-tpdm: Add nodes for dsb msr support")
total: 1 errors, 0 warnings, 8 lines checked
Suzuki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] coresight-tpdm: Correct the property name of MSR number
2023-10-24 6:19 [PATCH v1] coresight-tpdm: Correct the property name of MSR number Tao Zhang
2023-10-25 10:27 ` Suzuki K Poulose
@ 2023-11-01 13:26 ` Suzuki K Poulose
1 sibling, 0 replies; 3+ messages in thread
From: Suzuki K Poulose @ 2023-11-01 13:26 UTC (permalink / raw)
To: Mathieu Poirier, Konrad Dybcio, Krzysztof Kozlowski, Tao Zhang,
Rob Herring, Mike Leach, Alexander Shishkin
Cc: Suzuki K Poulose, andersson, devicetree, linux-kernel,
linux-arm-msm, Yuanfang Zhang, Jinlong Mao, Greg Kroah-Hartman,
Song Chai, Trilok Soni, linux-arm-kernel, Leo Yan, Tingwei Zhang,
coresight
On Tue, 24 Oct 2023 14:19:13 +0800, Tao Zhang wrote:
> Correct the property name of the DSB MSR number that needs to be
> read in TPDM driver. The right property name is
> "qcom,dsb-msrs-num".
>
> Fixes： 90a7371cb08d ("coresight-tpdm: Add nodes for dsb msr support")
>
>
> [...]
Applied, thanks!
[1/1] coresight-tpdm: Correct the property name of MSR number
https://git.kernel.org/coresight/c/20234c51cca7
Best regards,
--
Suzuki K Poulose <suzuki.poulose@arm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-01 13:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-24 6:19 [PATCH v1] coresight-tpdm: Correct the property name of MSR number Tao Zhang
2023-10-25 10:27 ` Suzuki K Poulose
2023-11-01 13:26 ` Suzuki K Poulose
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®