From: "Arnd Bergmann" <arnd@arndb.de>
To: "Ingo Molnar" <mingo@kernel.org>, linux-kernel@vger.kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Borislav Petkov" <bp@alien8.de>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Vitaly Kuznetsov" <vkuznets@redhat.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"David Woodhouse" <dwmw@amazon.co.uk>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Michal Marek" <michal.lkml@markovi.net>
Subject: Re: [PATCH 04/15] x86/kbuild: Introduce the 'x86_32' subarchitecture
Date: Wed, 07 May 2025 07:44:06 +0200 [thread overview]
Message-ID: <cd541739-4ec5-4772-9cef-e3527fc69e26@app.fastmail.com> (raw)
In-Reply-To: <20250506170924.3513161-5-mingo@kernel.org>
On Tue, May 6, 2025, at 19:09, Ingo Molnar wrote:
>
> # Additional ARCH settings for x86
> -ifeq ($(ARCH),i386)
> +ifeq ($(ARCH),x86_64)
> SRCARCH := x86
> endif
> -ifeq ($(ARCH),x86_64)
> +ifeq ($(ARCH),x86_32)
> + SRCARCH := x86
> +endif
> +ifeq ($(ARCH),i386)
> SRCARCH := x86
> endif
Would it be possible to just remove the entire SRCARCH hack
for x86? It's not clear from the changelog what the intention
was in 2007 when it was added, but my impression was that
this should be a temporary workaround to users doing
'make defconfig' on i386 would still get a 32-bit config
by default and didn't have to change there scripts.
I would guess that even in a 'setarch --32bit' environment,
most users today would want to build a 64-bit kernel, having
the special case for that seems to add more confusion that
it avoids.
Also, I don't think there are any systems that return
'x86_32' from 'uname -m', so your added special case
would never be used by default, only when cross-compiling
from some other architecture.
Arnd
next prev parent reply other threads:[~2025-05-07 5:44 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 17:09 [PATCH -v2 00/15] x86/kconfig: Enable various kernel features in the defconfig, add the 'x86_32' subarchitecture build target and misc cleanups Ingo Molnar
2025-05-06 17:09 ` [PATCH 01/15] x86/kconfig/64: Refresh defconfig Ingo Molnar
2025-05-07 5:31 ` Arnd Bergmann
2025-05-07 6:22 ` Ingo Molnar
2025-05-06 17:09 ` [PATCH 02/15] x86/kconfig/32: " Ingo Molnar
2025-05-06 17:09 ` [PATCH 03/15] x86/kconfig: Rename x86_64_defconfig to defconfig.x86_64 and i386_defconfig to defconfig.i386 Ingo Molnar
2025-05-09 18:10 ` Arnd Bergmann
2025-05-15 13:16 ` Ingo Molnar
2025-05-06 17:09 ` [PATCH 04/15] x86/kbuild: Introduce the 'x86_32' subarchitecture Ingo Molnar
2025-05-07 5:44 ` Arnd Bergmann [this message]
2025-05-07 6:35 ` Ingo Molnar
2025-05-09 12:04 ` David Laight
2025-05-09 18:00 ` H. Peter Anvin
2025-05-09 18:05 ` Arnd Bergmann
2025-05-06 17:09 ` [PATCH 05/15] x86/kbuild: Remove ancient 'arch/i386/' and 'arch/x86_64/' directory removal 'archclean' target Ingo Molnar
2025-05-06 17:09 ` [PATCH 06/15] x86/tools: insn_decoder_test.c: Emit standard build success messages Ingo Molnar
2025-05-06 17:09 ` [PATCH 07/15] x86/tools: insn_sanity.c: " Ingo Molnar
2025-05-06 17:09 ` [PATCH 08/15] x86/kconfig/64: Enable the KVM host in the defconfig Ingo Molnar
2025-05-06 17:09 ` [PATCH 09/15] x86/kconfig/64: Enable more virtualization guest options in the defconfig: enable Xen, Xen_PVH, Jailhouse, ACRN, Intel TDX and Hyper-V Ingo Molnar
2025-05-08 9:21 ` Jürgen Groß
2025-05-15 13:19 ` Ingo Molnar
2025-05-06 17:09 ` [PATCH 10/15] x86/kconfig/64: Enable BPF support in the defconfig Ingo Molnar
2025-05-06 17:09 ` [PATCH 11/15] x86/kconfig/64: Enable popular MM options " Ingo Molnar
2025-05-06 17:09 ` [PATCH 12/15] x86/kconfig/64: Enable popular kernel debugging " Ingo Molnar
2025-05-06 17:09 ` [PATCH 13/15] x86/kconfig/64: Enable popular scheduler, cgroups and namespaces " Ingo Molnar
2025-05-07 3:00 ` Yafang Shao
2025-05-07 7:06 ` Ingo Molnar
2025-05-07 11:42 ` Yafang Shao
2025-05-07 16:22 ` Ingo Molnar
2025-05-08 5:56 ` Yafang Shao
2025-05-22 5:49 ` Yafang Shao
2025-05-07 5:11 ` Arnd Bergmann
2025-05-07 16:09 ` Ingo Molnar
2025-05-28 17:22 ` Michal Koutný
2025-05-06 17:09 ` [PATCH 14/15] x86/kconfig/64: Enable popular generic kernel " Ingo Molnar
2025-05-06 17:09 ` [PATCH 15/15] x86/kconfig/32: Synchronize the x86-32 defconfig to the x86-64 defconfig Ingo Molnar
2025-05-07 5:27 ` Arnd Bergmann
2025-05-07 17:41 ` Ingo Molnar
2025-05-07 17:55 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2025-05-05 11:09 [PATCH 00/15] x86/kconfig: Enable various kernel features in the defconfig, add the 'x86_32' subarchitecture build target and misc cleanups Ingo Molnar
2025-05-05 11:09 ` [PATCH 04/15] x86/kbuild: Introduce the 'x86_32' subarchitecture Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd541739-4ec5-4772-9cef-e3527fc69e26@app.fastmail.com \
--to=arnd@arndb.de \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dwmw@amazon.co.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vkuznets@redhat.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome