* [PATCH] drm: amdgpu: add missing header dependencies
@ 2016-09-03 6:01 Baoyou Xie
2016-09-03 8:13 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Baoyou Xie @ 2016-09-03 6:01 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, Qingqing.Wang,
Jammy.Zhou, samuel.li
Cc: dri-devel, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get a few warnings when building kernel with W=1:
drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:113:6: warning: no previous prototype for 'amdgpu_pll_compute' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/cz_smc.c:38:10: warning: no previous prototype for 'cz_get_argument' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/cz_smc.c:302:5: warning: no previous prototype for 'cz_smu_start' [-Wmissing-prototypes]
....
In fact, these functions are declared in
drivers/gpu/drm/amd/amdgpu/atombios_i2c.h
drivers/gpu/drm/amd/amdgpu/amdgpu_pll.h
drivers/gpu/drm/amd/amdgpu/cz_dpm.h
drivers/gpu/drm/amd/amdgpu/vi_dpm.h.
So this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c | 1 +
drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 1 +
drivers/gpu/drm/amd/amdgpu/cz_smc.c | 2 ++
3 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c
index d153149..8e67c12 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c
@@ -25,6 +25,7 @@
#include "amdgpu.h"
#include "atom.h"
#include "atombios_encoders.h"
+#include "amdgpu_pll.h"
#include <asm/div64.h>
#include <linux/gcd.h>
diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c
index bc56c8a..b374653 100644
--- a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c
+++ b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c
@@ -27,6 +27,7 @@
#include "amdgpu.h"
#include "atom.h"
#include "amdgpu_atombios.h"
+#include "atombios_i2c.h"
#define TARGET_HW_I2C_CLOCK 50
diff --git a/drivers/gpu/drm/amd/amdgpu/cz_smc.c b/drivers/gpu/drm/amd/amdgpu/cz_smc.c
index c80c2e9..95887e4 100644
--- a/drivers/gpu/drm/amd/amdgpu/cz_smc.c
+++ b/drivers/gpu/drm/amd/amdgpu/cz_smc.c
@@ -29,6 +29,8 @@
#include "cz_smumgr.h"
#include "smu_ucode_xfer_cz.h"
#include "amdgpu_ucode.h"
+#include "cz_dpm.h"
+#include "vi_dpm.h"
#include "smu/smu_8_0_d.h"
#include "smu/smu_8_0_sh_mask.h"
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: amdgpu: add missing header dependencies
2016-09-03 6:01 [PATCH] drm: amdgpu: add missing header dependencies Baoyou Xie
@ 2016-09-03 8:13 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2016-09-03 8:13 UTC (permalink / raw)
To: Baoyou Xie, alexander.deucher, airlied, Qingqing.Wang,
Jammy.Zhou, samuel.li
Cc: dri-devel, linux-kernel, arnd, xie.baoyou
Am 03.09.2016 um 08:01 schrieb Baoyou Xie:
> We get a few warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:113:6: warning: no previous prototype for 'amdgpu_pll_compute' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/cz_smc.c:38:10: warning: no previous prototype for 'cz_get_argument' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/cz_smc.c:302:5: warning: no previous prototype for 'cz_smu_start' [-Wmissing-prototypes]
> ....
>
> In fact, these functions are declared in
> drivers/gpu/drm/amd/amdgpu/atombios_i2c.h
> drivers/gpu/drm/amd/amdgpu/amdgpu_pll.h
> drivers/gpu/drm/amd/amdgpu/cz_dpm.h
> drivers/gpu/drm/amd/amdgpu/vi_dpm.h.
> So this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Reviewed-by: Christian König <christian.koenig@amd.com>.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c | 1 +
> drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 1 +
> drivers/gpu/drm/amd/amdgpu/cz_smc.c | 2 ++
> 3 files changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c
> index d153149..8e67c12 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c
> @@ -25,6 +25,7 @@
> #include "amdgpu.h"
> #include "atom.h"
> #include "atombios_encoders.h"
> +#include "amdgpu_pll.h"
> #include <asm/div64.h>
> #include <linux/gcd.h>
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c
> index bc56c8a..b374653 100644
> --- a/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c
> +++ b/drivers/gpu/drm/amd/amdgpu/atombios_i2c.c
> @@ -27,6 +27,7 @@
> #include "amdgpu.h"
> #include "atom.h"
> #include "amdgpu_atombios.h"
> +#include "atombios_i2c.h"
>
> #define TARGET_HW_I2C_CLOCK 50
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/cz_smc.c b/drivers/gpu/drm/amd/amdgpu/cz_smc.c
> index c80c2e9..95887e4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/cz_smc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/cz_smc.c
> @@ -29,6 +29,8 @@
> #include "cz_smumgr.h"
> #include "smu_ucode_xfer_cz.h"
> #include "amdgpu_ucode.h"
> +#include "cz_dpm.h"
> +#include "vi_dpm.h"
>
> #include "smu/smu_8_0_d.h"
> #include "smu/smu_8_0_sh_mask.h"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-03 8:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-03 6:01 [PATCH] drm: amdgpu: add missing header dependencies Baoyou Xie
2016-09-03 8:13 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®