* [PATCH] ARM: at91: pm: remove useless extern definition
@ 2016-09-27 10:37 Alexandre Belloni
2016-09-27 11:58 ` Nicolas Ferre
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Belloni @ 2016-09-27 10:37 UTC (permalink / raw)
To: Nicolas Ferre
Cc: linux-arm-kernel, linux-kernel, Wenyou Yang, Alexandre Belloni
at91_ramc_base is local to pm.c, remove its definition in pm.h
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/mach-at91/pm.c | 2 +-
arch/arm/mach-at91/pm.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
index b4332b727e9c..3d89b7905bd9 100644
--- a/arch/arm/mach-at91/pm.c
+++ b/arch/arm/mach-at91/pm.c
@@ -55,7 +55,7 @@ static struct {
int memctrl;
} at91_pm_data;
-void __iomem *at91_ramc_base[2];
+static void __iomem *at91_ramc_base[2];
static int at91_pm_valid_state(suspend_state_t state)
{
diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
index 3fcf8810f14e..bf980c6ef294 100644
--- a/arch/arm/mach-at91/pm.h
+++ b/arch/arm/mach-at91/pm.h
@@ -18,8 +18,6 @@
#include <soc/at91/at91sam9_sdramc.h>
#ifndef __ASSEMBLY__
-extern void __iomem *at91_ramc_base[];
-
#define at91_ramc_read(id, field) \
__raw_readl(at91_ramc_base[id] + field)
--
2.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: at91: pm: remove useless extern definition
2016-09-27 10:37 [PATCH] ARM: at91: pm: remove useless extern definition Alexandre Belloni
@ 2016-09-27 11:58 ` Nicolas Ferre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2016-09-27 11:58 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: linux-arm-kernel, linux-kernel, Wenyou Yang
Le 27/09/2016 à 12:37, Alexandre Belloni a écrit :
> at91_ramc_base is local to pm.c, remove its definition in pm.h
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> arch/arm/mach-at91/pm.c | 2 +-
> arch/arm/mach-at91/pm.h | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index b4332b727e9c..3d89b7905bd9 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -55,7 +55,7 @@ static struct {
> int memctrl;
> } at91_pm_data;
>
> -void __iomem *at91_ramc_base[2];
> +static void __iomem *at91_ramc_base[2];
>
> static int at91_pm_valid_state(suspend_state_t state)
> {
> diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
> index 3fcf8810f14e..bf980c6ef294 100644
> --- a/arch/arm/mach-at91/pm.h
> +++ b/arch/arm/mach-at91/pm.h
> @@ -18,8 +18,6 @@
> #include <soc/at91/at91sam9_sdramc.h>
>
> #ifndef __ASSEMBLY__
> -extern void __iomem *at91_ramc_base[];
> -
> #define at91_ramc_read(id, field) \
> __raw_readl(at91_ramc_base[id] + field)
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-27 11:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-27 10:37 [PATCH] ARM: at91: pm: remove useless extern definition Alexandre Belloni
2016-09-27 11:58 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®