mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Feuerer <peter@piie.net>
To: Borislav Petkov <petkovbb@googlemail.com>
Cc: Pavel Machek <pavel@ucw.cz>,
	petkovbb@gmail.com, LKML <linux-kernel@vger.kernel.org>,
	lenb@kernel.org, Matthew Garrett <mjg59@srcf.ucam.org>,
	Maxim Levitsky <maximlevitsky@gmail.com>
Subject: Re: [PATCH] Acer Aspire One Fan Control
Date: Sun, 24 May 2009 13:13:39 +0200	[thread overview]
Message-ID: <cone.1243163619.528098.4387.1000@deskpiie> (raw)
In-Reply-To: <9ea470500905220753x6c2be25dq14422dff2acea422@mail.gmail.com>

Hi,

Borislav Petkov writes:

>> Yep, I don't disagree. But I strongly suspect that if you force the
>> fan off and overheat the machine, it will shut down in hardware before
>> doing any damage.
> 
> Yep, however we won't come that far with the current driver since it
> relinquishes control of the fan to the BIOS after a critical temp of
> 89° is reached. I'm still quite unpersuaded about that "magical" number
> since it is 1 degree below the high interval boundary of the juncture
> temperature of the Atom CPU. I would like to have a more reliable source
> for the allowed envelope based not only on the CPU but on the whole
> chipset but can't seem to find any data from Acer on that.

I think we are fine the way it is now. The driver allows to read the 
temperature by default and people who know what they are doing can easily 
enable kernel based fan control.

>>> the module can still be toggled on/off from sysfs. Actually, empirically
>>> measured, there seem to be three states of the fan: off, on and on-max
>>> where you can hear it rotating at max RPM. The kernel module can handle
>>> those completely if you know the respective ACPI EC commands and there's
>>> no need for userspace daemon, IMHO.
>>
>> It would be still nice to let the userspace lower the trip points for
>> maximum flexibility. No need for userspace _daemon_.
> 
> I'm sure Peter wouldn't mind adding some other sysfs entries in future
> versions of the driver controlling exactly that.

You can already change the trip points via the 
/sys/module/acerhdf/parameters/* files on the fly.

cheers,
--peter

  reply	other threads:[~2009-05-24 11:18 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-25  1:45 Peter Feuerer
2009-04-25  8:42 ` Peter Feuerer
2009-04-26 15:31   ` Matthew Garrett
2009-04-27 18:25     ` Peter Feuerer
2009-04-26 17:29   ` Borislav Petkov
2009-04-27 18:57     ` Peter Feuerer
2009-04-28  7:25       ` Borislav Petkov
2009-04-28 10:04         ` Maxim Levitsky
2009-04-28 20:17           ` Peter Feuerer
2009-04-28 20:31             ` Maxim Levitsky
2009-05-02 21:21               ` Peter Feuerer
2009-05-03 18:46                 ` Borislav Petkov
2009-05-06 19:41                   ` Peter Feuerer
2009-05-06 22:17                   ` Peter Feuerer
2009-05-09 17:14                     ` Borislav Petkov
2009-05-11 18:05                       ` Peter Feuerer
2009-05-12  6:02                         ` Borislav Petkov
2009-05-18 18:04                           ` Peter Feuerer
2009-05-18 20:20                             ` Joe Perches
2009-05-19  6:47                               ` Peter Feuerer
2009-05-19  7:06                                 ` Joe Perches
2009-05-24 19:22                             ` Borislav Petkov
2009-06-01 14:12                               ` Peter Feuerer
2009-06-03  7:35                                 ` Borislav Petkov
2009-06-03  8:10                                   ` Peter Feuerer
2009-06-03 10:52                                     ` Borislav Petkov
2009-06-03 11:29                                       ` Peter Feuerer
2009-06-03 13:07                                       ` Peter Feuerer
2009-06-03 14:49                                         ` Borislav Petkov
2009-06-01 14:18                               ` Peter Feuerer
2009-06-03  7:39                                 ` Borislav Petkov
2009-06-03  7:52                                   ` Peter Feuerer
2009-06-03  8:00                                     ` Borislav Petkov
2009-05-19 20:30                         ` Pavel Machek
2009-05-22 11:50                           ` Borislav Petkov
2009-05-22 14:09                             ` Pavel Machek
2009-05-22 14:53                               ` Borislav Petkov
2009-05-24 11:13                                 ` Peter Feuerer [this message]
2009-05-22 16:10                               ` [PATCH] Acer Aspire One Fan Contro Andreas Mohr
2009-05-22 18:24                                 ` Borislav Petkov
2009-05-22 19:35                                   ` Andreas Mohr
2009-04-26 22:20   ` [PATCH] Acer Aspire One Fan Control Joe Perches
2009-04-27 19:03     ` Peter Feuerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cone.1243163619.528098.4387.1000@deskpiie \
    --to=peter@piie.net \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=pavel@ucw.cz \
    --cc=petkovbb@gmail.com \
    --cc=petkovbb@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®