[PATCH 0/4] Fix some spurious errors at bootup

[PATCH 0/4] Fix some spurious errors at bootup

[Andy Lutomirski]

A bunch of drivers that my system loads spew out KERN_ERR or
severity-less messages at startup.  These message are not errors.  Fix
them.

Andy Lutomirski (4):
  mei: Don't log an error when the MEI device is quirked off
  megaraid: Downgrade success messages from KERN_ERR to dev_dbg
  sr: Add a missing KERN_INFO
  raid6: Add severity levels to raid6 initialization messages

 drivers/misc/mei/pci-me.c                   |  2 +-
 drivers/scsi/megaraid/megaraid_sas_base.c   |  2 +-
 drivers/scsi/megaraid/megaraid_sas_fusion.c |  2 +-
 drivers/scsi/sr.c                           |  3 ++-
 lib/raid6/algos.c                           | 13 +++++++------
 5 files changed, 12 insertions(+), 10 deletions(-)

-- 
1.8.5.3

[PATCH 1/4] mei: Don't log an error when the MEI device is quirked off

[Andy Lutomirski]

If an administrator wants to use MEI, they can search the logs for
'mei'.  Otherwise they don't need a glaring reminder that their
hardware doesn't actually support MEI.

Signed-off-by: Andy Lutomirski <luto@amacapital.net>
---
 drivers/misc/mei/pci-me.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
index ddadd08..809021e 100644
--- a/drivers/misc/mei/pci-me.c
+++ b/drivers/misc/mei/pci-me.c
@@ -127,7 +127,7 @@ static int mei_me_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	if (!mei_me_quirk_probe(pdev, ent)) {
 		err = -ENODEV;
-		goto end;
+		return err;  /* No point in logging an error. */
 	}
 
 	/* enable pci dev */
-- 
1.8.5.3

RE: [PATCH 1/4] mei: Don't log an error when the MEI device is quirked off

[Winkler, Tomas]

> -----Original Message-----
> From: Andy Lutomirski [mailto:luto@amacapital.net]
> Sent: Saturday, March 08, 2014 20:58
> To: linux-kernel@vger.kernel.org
> Cc: trivial@kernel.org; Andy Lutomirski; Winkler, Tomas
> Subject: [PATCH 1/4] mei: Don't log an error when the MEI device is quirked off
> 
> If an administrator wants to use MEI, they can search the logs for
> 'mei'.  Otherwise they don't need a glaring reminder that their
> hardware doesn't actually support MEI.
> 
> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
> ---
>  drivers/misc/mei/pci-me.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
> index ddadd08..809021e 100644
> --- a/drivers/misc/mei/pci-me.c
> +++ b/drivers/misc/mei/pci-me.c
> @@ -127,7 +127,7 @@ static int mei_me_probe(struct pci_dev *pdev, const
> struct pci_device_id *ent)
> 
>  	if (!mei_me_quirk_probe(pdev, ent)) {
>  		err = -ENODEV;
> -		goto end;
> +		return err;  /* No point in logging an error. */
>  	}


I would like to have at least some info/debug message logged, 
the issue was discovered on specific DELL machines and there is a little worry  
that on some systems it can be false positive.

Thanks
Tomas

Re: [PATCH 1/4] mei: Don't log an error when the MEI device is quirked off

[Andy Lutomirski]

On Tue, Mar 11, 2014 at 3:03 AM, Winkler, Tomas <tomas.winkler@intel.com> wrote:
>
>
>> -----Original Message-----
>> From: Andy Lutomirski [mailto:luto@amacapital.net]
>> Sent: Saturday, March 08, 2014 20:58
>> To: linux-kernel@vger.kernel.org
>> Cc: trivial@kernel.org; Andy Lutomirski; Winkler, Tomas
>> Subject: [PATCH 1/4] mei: Don't log an error when the MEI device is quirked off
>>
>> If an administrator wants to use MEI, they can search the logs for
>> 'mei'.  Otherwise they don't need a glaring reminder that their
>> hardware doesn't actually support MEI.
>>
>> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
>> ---
>>  drivers/misc/mei/pci-me.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
>> index ddadd08..809021e 100644
>> --- a/drivers/misc/mei/pci-me.c
>> +++ b/drivers/misc/mei/pci-me.c
>> @@ -127,7 +127,7 @@ static int mei_me_probe(struct pci_dev *pdev, const
>> struct pci_device_id *ent)
>>
>>       if (!mei_me_quirk_probe(pdev, ent)) {
>>               err = -ENODEV;
>> -             goto end;
>> +             return err;  /* No point in logging an error. */
>>       }
>
>
> I would like to have at least some info/debug message logged,
> the issue was discovered on specific DELL machines and there is a little worry
> that on some systems it can be false positive.

mei_me_quirk_probe logs "Device doesn't have valid ME Interface\n".

--Andy

RE: [PATCH 1/4] mei: Don't log an error when the MEI device is quirked off

[Winkler, Tomas]

> 
> >> If an administrator wants to use MEI, they can search the logs for
> >> 'mei'.  Otherwise they don't need a glaring reminder that their
> >> hardware doesn't actually support MEI.
> >>
> >> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
> >> ---
> >>  drivers/misc/mei/pci-me.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
> >> index ddadd08..809021e 100644
> >> --- a/drivers/misc/mei/pci-me.c
> >> +++ b/drivers/misc/mei/pci-me.c
> >> @@ -127,7 +127,7 @@ static int mei_me_probe(struct pci_dev *pdev, const
> >> struct pci_device_id *ent)
> >>
> >>       if (!mei_me_quirk_probe(pdev, ent)) {
> >>               err = -ENODEV;
> >> -             goto end;
> >> +             return err;  /* No point in logging an error. */
> >>       }
> >
> >
> > I would like to have at least some info/debug message logged,
> > the issue was discovered on specific DELL machines and there is a little worry
> > that on some systems it can be false positive.
> 
> mei_me_quirk_probe logs "Device doesn't have valid ME Interface\n".

Grrr, right! 
ACK, though it would be simpler just to:

     if (!mei_me_quirk_probe(pdev, ent))
                     return -ENODEV;

Even this is trivial fix I would prefer it will go through Greg's char-misc tree, as this is what I'm rebasing on.

Thanks
Tomas

[PATCH 2/4] megaraid: Downgrade success messages from KERN_ERR to dev_dbg

[Andy Lutomirski]

These messages are uninteresting indications of success.

Signed-off-by: Andy Lutomirski <luto@amacapital.net>
---
 drivers/scsi/megaraid/megaraid_sas_base.c   | 2 +-
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 3b7ad10..a0a133d 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -3755,7 +3755,7 @@ static int megasas_init_fw(struct megasas_instance *instance)
 	if (instance->instancet->init_adapter(instance))
 		goto fail_init_adapter;
 
-	printk(KERN_ERR "megasas: INIT adapter done\n");
+	dev_dbg(&instance->pdev->dev, "INIT adapter done\n");
 
 	/** for passthrough
 	* the following function will get the PD LIST.
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index f655592..261742a 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -679,7 +679,7 @@ megasas_ioc_init_fusion(struct megasas_instance *instance)
 		ret = 1;
 		goto fail_fw_init;
 	}
-	printk(KERN_ERR "megasas:IOC Init cmd success\n");
+	dev_dbg(&instance->pdev->dev, "IOC Init cmd success\n");
 
 	ret = 0;
 
-- 
1.8.5.3

[PATCH 3/4] sr: Add a missing KERN_INFO

[Andy Lutomirski]

The existence if scsi3-mmc capabilities is not an error.

Signed-off-by: Andy Lutomirski <luto@amacapital.net>
---
 drivers/scsi/sr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index 40d8592..67baf7f 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -887,7 +887,8 @@ static void get_capabilities(struct scsi_cd *cd)
 	cd->readcd_known = 1;
 	cd->readcd_cdda = buffer[n + 5] & 0x01;
 	/* print some capability bits */
-	printk("%s: scsi3-mmc drive: %dx/%dx %s%s%s%s%s%s\n", cd->cdi.name,
+	printk(KERN_INFO "%s: scsi3-mmc drive: %dx/%dx %s%s%s%s%s%s\n",
+	       cd->cdi.name,
 	       ((buffer[n + 14] << 8) + buffer[n + 15]) / 176,
 	       cd->cdi.speed,
 	       buffer[n + 3] & 0x01 ? "writer " : "", /* CD Writer */
-- 
1.8.5.3

[PATCH 4/4] raid6: Add severity levels to raid6 initialization messages

[Andy Lutomirski]

Some of them are errors; some are not.  Annotate them accordingly.

Signed-off-by: Andy Lutomirski <luto@amacapital.net>
---
 lib/raid6/algos.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c
index f0b1aa3..6edc821 100644
--- a/lib/raid6/algos.c
+++ b/lib/raid6/algos.c
@@ -121,9 +121,10 @@ static inline const struct raid6_recov_calls *raid6_choose_recov(void)
 		raid6_2data_recov = best->data2;
 		raid6_datap_recov = best->datap;
 
-		printk("raid6: using %s recovery algorithm\n", best->name);
+		printk(KERN_DEBUG "raid6: using %s recovery algorithm\n",
+		       best->name);
 	} else
-		printk("raid6: Yikes! No recovery algorithm found!\n");
+		printk(KERN_ERR "raid6: Yikes! No recovery algorithm found!\n");
 
 	return best;
 }
@@ -157,18 +158,18 @@ static inline const struct raid6_calls *raid6_choose_gen(
 				bestperf = perf;
 				best = *algo;
 			}
-			printk("raid6: %-8s %5ld MB/s\n", (*algo)->name,
+			printk(KERN_DEBUG "raid6: %-8s %5ld MB/s\n", (*algo)->name,
 			       (perf*HZ) >> (20-16+RAID6_TIME_JIFFIES_LG2));
 		}
 	}
 
 	if (best) {
-		printk("raid6: using algorithm %s (%ld MB/s)\n",
+		printk(KERN_DEBUG "raid6: using algorithm %s (%ld MB/s)\n",
 		       best->name,
 		       (bestperf*HZ) >> (20-16+RAID6_TIME_JIFFIES_LG2));
 		raid6_call = *best;
 	} else
-		printk("raid6: Yikes!  No algorithm found!\n");
+		printk(KERN_ERR "raid6: Yikes!  No algorithm found!\n");
 
 	return best;
 }
@@ -194,7 +195,7 @@ int __init raid6_select_algo(void)
 	syndromes = (void *) __get_free_pages(GFP_KERNEL, 1);
 
 	if (!syndromes) {
-		printk("raid6: Yikes!  No memory available.\n");
+		printk(KERN_ERR "raid6: Yikes!  No memory available.\n");
 		return -ENOMEM;
 	}
 
-- 
1.8.5.3

Re: [PATCH 4/4] raid6: Add severity levels to raid6 initialization messages

[Paul Bolle]

On Sat, 2014-03-08 at 10:58 -0800, Andy Lutomirski wrote:
> Some of them are errors; some are not.  Annotate them accordingly.
> 
> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
> ---
>  lib/raid6/algos.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c
> [...]
> @@ -194,7 +195,7 @@ int __init raid6_select_algo(void)
>  	syndromes = (void *) __get_free_pages(GFP_KERNEL, 1);
>  
>  	if (!syndromes) {
> -		printk("raid6: Yikes!  No memory available.\n");
> +		printk(KERN_ERR "raid6: Yikes!  No memory available.\n");
>  		return -ENOMEM;
>  	}
>  

Does __get_free_pages() print and error (or similar) when it fails? If
so, this printk() could be dropped, couldn't it?


Paul Bolle

Re: [PATCH 4/4] raid6: Add severity levels to raid6 initialization messages

[Andy Lutomirski]

On Sat, Mar 8, 2014 at 11:14 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Sat, 2014-03-08 at 10:58 -0800, Andy Lutomirski wrote:
>> Some of them are errors; some are not.  Annotate them accordingly.
>>
>> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
>> ---
>>  lib/raid6/algos.c | 13 +++++++------
>>  1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c
>> [...]
>> @@ -194,7 +195,7 @@ int __init raid6_select_algo(void)
>>       syndromes = (void *) __get_free_pages(GFP_KERNEL, 1);
>>
>>       if (!syndromes) {
>> -             printk("raid6: Yikes!  No memory available.\n");
>> +             printk(KERN_ERR "raid6: Yikes!  No memory available.\n");
>>               return -ENOMEM;
>>       }
>>
>
> Does __get_free_pages() print and error (or similar) when it fails? If
> so, this printk() could be dropped, couldn't it?

I think it does in warn_alloc_failed in mm/page_alloc.c.  It might not
be clear what the impact of that error is, but, empirically, if
there's too little memory during boot, everything is thoroughly broken
anyway.

>
>
> Paul Bolle
>



-- 
Andy Lutomirski
AMA Capital Management, LLC