mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] atkbd: disable spurious ACK/NAK warning on panic
@ 2006-11-13 20:43 Luca Tettamanti
  2006-11-13 21:24 ` Dmitry Torokhov
  0 siblings, 1 reply; 3+ messages in thread
From: Luca Tettamanti @ 2006-11-13 20:43 UTC (permalink / raw)
  To: Vojtech Pavlik; +Cc: Dmitry Torokhov, linux-kernel

After the panic() message has been printed kernel may blink keyboard
leds to signal the abnormal condition.
atkbd warns that "Some program might be trying access hardware directly"
at every blink, scrolling the useful text out of the screen.
Avoid printing the warning when oops_in_progress is set in order to
preserve the panic message.

Signed-Off-By: Luca Tettamanti <kronos.it@gmail.com>

---
 Patch against current GIT tree.

 drivers/input/keyboard/atkbd.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index cbb9366..81d2701 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -412,6 +412,8 @@ static irqreturn_t atkbd_interrupt(struc
 			goto out;
 		case ATKBD_RET_ACK:
 		case ATKBD_RET_NAK:
+			if (oops_in_progress)
+				goto out;
 			printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
 			       "Some program might be trying access hardware directly.\n",
 			       data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);


Luca
-- 
"In linea di principio sarei indifferente al natale, se solo il natale
 ricambiasse la cortesia e mi lasciasse in pace." -- Marco d'Itri

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] atkbd: disable spurious ACK/NAK warning on panic
  2006-11-13 20:43 [PATCH] atkbd: disable spurious ACK/NAK warning on panic Luca Tettamanti
@ 2006-11-13 21:24 ` Dmitry Torokhov
  2006-11-13 21:39   ` Luca Tettamanti
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2006-11-13 21:24 UTC (permalink / raw)
  To: Luca Tettamanti; +Cc: Vojtech Pavlik, linux-kernel

On 11/13/06, Luca Tettamanti <kronos.it@gmail.com> wrote:
> After the panic() message has been printed kernel may blink keyboard
> leds to signal the abnormal condition.
> atkbd warns that "Some program might be trying access hardware directly"
> at every blink, scrolling the useful text out of the screen.
> Avoid printing the warning when oops_in_progress is set in order to
> preserve the panic message.
>

Hi Luca,

Current input git tree already has code in i8042 supressing extra ACKs
caused by palic blinks; as soon as Linus pulls from me you should not
see these messages anymore.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] atkbd: disable spurious ACK/NAK warning on panic
  2006-11-13 21:24 ` Dmitry Torokhov
@ 2006-11-13 21:39   ` Luca Tettamanti
  0 siblings, 0 replies; 3+ messages in thread
From: Luca Tettamanti @ 2006-11-13 21:39 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: Vojtech Pavlik, linux-kernel

On 11/13/06, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
Hi,

> On 11/13/06, Luca Tettamanti <kronos.it@gmail.com> wrote:
> > After the panic() message has been printed kernel may blink keyboard
> > leds to signal the abnormal condition.
> > atkbd warns that "Some program might be trying access hardware directly"
> > at every blink, scrolling the useful text out of the screen.
> > Avoid printing the warning when oops_in_progress is set in order to
> > preserve the panic message.
>
> Current input git tree already has code in i8042 suppressing extra ACKs
> caused by panic blinks; as soon as Linus pulls from me you should not
> see these messages anymore.

Great, thanks.

Luca

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-11-13 21:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-11-13 20:43 [PATCH] atkbd: disable spurious ACK/NAK warning on panic Luca Tettamanti
2006-11-13 21:24 ` Dmitry Torokhov
2006-11-13 21:39   ` Luca Tettamanti

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®