From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, boris.ostrovsky@oracle.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Feng Kan <fkan@apm.com>
Subject: Re: [PATCH] xen/privcmd: Support correctly 64KB page granularity when mapping memory
Date: Wed, 7 Jun 2017 11:25:15 +0200 [thread overview]
Message-ID: <d255aacb-257d-4259-6345-390370ef641f@suse.com> (raw)
In-Reply-To: <20170531130357.14492-1-julien.grall@arm.com>
On 31/05/17 15:03, Julien Grall wrote:
> Commit 5995a68 "xen/privcmd: Add support for Linux 64KB page granularity" did
> not go far enough to support 64KB in mmap_batch_fn.
>
> The variable 'nr' is the number of 4KB chunk to map. However, when Linux
> is using 64KB page granularity the array of pages (vma->vm_private_data)
> contain one page per 64KB. Fix it by incrementing st->index correctly.
>
> Furthermore, st->va is not correctly incremented as PAGE_SIZE !=
> XEN_PAGE_SIZE.
>
> Fixes: 5995a68 ("xen/privcmd: Add support for Linux 64KB page granularity")
> CC: stable@vger.kernel.org
> Reported-by: Feng Kan <fkan@apm.com>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Committed to xen.tip for-linus-4.12b
Juergen
prev parent reply other threads:[~2017-06-07 9:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 13:03 Julien Grall
2017-05-31 13:54 ` Boris Ostrovsky
2017-06-01 12:50 ` Julien Grall
2017-06-01 13:33 ` Boris Ostrovsky
2017-06-01 14:01 ` Julien Grall
2017-06-01 15:16 ` Boris Ostrovsky
2017-06-01 15:38 ` Julien Grall
2017-06-01 20:41 ` Boris Ostrovsky
2017-06-01 21:04 ` Julien Grall
2017-06-06 16:17 ` Julien Grall
2017-06-07 9:25 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d255aacb-257d-4259-6345-390370ef641f@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=fkan@apm.com \
--cc=julien.grall@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®