From: Joe Perches <joe@perches.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 05/14] netconsole: Use eth_<foo>_addr instead of memset
Date: Mon, 2 Mar 2015 19:54:50 -0800 [thread overview]
Message-ID: <d2daaff790e6bc6bc49b7fe579f0396d7222ea58.1425354528.git.joe@perches.com> (raw)
In-Reply-To: <cover.1425354527.git.joe@perches.com>
Use the built-in function instead of memset.
Miscellanea:
Add #include <linux/etherdevice.h>
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/netconsole.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index ba2f5e7..15731d1 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -47,6 +47,7 @@
#include <linux/netpoll.h>
#include <linux/inet.h>
#include <linux/configfs.h>
+#include <linux/etherdevice.h>
MODULE_AUTHOR("Maintainer: Matt Mackall <mpm@selenic.com>");
MODULE_DESCRIPTION("Console driver for network interfaces");
@@ -185,7 +186,7 @@ static struct netconsole_target *alloc_param_target(char *target_config)
nt->np.local_port = 6665;
nt->np.remote_port = 6666;
mutex_init(&nt->mutex);
- memset(nt->np.remote_mac, 0xff, ETH_ALEN);
+ eth_broadcast_addr(nt->np.remote_mac);
/* Parse parameters and setup netpoll */
err = netpoll_parse_options(&nt->np, target_config);
@@ -604,7 +605,7 @@ static struct config_item *make_netconsole_target(struct config_group *group,
nt->np.local_port = 6665;
nt->np.remote_port = 6666;
mutex_init(&nt->mutex);
- memset(nt->np.remote_mac, 0xff, ETH_ALEN);
+ eth_broadcast_addr(nt->np.remote_mac);
/* Initialize the config_item member */
config_item_init_type_name(&nt->item, name, &netconsole_target_type);
--
2.1.2
next prev parent reply other threads:[~2015-03-03 4:00 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 3:54 [PATCH net-next 00/14] " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 01/14] etherdevice: Add eth_<foo>_addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code Joe Perches
2015-03-03 13:19 ` Eric Dumazet
2015-03-03 18:25 ` Joe Perches
2015-03-03 18:42 ` Eric Dumazet
2015-03-03 19:07 ` Joe Perches
2015-03-03 19:27 ` David Miller
2015-03-03 19:41 ` Joe Perches
2015-03-03 19:56 ` Eric Dumazet
2015-03-03 19:58 ` David Miller
2015-03-03 20:04 ` Joe Perches
2015-03-03 22:01 ` David Miller
2015-03-03 19:26 ` David Miller
2015-03-03 3:54 ` [PATCH net-next 02/14] ethernet: Use eth_<foo>_addr instead of memset Joe Perches
2015-03-03 4:09 ` Jeff Kirsher
2015-03-05 5:39 ` Don Fry
2015-03-03 3:54 ` [PATCH net-next 03/14] net: usb: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 04/14] wireless: " Joe Perches
2015-03-03 3:54 ` Joe Perches [this message]
2015-03-03 3:54 ` [PATCH net-next 06/14] xen: " Joe Perches
2015-03-03 10:05 ` Ian Campbell
2015-03-03 10:13 ` Wei Liu
2015-03-03 3:54 ` [PATCH net-next 07/14] 8021q: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 08/14] appletalk: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 09/14] atm: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 10/14] bluetooth: " Joe Perches
2015-03-03 7:04 ` Marcel Holtmann
2015-03-03 3:54 ` [PATCH net-next 11/14] ethernet: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 12/14] mac80211: " Joe Perches
2015-03-03 3:54 ` [PATCH net-next 13/14] wireless: " Joe Perches
2015-03-03 8:16 ` Johannes Berg
2015-03-03 8:37 ` Joe Perches
2015-03-03 8:44 ` Johannes Berg
2015-03-03 8:52 ` Joe Perches
2015-03-03 9:00 ` Johannes Berg
2015-03-03 10:29 ` Joe Perches
2015-03-03 10:34 ` Johannes Berg
2015-03-03 18:57 ` David Miller
2015-03-03 19:03 ` Joe Perches
2015-03-03 19:27 ` David Miller
2015-03-03 19:16 ` Johannes Berg
2015-03-03 3:54 ` [PATCH net-next 14/14] l2tp: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2daaff790e6bc6bc49b7fe579f0396d7222ea58.1425354528.git.joe@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®