mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Joe Perches <joe@perches.com>
Cc: netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Gustavo F. Padovan" <gustavo@padovan.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH net-next 10/14] bluetooth: Use eth_<foo>_addr instead of memset
Date: Mon, 2 Mar 2015 23:04:27 -0800	[thread overview]
Message-ID: <235052A1-0253-41FB-B381-FBC8B312ADE6@holtmann.org> (raw)
In-Reply-To: <3e4a2efa6cbc9bea479bd3d8460ea56dda128faf.1425354528.git.joe@perches.com>

Hi Joe,

> Use the built-in function instead of memset.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> net/bluetooth/bnep/netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/bnep/netdev.c b/net/bluetooth/bnep/netdev.c
> index 4b488ec..6ceb5d3 100644
> --- a/net/bluetooth/bnep/netdev.c
> +++ b/net/bluetooth/bnep/netdev.c
> @@ -218,7 +218,7 @@ static const struct net_device_ops bnep_netdev_ops = {
> void bnep_net_setup(struct net_device *dev)
> {
> 
> -	memset(dev->broadcast, 0xff, ETH_ALEN);
> +	eth_broadcast_addr(dev->broadcast);
> 	dev->addr_len = ETH_ALEN;

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel


  reply	other threads:[~2015-03-03  7:03 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03  3:54 [PATCH net-next 00/14] " Joe Perches
2015-03-03  3:54 ` [PATCH net-next 01/14] etherdevice: Add eth_<foo>_addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code Joe Perches
2015-03-03 13:19   ` Eric Dumazet
2015-03-03 18:25     ` Joe Perches
2015-03-03 18:42       ` Eric Dumazet
2015-03-03 19:07         ` Joe Perches
2015-03-03 19:27           ` David Miller
2015-03-03 19:41             ` Joe Perches
2015-03-03 19:56               ` Eric Dumazet
2015-03-03 19:58               ` David Miller
2015-03-03 20:04                 ` Joe Perches
2015-03-03 22:01                   ` David Miller
2015-03-03 19:26         ` David Miller
2015-03-03  3:54 ` [PATCH net-next 02/14] ethernet: Use eth_<foo>_addr instead of memset Joe Perches
2015-03-03  4:09   ` Jeff Kirsher
2015-03-05  5:39   ` Don Fry
2015-03-03  3:54 ` [PATCH net-next 03/14] net: usb: " Joe Perches
2015-03-03  3:54 ` [PATCH net-next 04/14] wireless: " Joe Perches
2015-03-03  3:54 ` [PATCH net-next 05/14] netconsole: " Joe Perches
2015-03-03  3:54 ` [PATCH net-next 06/14] xen: " Joe Perches
2015-03-03 10:05   ` Ian Campbell
2015-03-03 10:13   ` Wei Liu
2015-03-03  3:54 ` [PATCH net-next 07/14] 8021q: " Joe Perches
2015-03-03  3:54 ` [PATCH net-next 08/14] appletalk: " Joe Perches
2015-03-03  3:54 ` [PATCH net-next 09/14] atm: " Joe Perches
2015-03-03  3:54 ` [PATCH net-next 10/14] bluetooth: " Joe Perches
2015-03-03  7:04   ` Marcel Holtmann [this message]
2015-03-03  3:54 ` [PATCH net-next 11/14] ethernet: " Joe Perches
2015-03-03  3:54 ` [PATCH net-next 12/14] mac80211: " Joe Perches
2015-03-03  3:54 ` [PATCH net-next 13/14] wireless: " Joe Perches
2015-03-03  8:16   ` Johannes Berg
2015-03-03  8:37     ` Joe Perches
2015-03-03  8:44       ` Johannes Berg
2015-03-03  8:52         ` Joe Perches
2015-03-03  9:00           ` Johannes Berg
2015-03-03 10:29             ` Joe Perches
2015-03-03 10:34               ` Johannes Berg
2015-03-03 18:57     ` David Miller
2015-03-03 19:03       ` Joe Perches
2015-03-03 19:27         ` David Miller
2015-03-03 19:16       ` Johannes Berg
2015-03-03  3:54 ` [PATCH net-next 14/14] l2tp: " Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=235052A1-0253-41FB-B381-FBC8B312ADE6@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=davem@davemloft.net \
    --cc=gustavo@padovan.org \
    --cc=joe@perches.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®