From: "Chen, Yu C" <yu.c.chen@intel.com>
To: Hui Su <sh_def@163.com>
Cc: <peterz@infradead.org>, <kprateek.nayak@amd.com>,
<mingo@redhat.com>, <tim.c.chen@linux.intel.com>,
<juri.lelli@redhat.com>, <vincent.guittot@linaro.org>,
<dietmar.eggemann@arm.com>, <rostedt@goodmis.org>,
<bsegall@google.com>, <mgorman@suse.de>, <vschneid@redhat.com>,
<jstultz@google.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] sched/cache: Drive cache task tick from execution context
Date: Tue, 8 Sep 2026 15:45:08 +0800 [thread overview]
Message-ID: <d3d06a7d-1353-4007-9b05-80a2177266d6@intel.com> (raw)
In-Reply-To: <20260904085244.799276-3-sh_def@163.com>
On 9/4/2026 4:52 PM, Hui Su wrote:
> Cache-aware scheduling accounts CPU runtime to the mm of the task
> actually executing. update_se() passes the execution task to
> account_mm_sched() for this purpose.
>
> With proxy execution, however, sched_tick() invokes task_tick() for the
> scheduling context in rq->donor. task_tick_cache() is currently called
> from task_tick_fair(), so it is skipped when a fair task executes on
> behalf of an RT or deadline donor.
>
> In that case account_mm_sched() continues to advance runtime accounting
> for rq->curr, while task_tick_cache() does not advance the corresponding
> mm scan epoch. Once the epoch becomes stale, account_mm_sched() can
> invalidate the mm's preferred LLC.
>
> Move cache tick handling into sched_tick_exec_ctx(), alongside NUMA tick
> handling, and run it when the execution context is a fair task. Use the
> same helper from sched_tick() and sched_tick_remote() so both tick paths
> handle the execution context consistently.
>
> Keep the remaining task_tick_fair() bookkeeping with its task argument,
> since misfit, overutilized, and core scheduling state belong to the
> scheduling context.
>
> Fixes: df0d98475954 ("sched/cache: Introduce infrastructure for cache-aware load balancing")
> Suggested-by: Tim Chen <tim.c.chen@linux.intel.com>
> Signed-off-by: Hui Su <sh_def@163.com>
Thanks for the fix,
Reviewed-by: Chen Yu <yu.c.chen@intel.com>
thanks,
Chenyu
prev parent reply other threads:[~2026-09-08 7:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 8:52 [PATCH v3 0/2] sched: Fix execution-context tick handling under proxy execution Hui Su
2026-09-04 8:52 ` [PATCH v3 1/2] sched/numa: Drive NUMA task tick from execution context Hui Su
2026-09-04 15:52 ` Chen Yu
2026-09-04 17:17 ` Tim Chen
2026-09-08 7:40 ` Chen, Yu C
2026-09-08 8:35 ` Peter Zijlstra
2026-09-08 10:02 ` Chen, Yu C
2026-09-08 10:44 ` Peter Zijlstra
2026-09-08 12:10 ` Hui Su
2026-09-09 8:37 ` Peter Zijlstra
2026-09-04 8:52 ` [PATCH v3 2/2] sched/cache: Drive cache " Hui Su
2026-09-08 7:45 ` Chen, Yu C [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3d06a7d-1353-4007-9b05-80a2177266d6@intel.com \
--to=yu.c.chen@intel.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sh_def@163.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®