Re: [PATCH] get_maintainer: lazy load JSON::PP only when --json is used

[Joe Perches <joe@perches.com>]

On Sat, 2026-10-31 at 00:35 +0100, Oleg Nesterov wrote:
> On 10/30, Joe Perches wrote:
> > On Fri, 2026-10-30 at 23:55 +0100, Oleg Nesterov wrote:
> > > > > But why? Why make get_maintainer.pl depend on yet another module?
> > > > > FYI, on my Fedora 44
[]
> > > > Module::Load is a core perl module since 5.10 and
> > > > I think you are using a broken version of a perl installation
> 
> > > And how do you think it is broken? my laptop runs the fresh Fedora 44.
> > It doesn't include perl-core ;)
> 
> you can blame the Fedora maintainers, not me ;)

<smile>

That'd be the same as blaming the Fedora maintainers
for not including development-tools by default.

> > > I used ./scripts/get_maintainer.pl many years, almost every day, and I never
> > > needed to install the additional modules. Until ("get_maintainer: add --json
> > > output mode")
> > 
> > I think that was added in Linus' 7.2 in mid August and in -next since April
> 
> Yes, I hit this problem months ago, but didn't have time to send the fix.

Nor apparently have time to send an email to the get_maintainer
maintainer about it either.

> > I don't disagree with the concept of the patch.
> Great, then perhaps you can ACK my trivial patch? Then we can discuss
> the possible improvements.

Maybe when it's done without needing updates.
In the meantime, you have an easy workaround with dnf install perl-core.

> > I think we understand each other fine, you just care less about the
> > output error message.
> 
> Yes, it is true in that I don't really care about the output error message.
> 
> But then again. This error message can only happen if JSON::PP is not
> installed, and my patch doesn't make it worse?