From: Gal Pressman <gal@nvidia.com>
To: David Ahern <dsahern@kernel.org>,
Richard Gobert <richardbgobert@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, aleksander.lobakin@intel.com,
lixiaoyan@google.com, lucien.xin@gmail.com,
alexanderduyck@fb.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] gro: decrease size of CB
Date: Wed, 23 Aug 2023 17:43:27 +0300 [thread overview]
Message-ID: <d4cc1576-f4c3-a074-9bf4-937cdd3ff56d@nvidia.com> (raw)
In-Reply-To: <b45cedc6-3dbe-5cbb-1938-5c33cf9fc70d@kernel.org>
On 28/06/2023 17:19, David Ahern wrote:
> On 6/28/23 6:42 AM, Gal Pressman wrote:
>> On 27/06/2023 17:21, David Ahern wrote:
>>> On 6/26/23 2:55 AM, Gal Pressman wrote:
>>>> I believe this commit broke gro over udp tunnels.
>>>> I'm running iperf tcp traffic over geneve interfaces and the bandwidth
>>>> is pretty much zero.
>>>>
>>>
>>> Could you add a test script to tools/testing/selftests/net? It will help
>>> catch future regressions.
>>>
>>
>> I'm checking internally, someone from the team might be able to work on
>> this, though I'm not sure that a test that verifies bandwidth makes much
>> sense as a selftest.
>>
>
> With veth and namespaces I expect up to 25-30G performance levels,
> depending on the test. When something fundamental breaks like this patch
> a drop to < 1G would be a red flag, so there is value to the test.
Circling back to this, I believe such test already exists:
tools/testing/selftests/net/udpgro_fwd.sh
And it indeed fails before Richard's fix.
I guess all that's left is to actually run these tests :)?
next prev parent reply other threads:[~2023-08-23 14:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 16:09 [PATCH v3 0/1] " Richard Gobert
2023-06-01 16:14 ` [PATCH v3 1/1] " Richard Gobert
2023-06-06 7:25 ` Eric Dumazet
2023-06-26 8:55 ` Gal Pressman
2023-06-27 14:21 ` David Ahern
2023-06-28 12:42 ` Gal Pressman
2023-06-28 14:19 ` David Ahern
2023-08-23 14:43 ` Gal Pressman [this message]
2023-08-24 3:31 ` David Ahern
2023-06-29 12:36 ` Richard Gobert
2023-06-29 13:04 ` Gal Pressman
2023-06-30 15:39 ` Richard Gobert
2023-07-02 14:41 ` Gal Pressman
2023-07-02 14:46 ` Gal Pressman
2023-07-03 14:23 ` Richard Gobert
2023-07-07 12:31 ` Richard Gobert
2023-07-09 6:55 ` Gal Pressman
2023-06-02 14:22 ` [PATCH v3 0/1] " Alexander Lobakin
2023-06-05 13:58 ` Richard Gobert
2023-06-06 13:24 ` Alexander Lobakin
2023-06-06 9:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4cc1576-f4c3-a074-9bf4-937cdd3ff56d@nvidia.com \
--to=gal@nvidia.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixiaoyan@google.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®