mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <will@kernel.org>,
	<robin.murphy@arm.com>, <joro@8bytes.org>,
	<dmitry.baryshkov@linaro.org>, <jsnitsel@redhat.com>,
	<quic_bjorande@quicinc.com>, <mani@kernel.org>,
	<quic_eberman@quicinc.com>, <robdclark@chromium.org>,
	<u.kleine-koenig@pengutronix.de>, <robh@kernel.org>,
	<vladimir.oltean@nxp.com>, <quic_pkondeti@quicinc.com>,
	<quic_molvera@quicinc.com>
Cc: <linux-arm-msm@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <iommu@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>,
	<qipl.kernel.upstream@quicinc.com>
Subject: Re: [PATCH v4 5/5] iommu/arm-smmu: re-enable context caching in smmu reset operation
Date: Tue, 19 Dec 2023 18:36:31 +0530	[thread overview]
Message-ID: <d5291beb-7384-4ee9-a7a4-8aad931d7bc8@quicinc.com> (raw)
In-Reply-To: <3c7b8c2c-7174-4ced-8954-5a249f792c1e@linaro.org>



On 12/16/2023 5:24 AM, Konrad Dybcio wrote:
[...]
>> +
>> +	arm_mmu500_reset(smmu);
> We should check the return value here, in case the function is modified
> some day in a way that makes it return something else than 0
> 

Thanks for pointing this actually. I crosschecked on the
arm_mmu500_reset function behavior, looks like there's no return value
other than 0 and so the functionality won't change. I think we can
keep it as it is in this case.

Thanks,
Bibek

> LGTM otherwise!
> 
> Konrad

      parent reply	other threads:[~2023-12-19 13:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15 10:18 [PATCH v4 0/5] iommu/arm-smmu: introduction of ACTLR implementation for Qualcomm SoCs Bibek Kumar Patro
2023-12-15 10:18 ` [PATCH v4 1/5] iommu/arm-smmu: refactor qcom_smmu structure to include single pointer Bibek Kumar Patro
2023-12-15 10:18 ` [PATCH v4 2/5] iommu/arm-smmu: introduction of ACTLR for custom prefetcher settings Bibek Kumar Patro
2023-12-15 10:18 ` [PATCH v4 3/5] iommu/arm-smmu: add ACTLR data and support for SM8550 Bibek Kumar Patro
2023-12-15 10:44   ` Dmitry Baryshkov
2023-12-15 12:20     ` Bibek Kumar Patro
2023-12-15 12:54       ` Robin Murphy
2023-12-16  0:03         ` Konrad Dybcio
2023-12-16 16:15           ` Dmitry Baryshkov
2023-12-18  6:13             ` Bibek Kumar Patro
2023-12-18 11:23             ` Bibek Kumar Patro
2023-12-18 14:21               ` Dmitry Baryshkov
2023-12-19  8:24                 ` Bibek Kumar Patro
2023-12-19 10:21                   ` Dmitry Baryshkov
2023-12-19 10:36                     ` Bibek Kumar Patro
2023-12-19 10:44                       ` Dmitry Baryshkov
2023-12-19 11:39                         ` Bibek Kumar Patro
2023-12-18  6:17           ` Bibek Kumar Patro
2023-12-18  5:36         ` Bibek Kumar Patro
2023-12-15 23:35   ` Konrad Dybcio
2023-12-16 16:16     ` Dmitry Baryshkov
2023-12-18 11:40     ` Bibek Kumar Patro
2023-12-15 10:18 ` [PATCH v4 4/5] iommu/arm-smmu: add ACTLR data and support for SC7280 Bibek Kumar Patro
2023-12-15 10:18 ` [PATCH v4 5/5] iommu/arm-smmu: re-enable context caching in smmu reset operation Bibek Kumar Patro
2023-12-15 23:54   ` Konrad Dybcio
2023-12-18  6:37     ` Bibek Kumar Patro
2023-12-19 13:06     ` Bibek Kumar Patro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5291beb-7384-4ee9-a7a4-8aad931d7bc8@quicinc.com \
    --to=quic_bibekkum@quicinc.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=jsnitsel@redhat.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=qipl.kernel.upstream@quicinc.com \
    --cc=quic_bjorande@quicinc.com \
    --cc=quic_eberman@quicinc.com \
    --cc=quic_molvera@quicinc.com \
    --cc=quic_pkondeti@quicinc.com \
    --cc=robdclark@chromium.org \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vladimir.oltean@nxp.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®