From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bibek Kumar Patro <quic_bibekkum@quicinc.com>,
will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
dmitry.baryshkov@linaro.org, jsnitsel@redhat.com,
quic_bjorande@quicinc.com, mani@kernel.org,
quic_eberman@quicinc.com, robdclark@chromium.org,
u.kleine-koenig@pengutronix.de, robh@kernel.org,
vladimir.oltean@nxp.com, quic_pkondeti@quicinc.com,
quic_molvera@quicinc.com,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, qipl.kernel.upstream@quicinc.com
Subject: Re: [PATCH v4 3/5] iommu/arm-smmu: add ACTLR data and support for SM8550
Date: Sat, 16 Dec 2023 00:35:51 +0100 [thread overview]
Message-ID: <e4329952-34ac-4458-a63c-1f64e288614c@linaro.org> (raw)
In-Reply-To: <20231215101827.30549-4-quic_bibekkum@quicinc.com>
On 15.12.2023 11:18, Bibek Kumar Patro wrote:
> Add ACTLR data table for SM8550 along with support for
> same including SM8550 specific implementation operations.
>
> Signed-off-by: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
> ---
[...]
> +static const struct qcom_smmu_match_data sm8550_smmu_500_impl0_data = {
> + .impl = &qcom_smmu_500_impl,
> + .adreno_impl = &qcom_adreno_smmu_500_impl,
> + .cfg = &qcom_smmu_impl0_cfg,
> + .actlrcfg = sm8550_apps_actlr_cfg,
> + .actlrcfg_gfx = sm8550_gfx_actlr_cfg,
There are platforms that feature more than just APPS and Adreno SMMUs,
this implementation seems to assume there's only these two :/
I suppose the only way to solve this would be to introduce new compatibles
for each one of them.. Krzysztof, do you think that's reasonable? E.g.
MSM8996 has at least 5 instances, 8998 has at least 4 etc.
Konrad
next prev parent reply other threads:[~2023-12-15 23:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 10:18 [PATCH v4 0/5] iommu/arm-smmu: introduction of ACTLR implementation for Qualcomm SoCs Bibek Kumar Patro
2023-12-15 10:18 ` [PATCH v4 1/5] iommu/arm-smmu: refactor qcom_smmu structure to include single pointer Bibek Kumar Patro
2023-12-15 10:18 ` [PATCH v4 2/5] iommu/arm-smmu: introduction of ACTLR for custom prefetcher settings Bibek Kumar Patro
2023-12-15 10:18 ` [PATCH v4 3/5] iommu/arm-smmu: add ACTLR data and support for SM8550 Bibek Kumar Patro
2023-12-15 10:44 ` Dmitry Baryshkov
2023-12-15 12:20 ` Bibek Kumar Patro
2023-12-15 12:54 ` Robin Murphy
2023-12-16 0:03 ` Konrad Dybcio
2023-12-16 16:15 ` Dmitry Baryshkov
2023-12-18 6:13 ` Bibek Kumar Patro
2023-12-18 11:23 ` Bibek Kumar Patro
2023-12-18 14:21 ` Dmitry Baryshkov
2023-12-19 8:24 ` Bibek Kumar Patro
2023-12-19 10:21 ` Dmitry Baryshkov
2023-12-19 10:36 ` Bibek Kumar Patro
2023-12-19 10:44 ` Dmitry Baryshkov
2023-12-19 11:39 ` Bibek Kumar Patro
2023-12-18 6:17 ` Bibek Kumar Patro
2023-12-18 5:36 ` Bibek Kumar Patro
2023-12-15 23:35 ` Konrad Dybcio [this message]
2023-12-16 16:16 ` Dmitry Baryshkov
2023-12-18 11:40 ` Bibek Kumar Patro
2023-12-15 10:18 ` [PATCH v4 4/5] iommu/arm-smmu: add ACTLR data and support for SC7280 Bibek Kumar Patro
2023-12-15 10:18 ` [PATCH v4 5/5] iommu/arm-smmu: re-enable context caching in smmu reset operation Bibek Kumar Patro
2023-12-15 23:54 ` Konrad Dybcio
2023-12-18 6:37 ` Bibek Kumar Patro
2023-12-19 13:06 ` Bibek Kumar Patro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4329952-34ac-4458-a63c-1f64e288614c@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=jsnitsel@redhat.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=qipl.kernel.upstream@quicinc.com \
--cc=quic_bibekkum@quicinc.com \
--cc=quic_bjorande@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_molvera@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vladimir.oltean@nxp.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®