mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@codeconstruct.com.au>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 0/4] Add AST2700 INTC0/INTC1 support
Date: Thu, 5 Feb 2026 10:56:59 +0100	[thread overview]
Message-ID: <d5e45c9f-f3c7-4289-8991-02bd2c5b9587@kernel.org> (raw)
In-Reply-To: <TY2PPF5CB9A1BE69B07F90DFB245FAB735DF299A@TY2PPF5CB9A1BE6.apcprd06.prod.outlook.com>

On 05/02/2026 10:49, Ryan Chen wrote:
> 
>> Subject: Re: [PATCH 0/4] Add AST2700 INTC0/INTC1 support
>>
>> On Thu, Feb 05, 2026 at 02:07:18PM +0800, Ryan Chen wrote:
>>> This series replaces the existing AST2700 interrupt controller binding
>>> and driver. The original implementation was focused on a narrow,
>>> PSP-centric view and could not fully describe the complexity of the
>>> AST2700 interrupt fabric:
>>>
>>> * It was focused primarily on the perspective of the Primary Service
>>>   Processor (PSP).
>>> * It could not handle interrupt route configuration.
>>> * It could not handle interrupt register protection.
>>>
>>> By contrast, the new bindings and drivers describe the interrupt
>>> controllers at the block-function level and provide a unified binding
>>> design that can be used from the perspective of any of the four
>>> integrated processors (the Primary, Secondary and Tertiary Service
>>> Processors, and the Boot MCU):
>>
>> Where and how did you address last feedback given to you here:
>>
>> https://lore.kernel.org/all/20250814-auspicious-thundering-jaybird-b76f4f@ku
>> oka/
>>
>> "This binding is not improving. You are not responding to REAL problems
>> described to you. What's more, you send it in a way making our life difficult,
>> look:"
>>
>> So how did you make our life easier now?
>>
> Hi Krzysztof,
> 
> Thanks for your feedback.
> 
> The series you commented on in Aug 2025 (v4 1/2) attempted to model
> The hardware by introducing parent compatibles (aspeed,ast2700-intc0 /
> aspeed,ast2700-intc1) with child "interrupt-controller@" nodes using
> aspeed,ast2700-intc-ic. In hindsight, that approach did not align well
> with the actual hardware structure and resulted in inconsistencies
> between the diagrams, the schema, and the register layout (including
> unit-address issues). It was also difficult to review in isolation.

Read my question again:

"So how did you make our life easier now?"

And then read the earlier comment - what I expected of you. Please
answer these after the "look:" part.

Answer these please. I am not going to review any of these because you
keep ignoring our process of handling patches and not really responding
to review comments.

Best regards,
Krzysztof

  reply	other threads:[~2026-02-05  9:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-05  6:07 Ryan Chen
2026-02-05  6:07 ` [PATCH 1/4] dt-bindings: interrupt-controller: aspeed: Add ASPEED AST2700 INTC0/INTC1 Ryan Chen
2026-02-05  7:25   ` Rob Herring (Arm)
2026-02-05  8:53   ` Krzysztof Kozlowski
2026-02-05  6:07 ` [PATCH 2/4] irqchip/ast2700-intcx: Add AST2700 INTC0/INTC1 support Ryan Chen
2026-02-05 14:40   ` kernel test robot
2026-02-05 14:52   ` kernel test robot
2026-02-06 11:34   ` Thomas Gleixner
2026-02-07  3:50     ` Ryan Chen
2026-02-07 12:40       ` Thomas Gleixner
2026-02-08  2:27         ` Ryan Chen
2026-02-05  6:07 ` [PATCH 3/4] irqchip/aspeed: Remove legacy AST2700 interrupt controller driver Ryan Chen
2026-02-05  6:07 ` [PATCH 4/4] dt-bindings: interrupt-controller: aspeed: Remove legacy AST2700 interrupt binding Ryan Chen
2026-02-05  8:56   ` Krzysztof Kozlowski
2026-02-05  8:58 ` [PATCH 0/4] Add AST2700 INTC0/INTC1 support Krzysztof Kozlowski
2026-02-05  9:49   ` Ryan Chen
2026-02-05  9:56     ` Krzysztof Kozlowski [this message]
2026-02-06  7:19       ` Andrew Jeffery
2026-02-10  7:25         ` Andrew Jeffery
2026-02-12  5:58           ` Ryan Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5e45c9f-f3c7-4289-8991-02bd2c5b9587@kernel.org \
    --to=krzk@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=andrew@codeconstruct.com.au \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=ryan_chen@aspeedtech.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®