mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Yu Kuai <yukuai@fnnas.com>,
	axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: nilay@linux.ibm.com
Subject: Re: [PATCH RESEND v5 2/7] blk-mq-sched: unify elevators checking for async requests
Date: Mon, 17 Nov 2025 15:35:53 -0800	[thread overview]
Message-ID: <d6073899-710e-450d-9907-1a7a69a4a87d@acm.org> (raw)
In-Reply-To: <20251116035228.119987-3-yukuai@fnnas.com>

On 11/15/25 7:52 PM, Yu Kuai wrote:
> +static inline bool blk_mq_sched_sync_request(blk_opf_t opf)
> +{
> +	return op_is_sync(opf) && !op_is_write(opf);
> +}

The name of this function suggests that it performs an action while it
only performs a test. Please consider renaming this function into e.g.
blk_mq_is_sync_read(). I think the suggested name reflects much more
clearly what this function does than "blk_mq_sched_sync_request()".

Thanks,

Bart.

  reply	other threads:[~2025-11-17 23:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-16  3:52 [PATCH RESEND v5 0/7] blk-mq: introduce new queue attribute async_depth Yu Kuai
2025-11-16  3:52 ` [PATCH RESEND v5 1/7] block: convert nr_requests to unsigned int Yu Kuai
2025-11-16  3:52 ` [PATCH RESEND v5 2/7] blk-mq-sched: unify elevators checking for async requests Yu Kuai
2025-11-17 23:35   ` Bart Van Assche [this message]
2025-11-18  5:56     ` Yu Kuai
2025-11-16  3:52 ` [PATCH RESEND v5 3/7] blk-mq: add a new queue sysfs attribute async_depth Yu Kuai
2025-11-17 23:45   ` Bart Van Assche
2025-11-16  3:52 ` [PATCH RESEND v5 4/7] kyber: covert to use request_queue->async_depth Yu Kuai
2025-11-16  3:52 ` [PATCH RESEND v5 5/7] mq-deadline: " Yu Kuai
2025-11-16  3:52 ` [PATCH RESEND v5 6/7] block, bfq: convert " Yu Kuai
2025-11-16  3:52 ` [PATCH RESEND v5 7/7] blk-mq: add documentation for new queue attribute async_dpeth Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6073899-710e-450d-9907-1a7a69a4a87d@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nilay@linux.ibm.com \
    --cc=yukuai@fnnas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®