From: "Yu Kuai" <yukuai@fnnas.com>
To: "Bart Van Assche" <bvanassche@acm.org>, <axboe@kernel.dk>,
<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Yu Kuai" <yukuai@fnnas.com>
Cc: <nilay@linux.ibm.com>
Subject: Re: [PATCH RESEND v5 2/7] blk-mq-sched: unify elevators checking for async requests
Date: Tue, 18 Nov 2025 13:56:40 +0800 [thread overview]
Message-ID: <16e817ab-7444-4da8-bc92-38fa13cb407f@fnnas.com> (raw)
In-Reply-To: <d6073899-710e-450d-9907-1a7a69a4a87d@acm.org>
Hi,
在 2025/11/18 7:35, Bart Van Assche 写道:
> On 11/15/25 7:52 PM, Yu Kuai wrote:
>> +static inline bool blk_mq_sched_sync_request(blk_opf_t opf)
>> +{
>> + return op_is_sync(opf) && !op_is_write(opf);
>> +}
>
> The name of this function suggests that it performs an action while it
> only performs a test. Please consider renaming this function into e.g.
> blk_mq_is_sync_read(). I think the suggested name reflects much more
> clearly what this function does than "blk_mq_sched_sync_request()".
>
Yes, this sounds good.
> Thanks,
>
> Bart.
>
--
Thanks,
Kuai
next prev parent reply other threads:[~2025-11-18 5:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 3:52 [PATCH RESEND v5 0/7] blk-mq: introduce new queue attribute async_depth Yu Kuai
2025-11-16 3:52 ` [PATCH RESEND v5 1/7] block: convert nr_requests to unsigned int Yu Kuai
2025-11-16 3:52 ` [PATCH RESEND v5 2/7] blk-mq-sched: unify elevators checking for async requests Yu Kuai
2025-11-17 23:35 ` Bart Van Assche
2025-11-18 5:56 ` Yu Kuai [this message]
2025-11-16 3:52 ` [PATCH RESEND v5 3/7] blk-mq: add a new queue sysfs attribute async_depth Yu Kuai
2025-11-17 23:45 ` Bart Van Assche
2025-11-16 3:52 ` [PATCH RESEND v5 4/7] kyber: covert to use request_queue->async_depth Yu Kuai
2025-11-16 3:52 ` [PATCH RESEND v5 5/7] mq-deadline: " Yu Kuai
2025-11-16 3:52 ` [PATCH RESEND v5 6/7] block, bfq: convert " Yu Kuai
2025-11-16 3:52 ` [PATCH RESEND v5 7/7] blk-mq: add documentation for new queue attribute async_dpeth Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e817ab-7444-4da8-bc92-38fa13cb407f@fnnas.com \
--to=yukuai@fnnas.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®