* [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file.
@ 2025-12-17 11:28 Vivek Kumar Sahu
2025-12-17 11:28 ` [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement Vivek Kumar Sahu
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Vivek Kumar Sahu @ 2025-12-17 11:28 UTC (permalink / raw)
To: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
Balakrishna Godavarthi, Rocky Liao
Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree,
linux-kernel, linux-arm-msm, Vivek Kumar Sahu
Signed-off-by: Vivek Kumar Sahu <vivesahu@qti.qualcomm.com>
---
.../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
index 6353a336f382..197248d6f7b8 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
@@ -28,6 +28,7 @@ properties:
- qcom,wcn6750-bt
- qcom,wcn6855-bt
- qcom,wcn7850-bt
+ - qcom,qcc2072-bt
enable-gpios:
maxItems: 1
--
2.34.1
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement 2025-12-17 11:28 [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file Vivek Kumar Sahu @ 2025-12-17 11:28 ` Vivek Kumar Sahu 2025-12-17 14:29 ` Dmitry Baryshkov 2025-12-17 12:16 ` [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file Konrad Dybcio ` (2 subsequent siblings) 3 siblings, 1 reply; 12+ messages in thread From: Vivek Kumar Sahu @ 2025-12-17 11:28 UTC (permalink / raw) To: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, Vivek Kumar Sahu Adding support for BT SoC QCC2072. Set appropriate configurations for BT UART transport. Signed-off-by: Vivek Kumar Sahu <vivesahu@qti.qualcomm.com> --- drivers/bluetooth/btqca.c | 8 ++++++++ drivers/bluetooth/btqca.h | 1 + drivers/bluetooth/hci_qca.c | 17 +++++++++++++++++ 3 files changed, 26 insertions(+) diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c index 7c958d6065be..7eb095db4a1d 100644 --- a/drivers/bluetooth/btqca.c +++ b/drivers/bluetooth/btqca.c @@ -854,6 +854,10 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, snprintf(config.fwname, sizeof(config.fwname), "qca/hmtbtfw%02x.tlv", rom_ver); break; + case QCA_QCC2072: + snprintf(config.fwname, sizeof(config.fwname), + "qca/ornbtfw%02x.tlv", rom_ver); + break; default: snprintf(config.fwname, sizeof(config.fwname), "qca/rampatch_%08x.bin", soc_ver); @@ -929,6 +933,10 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, qca_get_nvm_name_by_board(config.fwname, sizeof(config.fwname), "hmtnv", soc_type, ver, rom_ver, boardid); break; + case QCA_QCC2072: + snprintf(config.fwname, sizeof(config.fwname), + "qca/ornnv%02x.bin", rom_ver); + break; default: snprintf(config.fwname, sizeof(config.fwname), "qca/nvm_%08x.bin", soc_ver); diff --git a/drivers/bluetooth/btqca.h b/drivers/bluetooth/btqca.h index 8f3c1b1c77b3..a175ac31e7b2 100644 --- a/drivers/bluetooth/btqca.h +++ b/drivers/bluetooth/btqca.h @@ -158,6 +158,7 @@ enum qca_btsoc_type { QCA_WCN6750, QCA_WCN6855, QCA_WCN7850, + QCA_QCC2072, }; #if IS_ENABLED(CONFIG_BT_QCA) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 888176b0faa9..1392a222ecd0 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -629,6 +629,7 @@ static int qca_open(struct hci_uart *hu) case QCA_WCN3991: case QCA_WCN3998: case QCA_WCN6750: + case QCA_QCC2072: hu->init_speed = qcadev->init_speed; break; @@ -1506,6 +1507,7 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type) case QCA_WCN6750: case QCA_WCN6855: case QCA_WCN7850: + case QCA_QCC2072: hci_uart_set_flow_control(hu, true); break; @@ -1515,6 +1517,7 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type) switch (soc_type) { case QCA_WCN3990: + case QCA_QCC2072: reinit_completion(&qca->drop_ev_comp); set_bit(QCA_DROP_VENDOR_EVENT, &qca->flags); break; @@ -1541,6 +1544,7 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type) case QCA_WCN6750: case QCA_WCN6855: case QCA_WCN7850: + case QCA_QCC2072: hci_uart_set_flow_control(hu, false); break; @@ -1550,6 +1554,7 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type) switch (soc_type) { case QCA_WCN3990: + case QCA_QCC2072: /* Wait for the controller to send the vendor event * for the baudrate change command. */ @@ -1919,6 +1924,9 @@ static int qca_setup(struct hci_uart *hu) case QCA_WCN7850: soc_name = "wcn7850"; break; + case QCA_QCC2072: + soc_name = "qcc2072"; + break; default: soc_name = "ROME/QCA6390"; @@ -1943,6 +1951,7 @@ static int qca_setup(struct hci_uart *hu) case QCA_WCN6750: case QCA_WCN6855: case QCA_WCN7850: + case QCA_QCC2072: qcadev = serdev_device_get_drvdata(hu->serdev); if (qcadev->bdaddr_property_broken) hci_set_quirk(hdev, HCI_QUIRK_BDADDR_PROPERTY_BROKEN); @@ -1977,6 +1986,7 @@ static int qca_setup(struct hci_uart *hu) case QCA_WCN6750: case QCA_WCN6855: case QCA_WCN7850: + case QCA_QCC2072: break; default: @@ -2125,6 +2135,12 @@ static const struct qca_device_data qca_soc_data_qca6390 __maybe_unused = { .num_vregs = 0, }; +static const struct qca_device_data qca_soc_data_qcc2072 __maybe_unused = { + .soc_type = QCA_QCC2072, + .num_vregs = 0, + .capabilities = QCA_CAP_WIDEBAND_SPEECH | QCA_CAP_VALID_LE_STATES, +}; + static const struct qca_device_data qca_soc_data_wcn6750 __maybe_unused = { .soc_type = QCA_WCN6750, .vregs = (struct qca_vreg []) { @@ -2723,6 +2739,7 @@ static const struct of_device_id qca_bluetooth_of_match[] = { { .compatible = "qcom,wcn6750-bt", .data = &qca_soc_data_wcn6750}, { .compatible = "qcom,wcn6855-bt", .data = &qca_soc_data_wcn6855}, { .compatible = "qcom,wcn7850-bt", .data = &qca_soc_data_wcn7850}, + { .compatible = "qcom,qcc2072-bt", .data = &qca_soc_data_qcc2072}, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, qca_bluetooth_of_match); -- 2.34.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement 2025-12-17 11:28 ` [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement Vivek Kumar Sahu @ 2025-12-17 14:29 ` Dmitry Baryshkov [not found] ` <BY5PR02MB69467A78CA2F2929B6618343F186A@BY5PR02MB6946.namprd02.prod.outlook.com> 0 siblings, 1 reply; 12+ messages in thread From: Dmitry Baryshkov @ 2025-12-17 14:29 UTC (permalink / raw) To: Vivek Kumar Sahu Cc: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao, quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm On Wed, Dec 17, 2025 at 04:58:50PM +0530, Vivek Kumar Sahu wrote: > Adding support for BT SoC QCC2072. > Set appropriate configurations for BT UART > transport. Read Documentation/process/submitting-patches.rst > > Signed-off-by: Vivek Kumar Sahu <vivesahu@qti.qualcomm.com> > --- > drivers/bluetooth/btqca.c | 8 ++++++++ > drivers/bluetooth/btqca.h | 1 + > drivers/bluetooth/hci_qca.c | 17 +++++++++++++++++ > 3 files changed, 26 insertions(+) > > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c > index 7c958d6065be..7eb095db4a1d 100644 > --- a/drivers/bluetooth/btqca.c > +++ b/drivers/bluetooth/btqca.c > @@ -854,6 +854,10 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, > snprintf(config.fwname, sizeof(config.fwname), > "qca/hmtbtfw%02x.tlv", rom_ver); > break; > + case QCA_QCC2072: Please keep the file sorted. Find a correct place to insert your changes rather than randomly sticking them to the end. This applies to _all_ the changes you've made here. > + snprintf(config.fwname, sizeof(config.fwname), > + "qca/ornbtfw%02x.tlv", rom_ver); I hope to see the firmware being submitted to linux-firmware. > + break; > default: > snprintf(config.fwname, sizeof(config.fwname), > "qca/rampatch_%08x.bin", soc_ver); > @@ -929,6 +933,10 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, > qca_get_nvm_name_by_board(config.fwname, sizeof(config.fwname), > "hmtnv", soc_type, ver, rom_ver, boardid); > break; > + case QCA_QCC2072: > + snprintf(config.fwname, sizeof(config.fwname), > + "qca/ornnv%02x.bin", rom_ver); No board-specific NVMEM dumps? > + break; > default: > snprintf(config.fwname, sizeof(config.fwname), > "qca/nvm_%08x.bin", soc_ver); -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <BY5PR02MB69467A78CA2F2929B6618343F186A@BY5PR02MB6946.namprd02.prod.outlook.com>]
* Re: Fw: [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement [not found] ` <BY5PR02MB69467A78CA2F2929B6618343F186A@BY5PR02MB6946.namprd02.prod.outlook.com> @ 2026-01-07 7:20 ` Vivek Sahu 2026-01-29 5:54 ` Vivek Sahu 0 siblings, 1 reply; 12+ messages in thread From: Vivek Sahu @ 2026-01-07 7:20 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi (QUIC), Rocky Liao (QUIC), Mohammed Sameer Mulla (QUIC), Harish Bandi (QUIC), linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, quic_janathot > From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > Sent: 17 December 2025 19:59 > To: Vivek Sahu <vivesahu@qti.qualcomm.com> > Cc: Marcel Holtmann <marcel@holtmann.org>; Luiz Augusto von Dentz <luiz.dentz@gmail.com>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Bartosz Golaszewski <brgl@bgdev.pl>; Balakrishna Godavarthi (QUIC) <quic_bgodavar@quicinc.com>; Rocky Liao (QUIC) <quic_rjliao@quicinc.com>; Mohammed Sameer Mulla (QUIC) <quic_mohamull@quicinc.com>; Harish Bandi (QUIC) <quic_hbandi@quicinc.com>; linux-bluetooth@vger.kernel.org <linux-bluetooth@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; linux-arm-msm@vger.kernel.org <linux-arm-msm@vger.kernel.org> > Subject: Re: [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement > > On Wed, Dec 17, 2025 at 04:58:50PM +0530, Vivek Kumar Sahu wrote: >> Adding support for BT SoC QCC2072. >> Set appropriate configurations for BT UART >> transport. > Read Documentation/process/submitting-patches.rst I'll make the commit message more clear in the next patch set of this commit. > >> Signed-off-by: Vivek Kumar Sahu <vivesahu@qti.qualcomm.com> >> --- >> drivers/bluetooth/btqca.c | 8 ++++++++ >> drivers/bluetooth/btqca.h | 1 + >> drivers/bluetooth/hci_qca.c | 17 +++++++++++++++++ >> 3 files changed, 26 insertions(+) >> >> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c >> index 7c958d6065be..7eb095db4a1d 100644 >> --- a/drivers/bluetooth/btqca.c >> +++ b/drivers/bluetooth/btqca.c >> @@ -854,6 +854,10 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, >> snprintf(config.fwname, sizeof(config.fwname), >> "qca/hmtbtfw%02x.tlv", rom_ver); >> break; >> + case QCA_QCC2072: > Please keep the file sorted. Find a correct place to insert your changes > rather than randomly sticking them to the end. This applies to _all_ the > changes you've made here. I'll address this in the next patch set of this commit. > >> + snprintf(config.fwname, sizeof(config.fwname), >> + "qca/ornbtfw%02x.tlv", rom_ver); > I hope to see the firmware being submitted to linux-firmware. "YES", firmware is being submitted. > >> + break; >> default: >> snprintf(config.fwname, sizeof(config.fwname), >> "qca/rampatch_%08x.bin", soc_ver); >> @@ -929,6 +933,10 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, >> qca_get_nvm_name_by_board(config.fwname, sizeof(config.fwname), >> "hmtnv", soc_type, ver, rom_ver, boardid); >> break; >> + case QCA_QCC2072: >> + snprintf(config.fwname, sizeof(config.fwname), >> + "qca/ornnv%02x.bin", rom_ver); > No board-specific NVMEM dumps? "NO", for this BT SoC there is no board specific NVM. > >> + break; >> default: >> snprintf(config.fwname, sizeof(config.fwname), >> "qca/nvm_%08x.bin", soc_ver); > -- > With best wishes > Dmitry ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Fw: [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement 2026-01-07 7:20 ` Fw: " Vivek Sahu @ 2026-01-29 5:54 ` Vivek Sahu 0 siblings, 0 replies; 12+ messages in thread From: Vivek Sahu @ 2026-01-29 5:54 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi (QUIC), Rocky Liao (QUIC), Mohammed Sameer Mulla (QUIC), Harish Bandi (QUIC), linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, quic_janathot On 1/7/2026 12:50 PM, Vivek Sahu wrote: >> From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> >> Sent: 17 December 2025 19:59 >> To: Vivek Sahu <vivesahu@qti.qualcomm.com> >> Cc: Marcel Holtmann <marcel@holtmann.org>; Luiz Augusto von Dentz >> <luiz.dentz@gmail.com>; Rob Herring <robh@kernel.org>; Krzysztof >> Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; >> Bartosz Golaszewski <brgl@bgdev.pl>; Balakrishna Godavarthi (QUIC) >> <quic_bgodavar@quicinc.com>; Rocky Liao (QUIC) >> <quic_rjliao@quicinc.com>; Mohammed Sameer Mulla (QUIC) >> <quic_mohamull@quicinc.com>; Harish Bandi (QUIC) >> <quic_hbandi@quicinc.com>; linux-bluetooth@vger.kernel.org >> <linux-bluetooth@vger.kernel.org>; devicetree@vger.kernel.org >> <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org >> <linux-kernel@vger.kernel.org>; linux-arm-msm@vger.kernel.org >> <linux-arm-msm@vger.kernel.org> >> Subject: Re: [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement >> >> On Wed, Dec 17, 2025 at 04:58:50PM +0530, Vivek Kumar Sahu wrote: >>> Adding support for BT SoC QCC2072. >>> Set appropriate configurations for BT UART >>> transport. >> Read Documentation/process/submitting-patches.rst > > > I'll make the commit message more clear in the next patch set of this > commit. > > >> >>> Signed-off-by: Vivek Kumar Sahu <vivesahu@qti.qualcomm.com> >>> --- >>> drivers/bluetooth/btqca.c | 8 ++++++++ >>> drivers/bluetooth/btqca.h | 1 + >>> drivers/bluetooth/hci_qca.c | 17 +++++++++++++++++ >>> 3 files changed, 26 insertions(+) >>> >>> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c >>> index 7c958d6065be..7eb095db4a1d 100644 >>> --- a/drivers/bluetooth/btqca.c >>> +++ b/drivers/bluetooth/btqca.c >>> @@ -854,6 +854,10 @@ int qca_uart_setup(struct hci_dev *hdev, >>> uint8_t baudrate, >>> snprintf(config.fwname, sizeof(config.fwname), >>> "qca/hmtbtfw%02x.tlv", rom_ver); >>> break; >>> + case QCA_QCC2072: >> Please keep the file sorted. Find a correct place to insert your changes >> rather than randomly sticking them to the end. This applies to _all_ the >> changes you've made here. > > > I'll address this in the next patch set of this commit. I just checked that "qca_btsoc_type" enum contains all the soc type which need to be enabled for BT enablement on the target device. There are few places where logic of framing packets transferring between SoC and Host depends on the which generation of the chip it is, refer api "qca_read_soc_version". And this applies to all the places in the file where i made the changes. So can we not sort it ? or you want me to sort in the switch cases where this chip set is added. > >> >>> + snprintf(config.fwname, sizeof(config.fwname), >>> + "qca/ornbtfw%02x.tlv", rom_ver); >> I hope to see the firmware being submitted to linux-firmware. > > > "YES", firmware is being submitted. We have up-streamed the firmware. > > >> >>> + break; >>> default: >>> snprintf(config.fwname, sizeof(config.fwname), >>> "qca/rampatch_%08x.bin", soc_ver); >>> @@ -929,6 +933,10 @@ int qca_uart_setup(struct hci_dev *hdev, >>> uint8_t baudrate, >>> qca_get_nvm_name_by_board(config.fwname, sizeof(config.fwname), >>> "hmtnv", soc_type, ver, rom_ver, >>> boardid); >>> break; >>> + case QCA_QCC2072: >>> + snprintf(config.fwname, sizeof(config.fwname), >>> + "qca/ornnv%02x.bin", rom_ver); >> No board-specific NVMEM dumps? > > > "NO", for this BT SoC there is no board specific NVM. > > >> >>> + break; >>> default: >>> snprintf(config.fwname, sizeof(config.fwname), >>> "qca/nvm_%08x.bin", soc_ver); >> -- >> With best wishes >> Dmitry ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file. 2025-12-17 11:28 [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file Vivek Kumar Sahu 2025-12-17 11:28 ` [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement Vivek Kumar Sahu @ 2025-12-17 12:16 ` Konrad Dybcio 2025-12-17 12:29 ` Krzysztof Kozlowski 2025-12-17 14:14 ` Paul Menzel 3 siblings, 0 replies; 12+ messages in thread From: Konrad Dybcio @ 2025-12-17 12:16 UTC (permalink / raw) To: Vivek Kumar Sahu, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm On 12/17/25 12:28 PM, Vivek Kumar Sahu wrote: > Signed-off-by: Vivek Kumar Sahu <vivesahu@qti.qualcomm.com> > --- You made no effort to analyze the contents of the file, or what a valid contribution would look like. Please read go/upstream and check out the previous changes to this file. Konrad ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file. 2025-12-17 11:28 [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file Vivek Kumar Sahu 2025-12-17 11:28 ` [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement Vivek Kumar Sahu 2025-12-17 12:16 ` [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file Konrad Dybcio @ 2025-12-17 12:29 ` Krzysztof Kozlowski [not found] ` <BY5PR02MB694654EA086696A43CA639DAF189A@BY5PR02MB6946.namprd02.prod.outlook.com> 2025-12-17 14:14 ` Paul Menzel 3 siblings, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2025-12-17 12:29 UTC (permalink / raw) To: Vivek Kumar Sahu, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm On 17/12/2025 12:28, Vivek Kumar Sahu wrote: > Signed-off-by: Vivek Kumar Sahu <vivesahu@qti.qualcomm.com> > --- > .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > index 6353a336f382..197248d6f7b8 100644 > --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > @@ -28,6 +28,7 @@ properties: > - qcom,wcn6750-bt > - qcom,wcn6855-bt > - qcom,wcn7850-bt > + - qcom,qcc2072-bt This patch fails multiple basic contribution guidelines. Read instruction how to contribute to upstream and how proper patchset should look like. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <BY5PR02MB694654EA086696A43CA639DAF189A@BY5PR02MB6946.namprd02.prod.outlook.com>]
* Re: Fw: [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file. [not found] ` <BY5PR02MB694654EA086696A43CA639DAF189A@BY5PR02MB6946.namprd02.prod.outlook.com> @ 2026-01-20 10:08 ` Vivek Sahu 0 siblings, 0 replies; 12+ messages in thread From: Vivek Sahu @ 2026-01-20 10:08 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Mohammed Sameer Mulla (QUIC), Harish Bandi (QUIC), linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi (QUIC), Rocky Liao (QUIC) > ________________________________ > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 17 December 2025 17:59 > To: Vivek Sahu <vivesahu@qti.qualcomm.com>; Marcel Holtmann <marcel@holtmann.org>; Luiz Augusto von Dentz <luiz.dentz@gmail.com>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Bartosz Golaszewski <brgl@bgdev.pl>; Balakrishna Godavarthi (QUIC) <quic_bgodavar@quicinc.com>; Rocky Liao (QUIC) <quic_rjliao@quicinc.com> > Cc: Mohammed Sameer Mulla (QUIC) <quic_mohamull@quicinc.com>; Harish Bandi (QUIC) <quic_hbandi@quicinc.com>; linux-bluetooth@vger.kernel.org <linux-bluetooth@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; linux-arm-msm@vger.kernel.org <linux-arm-msm@vger.kernel.org> > Subject: Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file. > > WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros. > > On 17/12/2025 12:28, Vivek Kumar Sahu wrote: >> Signed-off-by: Vivek Kumar Sahu <vivesahu@qti.qualcomm.com> >> --- >> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >> index 6353a336f382..197248d6f7b8 100644 >> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >> @@ -28,6 +28,7 @@ properties: >> - qcom,wcn6750-bt >> - qcom,wcn6855-bt >> - qcom,wcn7850-bt >> + - qcom,qcc2072-bt > This patch fails multiple basic contribution guidelines. Read > instruction how to contribute to upstream and how proper patchset should > look like. We have identified the problems and are rectifying it. It will be addressed in next patch of this commit. > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file. 2025-12-17 11:28 [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file Vivek Kumar Sahu ` (2 preceding siblings ...) 2025-12-17 12:29 ` Krzysztof Kozlowski @ 2025-12-17 14:14 ` Paul Menzel [not found] ` <BY5PR02MB6946637904902544E6767829F189A@BY5PR02MB6946.namprd02.prod.outlook.com> 3 siblings, 1 reply; 12+ messages in thread From: Paul Menzel @ 2025-12-17 14:14 UTC (permalink / raw) To: Vivek Kumar Sahu Cc: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao, quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm Dear Vivek, Thank you for your patch. The formatting is off, and the summary/title (subject) has two statements – look yourself in the archive [1]. Also the prefix seems wrong. Am 17.12.25 um 12:28 schrieb Vivek Kumar Sahu: > Signed-off-by: Vivek Kumar Sahu <vivesahu@qti.qualcomm.com> Please elaborate by giving more context, why it is compatible, and I’d like to see how you tested this. > --- > .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > index 6353a336f382..197248d6f7b8 100644 > --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > @@ -28,6 +28,7 @@ properties: > - qcom,wcn6750-bt > - qcom,wcn6855-bt > - qcom,wcn7850-bt > + - qcom,qcc2072-bt Lacking more lines, I am not certain, but I maybe this should be sorted. > > enable-gpios: > maxItems: 1 Kind regards, Paul [1]: https://lore.kernel.org/all/20251217112850.520572-1-vivesahu@qti.qualcomm.com/ ^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <BY5PR02MB6946637904902544E6767829F189A@BY5PR02MB6946.namprd02.prod.outlook.com>]
* Re: Fw: [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file. [not found] ` <BY5PR02MB6946637904902544E6767829F189A@BY5PR02MB6946.namprd02.prod.outlook.com> @ 2026-01-20 10:08 ` Vivek Sahu 2026-01-29 5:59 ` Vivek Sahu 0 siblings, 1 reply; 12+ messages in thread From: Vivek Sahu @ 2026-01-20 10:08 UTC (permalink / raw) To: Paul Menzel Cc: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi (QUIC), Rocky Liao (QUIC), Mohammed Sameer Mulla (QUIC), Harish Bandi (QUIC), linux-bluetooth, devicetree, linux-kernel, linux-arm-msm > ________________________________ > From: Paul Menzel <pmenzel@molgen.mpg.de> > Sent: 17 December 2025 19:44 > To: Vivek Sahu <vivesahu@qti.qualcomm.com> > Cc: Marcel Holtmann <marcel@holtmann.org>; Luiz Augusto von Dentz <luiz.dentz@gmail.com>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Bartosz Golaszewski <brgl@bgdev.pl>; Balakrishna Godavarthi (QUIC) <quic_bgodavar@quicinc.com>; Rocky Liao (QUIC) <quic_rjliao@quicinc.com>; Mohammed Sameer Mulla (QUIC) <quic_mohamull@quicinc.com>; Harish Bandi (QUIC) <quic_hbandi@quicinc.com>; linux-bluetooth@vger.kernel.org <linux-bluetooth@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; linux-arm-msm@vger.kernel.org <linux-arm-msm@vger.kernel.org> > Subject: Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file. > > WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros. > > Dear Vivek, > > > Thank you for your patch. The formatting is off, and the summary/title > (subject) has two statements – look yourself in the archive [1]. Also > the prefix seems wrong. > > Am 17.12.25 um 12:28 schrieb Vivek Kumar Sahu: >> Signed-off-by: Vivek Kumar Sahu <vivesahu@qti.qualcomm.com> > Please elaborate by giving more context, why it is compatible, and I’d > like to see how you tested this. The compatible string "qcom,qcc2072-bt" is defined in target dtsi file and it was tested on the hardware. The corresponding target specific dtsi file is currently merged in downstream. > >> --- >> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >> index 6353a336f382..197248d6f7b8 100644 >> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >> @@ -28,6 +28,7 @@ properties: >> - qcom,wcn6750-bt >> - qcom,wcn6855-bt >> - qcom,wcn7850-bt >> + - qcom,qcc2072-bt > Lacking more lines, I am not certain, but I maybe this should be sorted. I'll address it in next patch of this commit. > >> enable-gpios: >> maxItems: 1 > > Kind regards, > > Paul > > > [1]: > https://lore.kernel.org/all/20251217112850.520572-1-vivesahu@qti.qualcomm.com/ ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file. 2026-01-20 10:08 ` Fw: " Vivek Sahu @ 2026-01-29 5:59 ` Vivek Sahu 2026-01-29 16:18 ` Paul Menzel 0 siblings, 1 reply; 12+ messages in thread From: Vivek Sahu @ 2026-01-29 5:59 UTC (permalink / raw) To: Paul Menzel Cc: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi (QUIC), Rocky Liao (QUIC), Mohammed Sameer Mulla (QUIC), Harish Bandi (QUIC), linux-bluetooth, devicetree, linux-kernel, linux-arm-msm On 1/20/2026 3:38 PM, Vivek Sahu wrote: >> ________________________________ >> From: Paul Menzel <pmenzel@molgen.mpg.de> >> Sent: 17 December 2025 19:44 >> To: Vivek Sahu <vivesahu@qti.qualcomm.com> >> Cc: Marcel Holtmann <marcel@holtmann.org>; Luiz Augusto von Dentz >> <luiz.dentz@gmail.com>; Rob Herring <robh@kernel.org>; Krzysztof >> Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; >> Bartosz Golaszewski <brgl@bgdev.pl>; Balakrishna Godavarthi (QUIC) >> <quic_bgodavar@quicinc.com>; Rocky Liao (QUIC) >> <quic_rjliao@quicinc.com>; Mohammed Sameer Mulla (QUIC) >> <quic_mohamull@quicinc.com>; Harish Bandi (QUIC) >> <quic_hbandi@quicinc.com>; linux-bluetooth@vger.kernel.org >> <linux-bluetooth@vger.kernel.org>; devicetree@vger.kernel.org >> <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org >> <linux-kernel@vger.kernel.org>; linux-arm-msm@vger.kernel.org >> <linux-arm-msm@vger.kernel.org> >> Subject: Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT >> compatible string "qcom,qcc2072-bt" to yaml file. >> >> WARNING: This email originated from outside of Qualcomm. Please be >> wary of any links or attachments, and do not enable macros. >> >> Dear Vivek, >> >> >> Thank you for your patch. The formatting is off, and the summary/title >> (subject) has two statements – look yourself in the archive [1]. Also >> the prefix seems wrong. >> >> Am 17.12.25 um 12:28 schrieb Vivek Kumar Sahu: >>> Signed-off-by: Vivek Kumar Sahu <vivesahu@qti.qualcomm.com> >> Please elaborate by giving more context, why it is compatible, and I’d >> like to see how you tested this. > > The compatible string "qcom,qcc2072-bt" is defined in target dtsi file > and it was tested on the hardware. The corresponding target specific > dtsi file is currently merged in downstream. Please let me know if above statement gets you the answer of your question. > >> >>> --- >>> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>> b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>> >>> index 6353a336f382..197248d6f7b8 100644 >>> --- >>> a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>> +++ >>> b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>> @@ -28,6 +28,7 @@ properties: >>> - qcom,wcn6750-bt >>> - qcom,wcn6855-bt >>> - qcom,wcn7850-bt >>> + - qcom,qcc2072-bt >> Lacking more lines, I am not certain, but I maybe this should be sorted. > I'll address it in next patch of this commit. I just checked that "qca_btsoc_type" enum contains all the soc type which need to be enabled for BT enablement on the target device. There are few places where logic of framing packets transferring between SoC and Host depends on the which generation of the chip it is, refer api "qca_read_soc_version". Do you still suggest to sort it here ? >> >>> enable-gpios: >>> maxItems: 1 >> >> Kind regards, >> >> Paul >> >> >> [1]: >> https://lore.kernel.org/all/20251217112850.520572-1-vivesahu@qti.qualcomm.com/ >> ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file. 2026-01-29 5:59 ` Vivek Sahu @ 2026-01-29 16:18 ` Paul Menzel 0 siblings, 0 replies; 12+ messages in thread From: Paul Menzel @ 2026-01-29 16:18 UTC (permalink / raw) To: Vivek Sahu Cc: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao, Mohammed Sameer Mulla, Harish Bandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm Dear Vivek, Am 29.01.26 um 06:59 schrieb Vivek Sahu: > > On 1/20/2026 3:38 PM, Vivek Sahu wrote: >>> ________________________________ >>> From: Paul Menzel <pmenzel@molgen.mpg.de> >>> Sent: 17 December 2025 19:44 >>> To: Vivek Sahu <vivesahu@qti.qualcomm.com> >>> Cc: Marcel Holtmann <marcel@holtmann.org>; Luiz Augusto von Dentz >>> <luiz.dentz@gmail.com>; Rob Herring <robh@kernel.org>; Krzysztof >>> Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; >>> Bartosz Golaszewski <brgl@bgdev.pl>; Balakrishna Godavarthi (QUIC) >>> <quic_bgodavar@quicinc.com>; Rocky Liao (QUIC) >>> <quic_rjliao@quicinc.com>; Mohammed Sameer Mulla (QUIC) >>> <quic_mohamull@quicinc.com>; Harish Bandi (QUIC) >>> <quic_hbandi@quicinc.com>; linux-bluetooth@vger.kernel.org <linux- >>> bluetooth@vger.kernel.org>; devicetree@vger.kernel.org >>> <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux- >>> kernel@vger.kernel.org>; linux-arm-msm@vger.kernel.org <linux-arm- >>> msm@vger.kernel.org> >>> Subject: Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT >>> compatible string "qcom,qcc2072-bt" to yaml file. >>> >>> WARNING: This email originated from outside of Qualcomm. Please be >>> wary of any links or attachments, and do not enable macros. >>> >>> Dear Vivek, >>> >>> >>> Thank you for your patch. The formatting is off, and the summary/title >>> (subject) has two statements – look yourself in the archive [1]. Also >>> the prefix seems wrong. >>> >>> Am 17.12.25 um 12:28 schrieb Vivek Kumar Sahu: >>>> Signed-off-by: Vivek Kumar Sahu <vivesahu@qti.qualcomm.com> >>> Please elaborate by giving more context, why it is compatible, and I’d >>> like to see how you tested this. >> >> The compatible string "qcom,qcc2072-bt" is defined in target dtsi file >> and it was tested on the hardware. The corresponding target specific >> dtsi file is currently merged in downstream. > Please let me know if above statement gets you the answer of your question. >> >>> >>>> --- >>>> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>>> index 6353a336f382..197248d6f7b8 100644 >>>> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>>> @@ -28,6 +28,7 @@ properties: >>>> - qcom,wcn6750-bt >>>> - qcom,wcn6855-bt >>>> - qcom,wcn7850-bt >>>> + - qcom,qcc2072-bt >>> Lacking more lines, I am not certain, but I maybe this should be sorted. >> I'll address it in next patch of this commit. > I just checked that "qca_btsoc_type" enum contains all the soc type > which need to be enabled for BT enablement on the target device. > There are few places where logic of framing packets transferring > between SoC and Host depends on the which generation of the chip it > is, refer api "qca_read_soc_version".> > Do you still suggest to sort it here ? Yes, I’d prefer it sorted to easily find entries in the list. I suggest to create a separate commit to sort qcom,qca6390-bt correctly, and then your patch on top with qcc ordered after qca. >>>> enable-gpios: >>>> maxItems: 1 Kind regards, Paul >>> [1]: https://lore.kernel.org/all/20251217112850.520572-1-vivesahu@qti.qualcomm.com/ ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2026-01-29 16:18 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-17 11:28 [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file Vivek Kumar Sahu
2025-12-17 11:28 ` [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement Vivek Kumar Sahu
2025-12-17 14:29 ` Dmitry Baryshkov
[not found] ` <BY5PR02MB69467A78CA2F2929B6618343F186A@BY5PR02MB6946.namprd02.prod.outlook.com>
2026-01-07 7:20 ` Fw: " Vivek Sahu
2026-01-29 5:54 ` Vivek Sahu
2025-12-17 12:16 ` [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file Konrad Dybcio
2025-12-17 12:29 ` Krzysztof Kozlowski
[not found] ` <BY5PR02MB694654EA086696A43CA639DAF189A@BY5PR02MB6946.namprd02.prod.outlook.com>
2026-01-20 10:08 ` Fw: " Vivek Sahu
2025-12-17 14:14 ` Paul Menzel
[not found] ` <BY5PR02MB6946637904902544E6767829F189A@BY5PR02MB6946.namprd02.prod.outlook.com>
2026-01-20 10:08 ` Fw: " Vivek Sahu
2026-01-29 5:59 ` Vivek Sahu
2026-01-29 16:18 ` Paul Menzel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®