Re: RE: [PATCH v14 02/32] x86,fs/resctrl: Consolidate monitor event descriptions

["Moger, Babu" <bmoger@amd.com>]

Hi Tony,

On 6/25/2025 3:12 PM, Luck, Tony wrote:
>> I'm working on fixing these additional issues. I'll ping you when I
>> push to my GIT tree.
> 
> Pushed to the rdt-aet-v5.5 branch of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git
> 
> You need these four commits:
> 
> 2feb4e5716f7 x86,fs/resctrl: Prepare for more monitor events
> 3a86f90a9b81 x86/resctrl: Remove 'rdt_mon_features' global variable
> 3e720a9d3b46 x86,fs/resctrl: Replace architecture event enabled checks
> ed06edafba78 x86,fs/resctrl: Consolidate monitor event descriptions
> 
> Only first and last have substantive changes. Middle two might just have
> changed line numbers because of the first.
> 
> To fix the "landmine " code using "while (--idx)" I added a macro to
> do the iteration (originally suggested by Fenghua, but there were
> only two places to use it then, so it didn't seem worth it.)
> 
> Now there are 4 ... so here's my macro:
> 
> /* Iterate over memory bandwidth arrays in domain structures */
> #define for_each_mbm_idx(idx)                                   \
>          for (idx = 0; idx < QOS_NUM_L3_MBM_EVENTS; idx++)
> 
> Hopefully enough different from:
> 
> /* Iterate over all memory bandwidth events */
> #define for_each_mbm_event_id(eventid)                          \
>          for (eventid = QOS_L3_MBM_TOTAL_EVENT_ID;               \
>               eventid <= QOS_L3_MBM_LOCAL_EVENT_ID; eventid++)
> 
> to not cause confusion.
> 

Picked up the patches. Applied cleanly. Thanks a lot.

Thanks,
Babu