mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] x86/kvm/Kconfig: Ensure CRYPTO_DEV_CCP_DD state at minimum matches KVM_AMD
@ 2018-06-27 16:30 Janakarajan Natarajan
  2018-07-02 16:34 ` Brijesh Singh
  0 siblings, 1 reply; 3+ messages in thread
From: Janakarajan Natarajan @ 2018-06-27 16:30 UTC (permalink / raw)
  To: x86, kvm, linux-kernel
  Cc: Paolo Bonzini, Radim Krcmar, Thomas Gleixner, Ingo Molnar,
	H . Peter Anvin, Borislav Petkov, Brijesh Singh,
	Janakarajan Natarajan

Prevent a config where KVM_AMD=y and CRYPTO_DEV_CCP_DD=m thereby ensuring
that AMD Secure Processor device driver will be built-in when KVM_AMD is
also built-in.

v1->v2:
* Removed usage of 'imply' Kconfig option.
* Change patch commit message.

Fixes: 505c9e94d832 ("KVM: x86: prefer "depends on" to "select" for SEV")

Cc: <stable@vger.kernel.org> # 4.16.x
Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>
---
 arch/x86/kvm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index 92fd433..1bbec38 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -85,7 +85,7 @@ config KVM_AMD_SEV
 	def_bool y
 	bool "AMD Secure Encrypted Virtualization (SEV) support"
 	depends on KVM_AMD && X86_64
-	depends on CRYPTO_DEV_CCP && CRYPTO_DEV_CCP_DD && CRYPTO_DEV_SP_PSP
+	depends on CRYPTO_DEV_SP_PSP && !(KVM_AMD=y && CRYPTO_DEV_CCP_DD=m)
 	---help---
 	Provides support for launching Encrypted VMs on AMD processors.
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] x86/kvm/Kconfig: Ensure CRYPTO_DEV_CCP_DD state at minimum matches KVM_AMD
  2018-06-27 16:30 [PATCH v2] x86/kvm/Kconfig: Ensure CRYPTO_DEV_CCP_DD state at minimum matches KVM_AMD Janakarajan Natarajan
@ 2018-07-02 16:34 ` Brijesh Singh
  2018-07-15 15:36   ` Paolo Bonzini
  0 siblings, 1 reply; 3+ messages in thread
From: Brijesh Singh @ 2018-07-02 16:34 UTC (permalink / raw)
  To: Janakarajan Natarajan, x86, kvm, linux-kernel
  Cc: brijesh.singh, Paolo Bonzini, Radim Krcmar, Thomas Gleixner,
	Ingo Molnar, H . Peter Anvin, Borislav Petkov



On 06/27/2018 11:30 AM, Janakarajan Natarajan wrote:
> Prevent a config where KVM_AMD=y and CRYPTO_DEV_CCP_DD=m thereby ensuring
> that AMD Secure Processor device driver will be built-in when KVM_AMD is
> also built-in.
> 
> v1->v2:
> * Removed usage of 'imply' Kconfig option.
> * Change patch commit message.
> 
> Fixes: 505c9e94d832 ("KVM: x86: prefer "depends on" to "select" for SEV")
> 
> Cc: <stable@vger.kernel.org> # 4.16.x
> Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>
> ---

Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>


>   arch/x86/kvm/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index 92fd433..1bbec38 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -85,7 +85,7 @@ config KVM_AMD_SEV
>   	def_bool y
>   	bool "AMD Secure Encrypted Virtualization (SEV) support"
>   	depends on KVM_AMD && X86_64
> -	depends on CRYPTO_DEV_CCP && CRYPTO_DEV_CCP_DD && CRYPTO_DEV_SP_PSP
> +	depends on CRYPTO_DEV_SP_PSP && !(KVM_AMD=y && CRYPTO_DEV_CCP_DD=m)
>   	---help---
>   	Provides support for launching Encrypted VMs on AMD processors.
>   
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] x86/kvm/Kconfig: Ensure CRYPTO_DEV_CCP_DD state at minimum matches KVM_AMD
  2018-07-02 16:34 ` Brijesh Singh
@ 2018-07-15 15:36   ` Paolo Bonzini
  0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2018-07-15 15:36 UTC (permalink / raw)
  To: Brijesh Singh, Janakarajan Natarajan, x86, kvm, linux-kernel
  Cc: Radim Krcmar, Thomas Gleixner, Ingo Molnar, H . Peter Anvin,
	Borislav Petkov

On 02/07/2018 18:34, Brijesh Singh wrote:
> 
> 
> On 06/27/2018 11:30 AM, Janakarajan Natarajan wrote:
>> Prevent a config where KVM_AMD=y and CRYPTO_DEV_CCP_DD=m thereby ensuring
>> that AMD Secure Processor device driver will be built-in when KVM_AMD is
>> also built-in.
>>
>> v1->v2:
>> * Removed usage of 'imply' Kconfig option.
>> * Change patch commit message.
>>
>> Fixes: 505c9e94d832 ("KVM: x86: prefer "depends on" to "select" for SEV")
>>
>> Cc: <stable@vger.kernel.org> # 4.16.x
>> Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>
>> ---
> 
> Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
> 
> 
>>   arch/x86/kvm/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
>> index 92fd433..1bbec38 100644
>> --- a/arch/x86/kvm/Kconfig
>> +++ b/arch/x86/kvm/Kconfig
>> @@ -85,7 +85,7 @@ config KVM_AMD_SEV
>>       def_bool y
>>       bool "AMD Secure Encrypted Virtualization (SEV) support"
>>       depends on KVM_AMD && X86_64
>> -    depends on CRYPTO_DEV_CCP && CRYPTO_DEV_CCP_DD && CRYPTO_DEV_SP_PSP
>> +    depends on CRYPTO_DEV_SP_PSP && !(KVM_AMD=y && CRYPTO_DEV_CCP_DD=m)
>>       ---help---
>>       Provides support for launching Encrypted VMs on AMD processors.
>>  

Queued, thanks.

Paolo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-07-15 15:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-27 16:30 [PATCH v2] x86/kvm/Kconfig: Ensure CRYPTO_DEV_CCP_DD state at minimum matches KVM_AMD Janakarajan Natarajan
2018-07-02 16:34 ` Brijesh Singh
2018-07-15 15:36   ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome