mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Sistare <steven.sistare@oracle.com>
To: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Si-Wei Liu <si-wei.liu@oracle.com>,
	Eugenio Perez Martin <eperezma@redhat.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH V2 0/7] vdpa live update
Date: Fri, 12 Jul 2024 10:06:36 -0400	[thread overview]
Message-ID: <db3db0eb-f2f9-4062-893d-fd1017a9e783@oracle.com> (raw)
In-Reply-To: <1720790333-456232-1-git-send-email-steven.sistare@oracle.com>

On 7/12/2024 9:18 AM, Steve Sistare wrote:
> Live update is a technique wherein an application saves its state, exec's
> to an updated version of itself, and restores its state.  Clients of the
> application experience a brief suspension of service, on the order of
> 100's of milliseconds, but are otherwise unaffected.
> 
> Define and implement interfaces that allow vdpa devices to be preserved
> across fork or exec, to support live update for applications such as QEMU.
> The device must be suspended during the update, but its DMA mappings are
> preserved, so the suspension is brief.
> 
> The VHOST_NEW_OWNER ioctl transfers device ownership and pinned memory
> accounting from one process to another.
> 
> The VHOST_BACKEND_F_NEW_OWNER backend capability indicates that
> VHOST_NEW_OWNER is supported.
> 
> The VHOST_IOTLB_REMAP message type updates a DMA mapping with its userland
> address in the new process.
> 
> The VHOST_BACKEND_F_IOTLB_REMAP backend capability indicates that
> VHOST_IOTLB_REMAP is supported and required.  Some devices do not
> require it, because the userland address of each DMA mapping is discarded
> after being translated to a physical address.
> 
> Here is a pseudo-code sequence for performing live update, based on
> suspend + reset because resume is not yet widely available.  The vdpa device
> descriptor, fd, remains open across the exec.
> 
>    ioctl(fd, VHOST_VDPA_SUSPEND)
>    ioctl(fd, VHOST_VDPA_SET_STATUS, 0)
>    exec
> 
>    ioctl(fd, VHOST_NEW_OWNER)
> 
>    issue ioctls to re-create vrings
> 
>    if VHOST_BACKEND_F_IOTLB_REMAP
>        foreach dma mapping
>            write(fd, {VHOST_IOTLB_REMAP, new_addr})
> 
>    ioctl(fd, VHOST_VDPA_SET_STATUS,
>              ACKNOWLEDGE | DRIVER | FEATURES_OK | DRIVER_OK)
> 
> This is faster than VHOST_RESET_OWNER + VHOST_SET_OWNER + VHOST_IOTLB_UPDATE,
> as that would would unpin and repin physical pages, which would cost multiple
> seconds for large memories.
> 
> This is implemented in QEMU by the patch series "Live update: vdpa"
>    https://lore.kernel.org/qemu-devel/TBD  (reference to be posted shortly)

https://lore.kernel.org/qemu-devel/1720792931-456433-3-git-send-email-steven.sistare@oracle.com

> The QEMU implementation leverages the live migration code path, but after
> CPR exec's new QEMU:
>    - vhost_vdpa_set_owner() calls VHOST_NEW_OWNER instead of VHOST_SET_OWNER
>    - vhost_vdpa_dma_map() sets type VHOST_IOTLB_REMAP instead of
>      VHOST_IOTLB_UPDATE
> 
> Changes in V2:
>    - clean up handling of set_map vs dma_map vs platform iommu in remap
>    - augment and clarify commit messages and comments
> 
> Steve Sistare (7):
>    vhost-vdpa: count pinned memory
>    vhost-vdpa: pass mm to bind
>    vhost-vdpa: VHOST_NEW_OWNER
>    vhost-vdpa: VHOST_BACKEND_F_NEW_OWNER
>    vhost-vdpa: VHOST_IOTLB_REMAP
>    vhost-vdpa: VHOST_BACKEND_F_IOTLB_REMAP
>    vdpa/mlx5: new owner capability
> 
>   drivers/vdpa/mlx5/net/mlx5_vnet.c |   3 +-
>   drivers/vhost/vdpa.c              | 125 ++++++++++++++++++++++++++++--
>   drivers/vhost/vhost.c             |  15 ++++
>   drivers/vhost/vhost.h             |   1 +
>   include/uapi/linux/vhost.h        |  10 +++
>   include/uapi/linux/vhost_types.h  |  15 +++-
>   6 files changed, 161 insertions(+), 8 deletions(-)
> 

  parent reply	other threads:[~2024-07-12 14:06 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 13:18 Steve Sistare
2024-07-12 13:18 ` [PATCH V2 1/7] vhost-vdpa: count pinned memory Steve Sistare
2024-07-12 13:18 ` [PATCH V2 2/7] vhost-vdpa: pass mm to bind Steve Sistare
2024-07-12 13:18 ` [PATCH V2 3/7] vhost-vdpa: VHOST_NEW_OWNER Steve Sistare
2024-07-15  2:26   ` Jason Wang
2024-07-15  9:06     ` Michael S. Tsirkin
2024-07-15 14:27     ` Steven Sistare
2024-07-16  5:16       ` Jason Wang
2024-07-17 18:28         ` Steven Sistare
2024-07-22  7:26           ` Jason Wang
2024-07-15  9:07   ` Michael S. Tsirkin
2024-07-15 14:29     ` Steven Sistare
2024-07-15 14:38       ` Michael S. Tsirkin
2024-07-15 15:38         ` Steven Sistare
2024-07-12 13:18 ` [PATCH V2 4/7] vhost-vdpa: VHOST_BACKEND_F_NEW_OWNER Steve Sistare
2024-07-15  2:31   ` Jason Wang
2024-07-15 14:27     ` Steven Sistare
2024-07-12 13:18 ` [PATCH V2 5/7] vhost-vdpa: VHOST_IOTLB_REMAP Steve Sistare
2024-07-15  2:34   ` Jason Wang
2024-07-15 14:28     ` Steven Sistare
2024-07-16  5:28       ` Jason Wang
2024-07-17 18:29         ` Steven Sistare
2024-07-18  0:45           ` Jason Wang
2024-07-18 19:39             ` Michael S. Tsirkin
2024-07-18 20:19               ` Steven Sistare
2024-07-19  1:01                 ` Jason Wang
2024-07-12 13:18 ` [PATCH V2 6/7] vhost-vdpa: VHOST_BACKEND_F_IOTLB_REMAP Steve Sistare
2024-07-12 13:18 ` [PATCH V2 7/7] vdpa/mlx5: new owner capability Steve Sistare
2024-07-12 14:06 ` Steven Sistare [this message]
2024-07-15  2:14 ` [PATCH V2 0/7] vdpa live update Jason Wang
2024-07-15 14:28   ` Steven Sistare
2024-07-16  5:30     ` Jason Wang
2024-07-17 18:29       ` Steven Sistare
2024-07-18  0:33         ` Jason Wang
2024-07-20 21:34           ` Steven Sistare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db3db0eb-f2f9-4062-893d-fd1017a9e783@oracle.com \
    --to=steven.sistare@oracle.com \
    --cc=dtatulea@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=si-wei.liu@oracle.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®